-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Add inH2O Unit of Measure for the pressure class in number and sensor integrations. #39994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
Add UOM `inH20`
Add UOM `inH2O1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds documentation for the inH2O
(inches of water) unit of measure to the pressure device class in both sensor and number integrations. The change documents a new unit that was previously added to the core Home Assistant codebase.
- Adds
inH2O
to the supported pressure units in sensor integration documentation - Adds
inH2O
to the supported pressure units in number integration documentation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
source/_integrations/sensor.markdown | Adds inH2O unit to pressure device class documentation |
source/_integrations/number.markdown | Adds inH2O unit to pressure device class documentation |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 Walkthrough""" WalkthroughThe documentation for the "pressure" device class in both the Number and Sensor integrations was updated to include "inH2O" (inches of water) as a supported unit of measurement. Minor formatting adjustments were also made to the unit lists. Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/_integrations/number.markdown (1)
77-77
: Drop the Oxford comma for style consistencyOther unit lists in this document omit the comma before the final “or”. To stay uniform:
- - **pressure**: Pressure in Pa, kPa, hPa, bar, cbar, mbar, mmHg, inHg, inH2O, or psi + - **pressure**: Pressure in Pa, kPa, hPa, bar, cbar, mbar, mmHg, inHg, inH2O or psisource/_integrations/sensor.markdown (1)
88-88
: Match punctuation of existing unit listsMaintain the same formatting used elsewhere (no comma before the last “or”):
- - **pressure**: Pressure in Pa, kPa, hPa, bar, cbar, mbar, mmHg, inHg, inH2O, or psi + - **pressure**: Pressure in Pa, kPa, hPa, bar, cbar, mbar, mmHg, inHg, inH2O or psi
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (2)
source/_integrations/number.markdown
(1 hunks)source/_integrations/sensor.markdown
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
Removed Oxford comma.
Removed Oxford comma.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ekobres 👍
Proposed change
Add
inH2O
unit of measure in the pressure class ofnumber
andsensor
integrations markdowns.This documents changes made in a PR to core.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
inH2O
pressure unit core#148289Checklist
current
branch.next
branch.Summary by CodeRabbit