Skip to content

Document number selector default #40028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 16, 2025
Merged

Document number selector default #40028

merged 4 commits into from
Jul 16, 2025

Conversation

balloob
Copy link
Member

@balloob balloob commented Jul 16, 2025

Proposed change

Document new default behavior for number selector.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@Copilot Copilot AI review requested due to automatic review settings July 16, 2025 07:00
@home-assistant home-assistant bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Jul 16, 2025
@netlify Netlify
Copy link

netlify bot commented Jul 16, 2025 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 0a38ad4
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/687756242cbf1a0008b46baa
😎 Deploy Preview https://deploy-preview-40028--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot
Copilot AI reviewed Jul 16, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the documentation for the number selector to reflect its new conditional default behavior.

  • Change the default value description to show it depends on whether min and max are set.
Comments suppressed due to low confidence (1)

source/_docs/blueprint/selectors.markdown:1142

  • [nitpick] Consider clarifying this conditional default description for better readability. For example: "default: slider if both min and max are set; otherwise, box."
  default: slider if min and max set, else box

@balloob balloob mentioned this pull request Jul 16, 2025
Merged
19 tasks
c0ffeeca7
c0ffeeca7 reviewed Jul 16, 2025
View reviewed changes
@balloob @c0ffeeca7
Update source/_docs/blueprint/selectors.markdown
0a38ad4 
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
c0ffeeca7
c0ffeeca7 previously approved these changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @balloob 👍

@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label Jul 16, 2025
@home-assistant home-assistant bot added the parent-merged The parent PR has been merged already label Jul 16, 2025
abmantis
abmantis reviewed Jul 16, 2025
View reviewed changes
Copy link
Member

@abmantis abmantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

min/max have required: true. should we set them to false?

@c0ffeeca7 c0ffeeca7 enabled auto-merge (squash) July 16, 2025 12:13
@c0ffeeca7 c0ffeeca7 disabled auto-merge July 16, 2025 12:34
@balloob balloob closed this Jul 16, 2025
@home-assistant home-assistant bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Jul 16, 2025
@balloob balloob reopened this Jul 16, 2025
@balloob balloob enabled auto-merge (squash) July 16, 2025 12:34
@balloob balloob disabled auto-merge July 16, 2025 12:35
@balloob balloob merged commit a368621 into next Jul 16, 2025
7 checks passed
@balloob balloob deleted the number-selector-default branch July 16, 2025 12:35
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abmantis abmantis abmantis left review comments

Copilot code review Copilot Copilot left review comments

@c0ffeeca7 c0ffeeca7 c0ffeeca7 approved these changes

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in another repo next This PR goes into the next branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balloob @abmantis @c0ffeeca7
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy