Skip to content

update patch/minor dependencies #3459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 28, 2023
Merged

update patch/minor dependencies #3459

merged 6 commits into from
Oct 28, 2023

Conversation

bwp91
Copy link
Contributor

@bwp91 bwp91 commented Oct 28, 2023 •
edited
Loading

note: replaces #3436 see comments in that PR

♻️ Current situation

  • some dependencies are out of date
  • gitignore file does not include coverage directory
  • package.json engine node versions are at node v10 (we now only support 18 and 20)

I would like to start looking into updating some dependencies into their major new versions but wanted to get this done as the first stepping stone.

💡 Proposed solution

  • updates dependencies to latest minor/patch versions
  • updates devDependensies to some latest major/minor/patch versions
  • full refresh of package-lock.json
  • include coverage in gitignore file
  • update package.json file engines - node - to ^18.15.0 || ^20.7.0

⚙️ Release Notes

- update patch/minor dependencies

Testing

no tests changes, but all are passing

Reviewer Nudging

🤷‍♂️

@coveralls
Copy link

coveralls commented Oct 28, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6676798745

  • 1 of 5 (20.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 25.803%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ipcService.ts 1 2 50.0%
src/childBridgeService.ts 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/ipcService.ts 1 74.07%
Totals Coverage Status
Change from base Build 6676796283: -0.2%
Covered Lines: 392
Relevant Lines: 1365
💛 - Coveralls

@donavanbecker donavanbecker enabled auto-merge (squash) October 28, 2023 11:52
@donavanbecker donavanbecker merged commit 986e655 into beta-1.7.0 Oct 28, 2023
@donavanbecker donavanbecker deleted the bp/deps-one branch October 28, 2023 12:27
@donavanbecker donavanbecker restored the bp/deps-one branch October 30, 2023 15:13
@donavanbecker donavanbecker deleted the bp/deps-one branch October 30, 2023 15:13
donavanbecker added a commit that referenced this pull request Nov 4, 2023
@donavanbecker
v1.7.0
a1ca575 
## v1.7.0 (2023-11-04)

### Other Changes

- Update dependencies by @bwp91 in #3459 and #3460
donavanbecker pushed a commit that referenced this pull request Nov 4, 2023
@bwp91
beta -> latest (#3467)
50f9154 
## v1.7.0 (2023-11-04)

*Reminder: Node.js v18.15.0 or later is **required** to run Homebridge.*

### Other Changes

- Update dependencies by @bwp91 in #3459 and #3460
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donavanbecker donavanbecker donavanbecker approved these changes

@NorthernMan54 NorthernMan54 Awaiting requested review from NorthernMan54

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwp91 @coveralls @donavanbecker
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy