Make it possible to set Characteristic.SerialNumber via config.json #3761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donavanbecker
previously approved these changes
Jan 18, 2025
donavanbecker
approved these changes
Jan 18, 2025
Pull Request Test Coverage Report for Build 12845237236Details
💛 - Coveralls |
donavanbecker
pushed a commit
that referenced
this pull request
Jan 19, 2025
donavanbecker
pushed a commit
that referenced
this pull request
Jan 19, 2025
donavanbecker
pushed a commit
that referenced
this pull request
Jan 19, 2025
donavanbecker
pushed a commit
that referenced
this pull request
Jan 19, 2025
donavanbecker
pushed a commit
that referenced
this pull request
Feb 11, 2025
- Added method updateDisplayName() (#3764) (@justjam2013) - Fixed method handleUpdatePlatformAccessories() (#3765) (@justjam2013) - Make it possible to set Characteristic.SerialNumber via config.json (#3761) (@Vvorcun) - minor dependency updates - fix: check for valid array in `handleUpdatePlatformAccessories` - minor dependency updates - `hap-nodejs` @ `v0.12.3`
Merged
bwp91
pushed a commit
that referenced
this pull request
Feb 11, 2025
bwp91
added a commit
that referenced
this pull request
Feb 11, 2025
- Added method updateDisplayName() (#3764) (@justjam2013) - Fixed method handleUpdatePlatformAccessories() (#3765) (@justjam2013) - Make it possible to set Characteristic.SerialNumber via config.json (#3761) (@Vvorcun) - minor dependency updates - fix: check for valid array in `handleUpdatePlatformAccessories` - minor dependency updates - `hap-nodejs` @ `v0.12.3`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
Right now Characteristic.SerialNumber for the bridge is only set to bridgeConfig.username, which may be good for functionality, but not so good for cosmetic purposes - when running on devices like Raspberry Pi it would be really cool to be able to set this to the real serial number.
💡 Proposed solution
As said in title - make it possible to set Characteristic.SerialNumber via config.json. Proposed solution (sounds really pretentious for two strings of code) preserves current behaviour, meaning if no bridgeConfig.serialNumber is present it still defaults to bridgeConfig.username.