NodeJS 24 initial support #2451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
seems to be windows and node 24 in which the actions tests are failing |
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces initial support for NodeJS 24 in preparation for its LTS release in fall 2025. Key changes include:
- Updating the Node engine field in package.json to include NodeJS 24.
- Upgrading the @homebridge/node-pty-prebuilt-multiarch dependency to a beta version.
- Expanding the test matrix in the GitHub Actions workflow to run on NodeJS 24.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated Node engine requirement and promoted @homebridge/node-pty-prebuilt-multiarch version. |
| CHANGELOG.md | Added an entry to document the initial support for NodeJS 24. |
| .github/workflows/validate.yml | Expanded the NodeJS versions used in the test matrix to include 24.x. |
Comments suppressed due to low confidence (2)
.github/workflows/validate.yml:42
- With NodeJS 24 added to the test matrix, ensure that the existing test suites adequately cover any NodeJS 24-specific behaviors.
node-version: [20.x, 22.x, 24.x]
package.json:86
- Using a beta dependency version in production code can introduce instability. Verify that its use aligns with release plans and consider adding a comment to track its promotion to a stable release.
"@homebridge/node-pty-prebuilt-multiarch": "^0.13.0-beta.4"
|
@bwp91 I fixed the upstream issues with node-pty and the Microsoft NodeJS 24 builds, so it is all good now. Am thinking this can be merged as well |
bwp91
approved these changes
Jun 11, 2025
bwp91
added a commit
that referenced
this pull request
Jun 11, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jun 11, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jun 14, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jun 14, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jun 14, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jun 15, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jun 15, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jun 15, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
Closed
bwp91
added a commit
that referenced
this pull request
Jun 17, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jun 18, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jun 18, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jun 19, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jun 19, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jun 19, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jun 29, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jun 29, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jun 29, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jun 29, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jun 30, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jul 1, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jul 2, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jul 2, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jul 2, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jul 3, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jul 3, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jul 7, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jul 9, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jul 9, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jul 11, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jul 12, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jul 12, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
bwp91
added a commit
that referenced
this pull request
Jul 12, 2025
…2451) Co-Authored-By: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is initial support for NodeJS 24, in preparation for it going LTS in fall of 2025.
Pls note node-pty-prebuilt-multiarch is currently tagged to the beta branch, and needs to promoted prior to formal release. homebridge/node-pty-prebuilt-multiarch#59