Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HISourcesSmallCatalog returns SkyModel instead of path #605

Open
sfiruch opened this issue Aug 8, 2024 · 1 comment
Open

HISourcesSmallCatalog returns SkyModel instead of path #605

sfiruch opened this issue Aug 8, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@sfiruch
Copy link
Member

sfiruch commented Aug 8, 2024 •
edited
Loading

When one wants to use the "HISourcesSmallCatalog", you have to parse the results manually, as seen in https://github.com/i4Ds/Karabo-Pipeline/blob/main/karabo/examples/LineEmissionBackendsComparison.ipynb:

catalog_path = HISourcesSmallCatalogDownloadObject().get()
print(catalog_path)
sky = SkyModel.get_sky_model_from_h5_to_xarray(
    path=catalog_path,
)

Instead of a path, the function should return the parsed results directly, i.e. a SkyModel.

(And the LineEmissionBackendsComparison.ipynb example should be changed accordingly)
@sfiruch sfiruch added the enhancement New feature or request label Aug 8, 2024
@Lukas113
Copy link
Collaborator

Lukas113 commented Aug 8, 2024 •
edited
Loading

I agree. Actually, I'm also thinking about reducing the number of functions from the SkyModel.get_* area (like get_MALS_DR1V3_Sky, get_MIGHTEE_Sky, get_GLEAM_Sky, etc... to get it from:

  • Litererals from a single function
  • a different module which doesn't extend the SkyModel for each Sky which is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sfiruch @Lukas113
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy