chore: delete user codersdk to support status code regression (coder#14173)

Emyrk · aslilac · web-flow · commit b55a7a8b78ee · 2024-08-07T11:19:31.000-05:00
* chore: delete user codersdk to support status code regression
* Update codersdk/users.go

Co-authored-by: Kayla Washburn-Love &lt;mckayla@hey.com&gt;

---------

Co-authored-by: Kayla Washburn-Love &lt;mckayla@hey.com&gt;
diff --git a/codersdk/users.go b/codersdk/users.go
@@ -309,7 +309,9 @@ func (c *Client) DeleteUser(ctx context.Context, id uuid.UUID) error {
 		return err
 	}
 	defer res.Body.Close()
-	if res.StatusCode != http.StatusOK {
+	// Check for a 200 or a 204 response. 2.14.0 accidentally included a 204 response,
+	// which was a breaking change, and reverted in 2.14.1.
+	if res.StatusCode != http.StatusOK && res.StatusCode != http.StatusNoContent {
 		return ReadBodyAsError(res)
 	}
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -309,7 +309,9 @@ func (c *Client) DeleteUser(ctx context.Context, id uuid.UUID) error {`
`309`	`309`	`return err`
`310`	`310`	`}`
`311`	`311`	`defer res.Body.Close()`
`312`		`- if res.StatusCode != http.StatusOK {`
	`312`	`+ // Check for a 200 or a 204 response. 2.14.0 accidentally included a 204 response,`
	`313`	`+ // which was a breaking change, and reverted in 2.14.1.`
	`314`	`+ if res.StatusCode != http.StatusOK && res.StatusCode != http.StatusNoContent {`
`313`	`315`	`return ReadBodyAsError(res)`
`314`	`316`	`}`
`315`	`317`	`return nil`