no vim or emacs

jpsca · jpsca · commit 6899c5549e8a · 2019-02-11T22:56:25.000-05:00
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "Text-Editor"
-version = "1.0.1"
+version = "1.0.2"
 description = "Like webbrowser, but for the text editor"
 authors = [
     "Juan-Pablo Scaletti <juanpablo@jpscaletti.com>"
diff --git a/texteditor.py b/texteditor.py
@@ -3,7 +3,6 @@
 """
 import io
 import os
-import pkg_resources
 import re
 import sys
 import subprocess
@@ -16,25 +15,31 @@
 
 EDITOR = 'EDITOR'
 
+"""Why not include vim or emacs? Because:
+
+1. If you are using it, you know what the EDITOR variable is, and you
+probably has set it already.it
+
+2. If you aren't using it, finding yourself in their UI for the first time
+is going to be super confusing, in fact "How to exit vim" is a common
+Stack Overflow question. Having to google how to set an EDITOR variable is a
+less scary alternative.
+
+"""
 COMMON_EDITORS = [
     'subl',
     'vscode',
     'atom',
 ]
 
-THE_GREY_ONES = [
-    'vim',
-    'emacs',
-]
-
 MACOS_EDITORS = [
     # Only in MacOS, the "shell commands" are not installed by default
     '/Applications/Sublime Text.app/Contents/SharedSupport/bin/subl',
     '/Applications/Visual Studio Code.app/Contents/Resources/app/bin/code',
     '/Applications/Atom.app/Contents/Resources/app/atom.sh',
     '/Applications/TextMate.app/Contents/Resources/mate',
     '/Applications/Brackets.app/Contents/Resources/brackets.sh',
-] + COMMON_EDITORS + THE_GREY_ONES + [
+] + COMMON_EDITORS + [
     '/Applications/TextEdit.app/Contents/MacOS/TextEdit',
 ]
 
@@ -46,9 +51,9 @@
     'geany',
     'gedit',
     'nano',
-] + THE_GREY_ONES
+]
 
-WINDOWS_EDITORS = COMMON_EDITORS + THE_GREY_ONES + [
+WINDOWS_EDITORS = COMMON_EDITORS + [
     'notepad++.exe',
     'notepad.exe',
 ]
@@ -67,7 +72,8 @@ def get_possible_editors():
         if sys_platform.startswith(platform):
             return EDITORS[platform]
 
-    return COMMON_EDITORS + THE_GREY_ONES
+    return COMMON_EDITORS
+
 
 def split_editor_cmd(cmd):
     r"""Split by spaces unless escaped.
