+
+
+
+
+
We strive to eliminate as much boilerplate as possible by offering out-of-the-box features such as sorting, filtering and pagination.
++ The ultimate goal of this library is to eliminate as much boilerplate as possible by offering out-of-the-box features, such as sorting, filtering, pagination, sparse fieldset selection, and side-loading related resources. +
Order resources on one or multiple attributes using the sort
query string parameter
Order resources on multiple attributes using the sort
query string parameter
-#nullable enable
+#nullable enable
public class Article : Identifiable<long>
{
@@ -213,7 +222,7 @@ Resource
Request
- GET /articles?filter=contains(summary,'web')&sort=-lastModifiedAt&fields[articles]=title,summary&include=author HTTP/1.1
+ GET /articles?filter=contains(summary,'web')&sort=-lastModifiedAt&fields[articles]=title,summary&include=author HTTP/1.1
-{
+{
"meta": {
"totalResources": 1
},
"links": {
- "self": "/articles?filter=contains(summary,'web')&sort=-lastModifiedAt&fields%5Barticles%5D=title,summary&include=author",
- "first": "/articles?filter=contains(summary,'web')&sort=-lastModifiedAt&fields%5Barticles%5D=title,summary&include=author",
- "last": "/articles?filter=contains(summary,'web')&sort=-lastModifiedAt&fields%5Barticles%5D=title,summary&include=author"
+ "self": "/articles?filter=contains(summary,'web')&sort=-lastModifiedAt&fields%5Barticles%5D=title,summary&include=author",
+ "first": "/articles?filter=contains(summary,'web')&sort=-lastModifiedAt&fields%5Barticles%5D=title,summary&include=author",
+ "last": "/articles?filter=contains(summary,'web')&sort=-lastModifiedAt&fields%5Barticles%5D=title,summary&include=author"
},
"data": [
{
@@ -294,14 +303,14 @@ Sponsors
-
+
-
+
-
+
diff --git a/docs/internals/toc.md b/docs/internals/toc.md
deleted file mode 100644
index 0533dc5272..0000000000
--- a/docs/internals/toc.md
+++ /dev/null
@@ -1 +0,0 @@
-# [Queries](queries.md)
diff --git a/docs/internals/toc.yml b/docs/internals/toc.yml
new file mode 100644
index 0000000000..adb35afc58
--- /dev/null
+++ b/docs/internals/toc.yml
@@ -0,0 +1,2 @@
+- name: Queries
+ href: queries.md
diff --git a/docs/request-examples/README.md b/docs/request-examples/README.md
index eb95ea4656..5a2911f5cb 100644
--- a/docs/request-examples/README.md
+++ b/docs/request-examples/README.md
@@ -2,18 +2,20 @@
To update these requests:
-1. Add a PowerShell (.ps1) script prefixed by a number that is used to determine the order the scripts are executed. The script should execute a request and output the response. Example:
-```
-curl -s http://localhost:14141/api/books
-```
+1. Add a PowerShell (`.ps1`) script prefixed by a number that is used to determine the order the scripts are executed.
+ The script should execute a request and output the response. For example:
+ ```
+ curl -s http://localhost:14141/api/books
+ ```
-2. Add the example to `index.md`. Example:
-```
-### Get with relationship
+2. Add the example to `index.md`. For example:
+ ```
+ ### Get with relationship
-[!code-ps[REQUEST](003_GET_Books-including-Author.ps1)]
-[!code-json[RESPONSE](003_GET_Books-including-Author_Response.json)]
-```
+ [!code-ps[REQUEST](003_GET_Books-including-Author.ps1)]
+ [!code-json[RESPONSE](003_GET_Books-including-Author_Response.json)]
+ ```
-3. Run `pwsh ../generate-examples.ps1`
-4. Verify the results by running `pwsh ../build-dev.ps1`
+3. Run `pwsh ../generate-examples.ps1` to execute the request.
+
+4. Run `pwsh ../build-dev.ps1` to view the output on the website.
diff --git a/docs/request-examples/index.md b/docs/request-examples/index.md
index 614aa4814f..89c7043450 100644
--- a/docs/request-examples/index.md
+++ b/docs/request-examples/index.md
@@ -1,17 +1,28 @@
----
-_disableToc: true
----
+# Example projects
-# Example requests
+Runnable example projects can be found [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/src/Examples):
+
+- GettingStarted: A simple project with minimal configuration to develop a runnable project in minutes.
+- JsonApiDotNetCoreExample: Showcases commonly-used features, such as resource definitions, atomic operations, and OpenAPI.
+ - OpenApiNSwagClientExample: Uses [NSwag](https://github.com/RicoSuter/NSwag) to generate a typed OpenAPI client.
+ - OpenApiKiotaClientExample: Uses [Kiota](https://learn.microsoft.com/en-us/openapi/kiota/) to generate a typed OpenAPI client.
+- MultiDbContextExample: Shows how to use multiple `DbContext` classes, for connecting to multiple databases.
+- DatabasePerTenantExample: Uses a different database per tenant. See [here](~/usage/advanced/multi-tenancy.md) for using multiple tenants in the same database.
+- NoEntityFrameworkExample: Uses a read-only in-memory repository, instead of a real database.
+- DapperExample: Uses [Dapper](https://github.com/DapperLib/Dapper) to execute SQL queries.
+- ReportsExample: Uses a resource service that returns aggregated data.
-These requests have been generated against the "GettingStarted" application and are updated on every deployment.
+> [!NOTE]
+> The example projects only cover highly-requested features. More advanced use cases can be found [here](~/usage/advanced/index.md).
+
+# Example requests
-All of these requests have been created using out-of-the-box features.
+The following requests are automatically generated against the "GettingStarted" application on every deployment.
> [!NOTE]
> curl requires "[" and "]" in URLs to be escaped.
-# Reading data
+## Reading data
### Get all
@@ -48,7 +59,7 @@ All of these requests have been created using out-of-the-box features.
[!code-ps[REQUEST](007_GET_Books-paginated.ps1)]
[!code-json[RESPONSE](007_GET_Books-paginated_Response.json)]
-# Writing data
+## Writing data
### Create resource
diff --git a/docs/request-examples/toc.md b/docs/request-examples/toc.md
deleted file mode 100644
index e69de29bb2..0000000000
diff --git a/docs/template/public/main.css b/docs/template/public/main.css
new file mode 100644
index 0000000000..a20926d93f
--- /dev/null
+++ b/docs/template/public/main.css
@@ -0,0 +1,6 @@
+/* From https://github.com/dotnet/docfx/discussions/9644 */
+
+body {
+ --bs-link-color-rgb: 66, 184, 131 !important;
+ --bs-link-hover-color-rgb: 64, 180, 128 !important;
+}
diff --git a/docs/template/public/main.js b/docs/template/public/main.js
new file mode 100644
index 0000000000..be4428bed6
--- /dev/null
+++ b/docs/template/public/main.js
@@ -0,0 +1,11 @@
+// From https://github.com/dotnet/docfx/discussions/9644
+
+export default {
+ iconLinks: [
+ {
+ icon: 'github',
+ href: 'https://github.com/json-api-dotnet/JsonApiDotNetCore',
+ title: 'GitHub'
+ }
+ ]
+}
diff --git a/docs/toc.yml b/docs/toc.yml
index e9165998e5..29f786ca4a 100644
--- a/docs/toc.yml
+++ b/docs/toc.yml
@@ -1,17 +1,12 @@
- name: Getting Started
- href: getting-started/
-
+ href: getting-started/index.md
- name: Usage
href: usage/
-
- name: API
href: api/
- homepage: api/index.md
-
+ topicHref: api/index.md
- name: Examples
- href: request-examples/
- homepage: request-examples/index.md
-
+ href: request-examples/index.md
- name: Internals
href: internals/
- homepage: internals/index.md
+ topicHref: internals/index.md
diff --git a/docs/usage/advanced/alternate-routes.md b/docs/usage/advanced/alternate-routes.md
new file mode 100644
index 0000000000..a860a61fa7
--- /dev/null
+++ b/docs/usage/advanced/alternate-routes.md
@@ -0,0 +1,8 @@
+# Alternate Routes
+
+The code [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/test/JsonApiDotNetCoreTests/IntegrationTests/CustomRoutes) shows how the default JSON:API routes can be changed.
+
+The classes `TownsController` and `CiviliansController`:
+- Are decorated with `[DisableRoutingConvention]` to turn off the default JSON:API routing convention.
+- Are decorated with the ASP.NET `[Route]` attribute to specify at which route the controller is exposed.
+- Are augmented with non-standard JSON:API action methods, whose `[HttpGet]` attributes specify a custom route.
diff --git a/docs/usage/advanced/archiving.md b/docs/usage/advanced/archiving.md
new file mode 100644
index 0000000000..3892877a52
--- /dev/null
+++ b/docs/usage/advanced/archiving.md
@@ -0,0 +1,14 @@
+# Archiving
+
+The code [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/test/JsonApiDotNetCoreTests/IntegrationTests/Archiving) demonstrates how to implement archived resources.
+
+> [!TIP]
+> This scenario is comparable with [Soft Deletion](~/usage/advanced/soft-deletion.md).
+> The difference is that archived resources are accessible to JSON:API clients, whereas soft-deleted resources _never_ are.
+
+- Archived resources can be fetched by ID, but don't show up in searches by default.
+- Resources can only be created in a non-archived state and then archived/unarchived using a PATCH resource request.
+- The archive date is stored in the database, but cannot be modified through JSON:API.
+- To delete a resource, it must be archived first.
+
+This feature is implemented using a custom resource definition. It intercepts write operations and recursively scans incoming filters.
diff --git a/docs/usage/advanced/auth-scopes.md b/docs/usage/advanced/auth-scopes.md
new file mode 100644
index 0000000000..e37cb1b6ae
--- /dev/null
+++ b/docs/usage/advanced/auth-scopes.md
@@ -0,0 +1,10 @@
+# Authorization Scopes
+
+The code [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/test/JsonApiDotNetCoreTests/IntegrationTests/Authorization/Scopes) shows how scope-based authorization can be used.
+
+- For simplicity, this code assumes the granted scopes are passed in a plain-text HTTP header. A more realistic use case would be to obtain the scopes from an OAuth token.
+- The HTTP header lists which resource types can be read from and/or written to.
+- An [ASP.NET Action Filter](https://learn.microsoft.com/aspnet/core/mvc/controllers/filters) validates incoming JSON:API resource/relationship requests.
+ - The incoming request path is validated against the permitted read/write permissions per resource type.
+ - The resource types used in query string parameters are validated against the permitted set of resource types.
+- A customized operations controller verifies that all incoming operations are allowed.
diff --git a/docs/usage/advanced/blobs.md b/docs/usage/advanced/blobs.md
new file mode 100644
index 0000000000..d3d4525c66
--- /dev/null
+++ b/docs/usage/advanced/blobs.md
@@ -0,0 +1,9 @@
+# BLOBs
+
+The code [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/test/JsonApiDotNetCoreTests/IntegrationTests/Blobs) shows how Binary Large Objects (BLOBs) can be used.
+
+- The `ImageContainer` resource type contains nullable and non-nullable `byte[]` properties.
+- BLOBs are queried and persisted using Entity Framework Core.
+- The BLOB data is returned as a base-64 encoded string in the JSON response.
+
+Blobs are handled automatically; there's no need for custom code.
diff --git a/docs/usage/advanced/composite-keys.md b/docs/usage/advanced/composite-keys.md
new file mode 100644
index 0000000000..768a22a190
--- /dev/null
+++ b/docs/usage/advanced/composite-keys.md
@@ -0,0 +1,8 @@
+# Composite Keys
+
+The code [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/test/JsonApiDotNetCoreTests/IntegrationTests/CompositeKeys) shows how database tables with composite keys can be used.
+
+- The `DbContext` configures `Car` to have a composite primary key consisting of the `RegionId` and `LicensePlate` columns.
+- The `Car.Id` property is overridden to provide a unique ID for JSON:API. It is marked with `[NotMapped]`, meaning no `Id` column exists in the database table.
+- The `Engine` and `Dealership` resource types define relationships that generate composite foreign keys in the database.
+- A custom resource repository is used to rewrite IDs from filter/sort query string parameters into `RegionId` and `LicensePlate` lookups.
diff --git a/docs/usage/advanced/content-negotiation.md b/docs/usage/advanced/content-negotiation.md
new file mode 100644
index 0000000000..980b2e0b65
--- /dev/null
+++ b/docs/usage/advanced/content-negotiation.md
@@ -0,0 +1,15 @@
+# Content Negotiation
+
+The code [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/test/JsonApiDotNetCoreTests/IntegrationTests/ContentNegotiation) demonstrates how content negotiation in JSON:API works.
+
+Additionally, the code [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/test/JsonApiDotNetCoreTests/IntegrationTests/ContentNegotiation/CustomExtensions) provides
+a custom "server-time" JSON:API extension that returns the local or UTC server time in top-level `meta`.
+- This extension can be used in the `Accept` and `Content-Type` HTTP headers.
+- In a request body, the optional `useLocalTime` property in top-level `meta` indicates whether to return the local or UTC time.
+
+This feature is implemented using the following extensibility points:
+
+- At startup, the "server-time" extension is added in `JsonApiOptions`, which permits clients to use it.
+- A custom `JsonApiContentNegotiator` chooses which extensions are active for an incoming request, taking the "server-time" extension into account.
+- A custom `IDocumentAdapter` captures the incoming request body, providing access to the `useLocalTime` property in `meta`.
+- A custom `IResponseMeta` adds the server time to the response, depending on the activated extensions in `IJsonApiRequest` and the captured request body.
diff --git a/docs/usage/advanced/eager-loading.md b/docs/usage/advanced/eager-loading.md
new file mode 100644
index 0000000000..72e401c4f0
--- /dev/null
+++ b/docs/usage/advanced/eager-loading.md
@@ -0,0 +1,12 @@
+# Eager Loading Related Resources
+
+The code [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/test/JsonApiDotNetCoreTests/IntegrationTests/EagerLoading) uses the `[EagerLoad]` attribute to facilitate calculated properties that depend on related resources.
+The related resources are fetched from the database, but not returned to the client unless explicitly requested using the `include` query string parameter.
+
+- The `Street` resource type uses `EagerLoad` on its `Buildings` to-many relationship because its `DoorTotalCount` calculated property depends on it.
+- The `Building` resource type uses `EagerLoad` on its `Windows` to-many relationship because its `WindowCount` calculated property depends on it.
+- The `Building` resource type uses `EagerLoad` on its `PrimaryDoor` to-one required relationship because its `PrimaryDoorColor` calculated property depends on it.
+ - Because this is a required relationship, special handling occurs in `Building`, `BuildingRepository`, and `BuildingDefinition`.
+- The `Building` resource type uses `EagerLoad` on its `SecondaryDoor` to-one optional relationship because its `SecondaryDoorColor` calculated property depends on it.
+
+As can be seen from the usages above, a chain of `EagerLoad` attributes can result in fetching a chain of related resources from the database.
diff --git a/docs/usage/advanced/error-handling.md b/docs/usage/advanced/error-handling.md
new file mode 100644
index 0000000000..c53b3f2669
--- /dev/null
+++ b/docs/usage/advanced/error-handling.md
@@ -0,0 +1,13 @@
+# Error Handling
+
+The code [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/test/JsonApiDotNetCoreTests/IntegrationTests/ExceptionHandling) shows how to customize error handling.
+
+A user-defined exception, `ConsumerArticleIsNoLongerAvailableException`, is thrown from a resource service to demonstrate handling it.
+Note that this exception can be thrown from anywhere during request execution; a resource service is just used here for simplicity.
+
+To handle the user-defined exception, `AlternateExceptionHandler` inherits from `ExceptionHandler` to:
+- Customize the JSON:API error response by adding a `meta` entry when `ConsumerArticleIsNoLongerAvailableException` is thrown.
+- Indicate that `ConsumerArticleIsNoLongerAvailableException` must be logged at the Warning level.
+
+Additionally, the `ThrowingArticle.Status` property throws an `InvalidOperationException`.
+This triggers the default error handling because `AlternateExceptionHandler` delegates to its base class.
diff --git a/docs/usage/advanced/hosting-iis.md b/docs/usage/advanced/hosting-iis.md
new file mode 100644
index 0000000000..f452adaeec
--- /dev/null
+++ b/docs/usage/advanced/hosting-iis.md
@@ -0,0 +1,7 @@
+# Hosting in Internet Information Services (IIS)
+
+The code [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/test/JsonApiDotNetCoreTests/IntegrationTests/HostingInIIS) calls [UsePathBase](https://learn.microsoft.com/dotnet/api/microsoft.aspnetcore.builder.usepathbaseextensions.usepathbase) to simulate hosting in IIS.
+For details on how `UsePathBase` works, see [Understanding PathBase in ASP.NET Core](https://andrewlock.net/understanding-pathbase-in-aspnetcore/).
+
+- At startup, the line `app.UsePathBase("/iis-application-virtual-directory")` configures ASP.NET to use the base path.
+- `PaintingsController` uses a custom route to demonstrate that both features can be used together.
diff --git a/docs/usage/advanced/id-obfuscation.md b/docs/usage/advanced/id-obfuscation.md
new file mode 100644
index 0000000000..4012238c29
--- /dev/null
+++ b/docs/usage/advanced/id-obfuscation.md
@@ -0,0 +1,16 @@
+# ID Obfuscation
+
+The code [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/test/JsonApiDotNetCoreTests/IntegrationTests/IdObfuscation) shows how to use obfuscated IDs.
+They are typically used to prevent clients from guessing primary key values.
+
+All IDs sent by clients are transparently de-obfuscated into internal numeric values before accessing the database.
+Numeric IDs returned from the database are obfuscated before they are sent to the client.
+
+> [!NOTE]
+> An alternate solution is to use GUIDs instead of numeric primary keys in the database.
+
+ID obfuscation is achieved using the following extensibility points:
+
+- For simplicity, `HexadecimalCodec` is used to obfuscate numeric IDs to a hexadecimal format. A more realistic use case would be to use a symmetric crypto algorithm.
+- `ObfuscatedIdentifiable` acts as the base class for resource types, handling the obfuscation and de-obfuscation of IDs.
+- `ObfuscatedIdentifiableController` acts as the base class for controllers. It inherits from `BaseJsonApiController`, changing the `id` parameter in action methods to type `string`.
diff --git a/docs/usage/advanced/index.md b/docs/usage/advanced/index.md
new file mode 100644
index 0000000000..6bf9841dbe
--- /dev/null
+++ b/docs/usage/advanced/index.md
@@ -0,0 +1,19 @@
+# Advanced JSON:API features
+
+This topic goes beyond the basics of what's possible with JsonApiDotNetCore.
+
+Advanced use cases are provided in the form of integration tests [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/test/JsonApiDotNetCoreTests/IntegrationTests).
+This ensures they don't break during development of the framework.
+
+Each directory typically contains:
+
+- A set of resource types.
+- A `DbContext` class to register the resource types.
+- Fakers to generate deterministic test data.
+- Test classes that assert the feature works as expected.
+ - Entities are inserted into a randomly named PostgreSQL database.
+ - An HTTP request is sent.
+ - The returned response is asserted on.
+ - If applicable, the changes are fetched from the database and asserted on.
+
+To run/debug the integration tests, follow the steps in [README.md](https://github.com/json-api-dotnet/JsonApiDotNetCore#build-from-source).
diff --git a/docs/usage/advanced/links.md b/docs/usage/advanced/links.md
new file mode 100644
index 0000000000..d26be87563
--- /dev/null
+++ b/docs/usage/advanced/links.md
@@ -0,0 +1,19 @@
+# Links
+
+The code [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/test/JsonApiDotNetCoreTests/IntegrationTests/Links) shows various ways to configure which links are returned, and how they appear in responses.
+
+> [!TIP]
+> By default, absolute links are returned. To return relative links, set [JsonApiOptions.UseRelativeLinks](~/usage/options.md#relative-links) at startup.
+
+> [!TIP]
+> To add a global prefix to all routes, set `JsonApiOptions.Namespace` at startup.
+
+Which links to render can be configured globally in options, then overridden per resource type, and then overridden per relationship.
+
+- The `PhotoLocation` resource type turns off `TopLevelLinks` and `ResourceLinks`, and sets `RelationshipLinks` to `Related`.
+- The `PhotoLocation.Album` relationship turns off all links for this relationship.
+
+The various tests set `JsonApiOptions.Namespace` and `JsonApiOptions.UseRelativeLinks` to verify that the proper links are rendered.
+This can't be set in the tests directly for technical reasons, so they use different `Startup` classes to control this.
+
+Link rendering is fully controlled using attributes on your models. No further code is needed.
diff --git a/docs/usage/advanced/microservices.md b/docs/usage/advanced/microservices.md
new file mode 100644
index 0000000000..88e9cb08b9
--- /dev/null
+++ b/docs/usage/advanced/microservices.md
@@ -0,0 +1,22 @@
+# Microservices
+
+The code [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/test/JsonApiDotNetCoreTests/IntegrationTests/Microservices) shows patterns commonly used in microservices architecture:
+
+- [Fire-and-forget](https://microservices.io/patterns/communication-style/messaging.html): Outgoing messages are sent to an external queue, without waiting for their processing to start. While this is the simplest solution, it is not very reliable when errors occur.
+- [Transactional Outbox Pattern](https://microservices.io/patterns/data/transactional-outbox.html): Outgoing messages are saved to a queue table within the same database transaction. A background job (omitted in this example) polls the queue table and sends the messages to an external queue.
+
+> [!TIP]
+> Potential external queue systems you could use are [RabbitMQ](https://www.rabbitmq.com/), [MassTransit](https://masstransit.io/),
+> [Azure Service Bus](https://learn.microsoft.com/en-us/azure/service-bus-messaging/service-bus-messaging-overview) and [Apache Kafka](https://kafka.apache.org/). However, this is beyond the scope of this topic.
+
+The `Messages` directory lists the functional messages that are created from incoming JSON:API requests, which are typically processed by an external system that handles messages from the queue.
+Each message has a unique ID and type, and is versioned to support gradual deployments.
+Example payloads of messages are: user created, user login name changed, user moved to group, group created, group renamed, etc.
+
+The abstract types `MessagingGroupDefinition` and `MessagingUserDefinition` are resource definitions that contain code shared by both patterns. They inspect the incoming request and produce one or more functional messages from it.
+The pattern-specific derived types inject their `DbContext`, which is used to query for additional information when determining what is being changed.
+
+> [!NOTE]
+> Because networks are inherently unreliable, systems that consume messages from an external queue should be [idempotent](https://microservices.io/patterns/communication-style/idempotent-consumer.html).
+> Several years ago, a [prototype](https://github.com/json-api-dotnet/JsonApiDotNetCore/pull/1132) was built to make JSON:API idempotent, but it was never finished due to a lack of community interest.
+> Please [open an issue](https://github.com/json-api-dotnet/JsonApiDotNetCore/issues/new?labels=enhancement) if idempotency matters to you.
diff --git a/docs/usage/advanced/model-state.md b/docs/usage/advanced/model-state.md
new file mode 100644
index 0000000000..0117cd72e3
--- /dev/null
+++ b/docs/usage/advanced/model-state.md
@@ -0,0 +1,14 @@
+# ASP.NET Model Validation
+
+The code [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/test/JsonApiDotNetCoreTests/IntegrationTests/InputValidation/ModelState) shows how to use [ASP.NET Model Validation](https://learn.microsoft.com/aspnet/web-api/overview/formats-and-model-binding/model-validation-in-aspnet-web-api) attributes.
+
+> [!TIP]
+> See [Atomic Operations](~/usage/advanced/operations.md) for how to implement a custom model validator.
+
+The resource types are decorated with Model Validation attributes, such as `[Required]`, `[RegularExpression]`, `[MinLength]`, and `[Range]`.
+
+Only the fields that appear in a request body (partial POST/PATCH) are validated.
+When validation fails, the source pointer in the response indicates which attribute(s) are invalid.
+
+Model Validation is enabled by default, but can be [turned off in options](~/usage/options.md#modelstate-validation).
+Aside from adding validation attributes to your resource properties, no further code is needed.
diff --git a/docs/usage/advanced/multi-tenancy.md b/docs/usage/advanced/multi-tenancy.md
new file mode 100644
index 0000000000..d6e5b73f62
--- /dev/null
+++ b/docs/usage/advanced/multi-tenancy.md
@@ -0,0 +1,21 @@
+# Multi-tenancy
+
+The code [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/test/JsonApiDotNetCoreTests/IntegrationTests/MultiTenancy) shows how to handle multiple tenants in a single database.
+
+> [!TIP]
+> To use a different database per tenant, see [this](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/src/Examples/DatabasePerTenantExample) example instead.
+> Its `DbContext` dynamically sets the connection string per request. This requires the database structure to be identical for all tenants.
+
+The essence of implementing multi-tenancy within a single database is instructing Entity Framework Core to add implicit filters when entities are queried.
+See the usage of `HasQueryFilter` in the `DbContext` class. It injects an `ITenantProvider` to determine the active tenant for the current HTTP request.
+
+> [!NOTE]
+> For simplicity, this example uses a route parameter to indicate the active tenant.
+> Provide your own `ITenantProvider` to determine the tenant from somewhere else, such as the incoming OAuth token.
+
+The generic `MultiTenantResourceService` transparently sets the tenant ID when creating a new resource.
+Furthermore, it performs extra queries to ensure relationship changes apply to the current tenant, and to produce better error messages.
+
+While `MultiTenantResourceService` is used for both resource types, _only_ the `WebShop` resource type implements `IHasTenant`.
+The related resource type `WebProduct` does not. Because the products table has a foreign key to the (tenant-specific) shop it belongs to, it doesn't need a `TenantId` column.
+When a JSON:API request for web products executes, the `HasQueryFilter` in the `DbContext` ensures that only products belonging to the tenant-specific shop are returned.
diff --git a/docs/usage/advanced/operations.md b/docs/usage/advanced/operations.md
new file mode 100644
index 0000000000..aec2b9fe4d
--- /dev/null
+++ b/docs/usage/advanced/operations.md
@@ -0,0 +1,15 @@
+# Atomic Operations
+
+The code [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations) covers usage of the [Atomic Operations](https://jsonapi.org/ext/atomic/) extension, which enables sending multiple changes in a single request.
+
+- Operations for creating, updating, and deleting resources and relationships are shown.
+- If one of the operations fails, the transaction is rolled back.
+- Local IDs are used to reference resources created in a preceding operation within the same request.
+- A custom controller restricts which operations are allowed, per resource type.
+- The maximum number of operations per request can be configured at startup.
+- For efficiency, operations are validated upfront (before accessing the database). If validation fails, the list of all errors is returned.
+ - Takes [ASP.NET Model Validation](https://learn.microsoft.com/aspnet/web-api/overview/formats-and-model-binding/model-validation-in-aspnet-web-api) attributes into account.
+ - See `DateMustBeInThePastAttribute` for how to implement a custom model validator.
+- Various interactions with resource definitions are shown.
+
+The Atomic Operations extension is enabled after an operations controller is added to the project. No further code is needed.
diff --git a/docs/usage/advanced/query-string-functions.md b/docs/usage/advanced/query-string-functions.md
new file mode 100644
index 0000000000..214228d654
--- /dev/null
+++ b/docs/usage/advanced/query-string-functions.md
@@ -0,0 +1,23 @@
+# Query String Functions
+
+The code [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/test/JsonApiDotNetCoreTests/IntegrationTests/QueryStrings/CustomFunctions) shows how to define custom functions that clients can use in JSON:API query string parameters.
+
+- IsUpperCase: Adds the `isUpperCase` function, which can be used in filters on `string` attributes.
+ - Returns whether the attribute value is uppercase.
+ - Example usage: `GET /blogs/1/posts?filter=and(isUpperCase(caption),not(isUpperCase(url)))`
+- StringLength: Adds the `length` function, which can be used in filters and sorts on `string` attributes.
+ - Returns the number of characters in the attribute value.
+ - Example filter usage: `GET /blogs?filter=greaterThan(length(title),'2')`
+ - Example sort usage: `GET /blogs/1/posts?sort=length(caption),-length(url)`
+- Sum: Adds the `sum` function, which can be used in filters.
+ - Returns the sum of the numeric attribute values in related resources.
+ - Example: `GET /blogPosts?filter=greaterThan(sum(comments,numStars),'4')`
+- TimeOffset: Adds the `timeOffset` function, which can be used in filters on `DateTime` attributes.
+ - Calculates the difference between the attribute value and the current date.
+ - A generic resource definition intercepts all filters, rewriting the usage of `timeOffset` into the equivalent filters on the target attribute.
+ - Example: `GET /reminders?filter=greaterOrEqual(remindsAt,timeOffset('+0:10:00'))`
+
+The basic pattern to implement a custom function is to:
+- Define a custom expression type, which inherits from one of the built-in expression types, such as `FilterExpression` or `FunctionExpression`.
+- Inherit from one of the built-in parsers, such as `FilterParser` or `SortParser`, to convert tokens to your custom expression type. Override the `ParseFilter` or `ParseFunction` method.
+- Inherit from one of the built-in query clause builders, such as `WhereClauseBuilder` or `OrderClauseBuilder`, to produce a LINQ expression for your custom expression type. Override the `DefaultVisit` method.
diff --git a/docs/usage/advanced/resource-injection.md b/docs/usage/advanced/resource-injection.md
new file mode 100644
index 0000000000..c4e82a40fd
--- /dev/null
+++ b/docs/usage/advanced/resource-injection.md
@@ -0,0 +1,11 @@
+# Injecting services in resource types
+
+The code [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/test/JsonApiDotNetCoreTests/IntegrationTests/ResourceConstructorInjection) shows how to inject services into resource types.
+
+Because Entity Framework Core doesn't support injecting arbitrary services into entity types (only a few special types), a workaround is used.
+Instead of injecting the desired services directly, the `DbContext` is injected, which injects the desired services and exposes them via properties.
+
+- The `PostOffice` and `GiftCertificate` resource types both inject the `DbContext` in their constructors.
+- The `DbContext` injects `TimeProvider` and exposes it through a property.
+- `GiftCertificate` obtains the `TimeProvider` via the `DbContext` property to calculate the value for its exposed `HasExpired` property, which depends on the current time.
+- `PostOffice` obtains the `TimeProvider` via the `DbContext` property to calculate the value for its exposed `IsOpen` property, which depends on the current time.
diff --git a/docs/usage/advanced/soft-deletion.md b/docs/usage/advanced/soft-deletion.md
new file mode 100644
index 0000000000..cebc18e91c
--- /dev/null
+++ b/docs/usage/advanced/soft-deletion.md
@@ -0,0 +1,15 @@
+# Soft Deletion
+
+The code [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/test/JsonApiDotNetCoreTests/IntegrationTests/SoftDeletion) demonstrates how to implement soft deletion of resources.
+
+> [!TIP]
+> This scenario is comparable with [Archiving](~/usage/advanced/archiving.md).
+> The difference is that soft-deleted resources are never accessible by JSON:API clients (despite still being stored in the database), whereas archived resources _are_ accessible.
+
+The essence of implementing soft deletion is instructing Entity Framework Core to add implicit filters when entities are queried.
+See the usage of `HasQueryFilter` in the `DbContext` class.
+
+The `ISoftDeletable` interface provides the `SoftDeletedAt` database column. The `Company` and `Department` resource types implement this interface to indicate they use soft deletion.
+
+The generic `SoftDeletionAwareResourceService` overrides the `DeleteAsync` method to soft-delete a resource instead of truly deleting it, if it implements `ISoftDeletable`.
+Furthermore, it performs extra queries to ensure relationship changes do not reference soft-deleted resources, and to produce better error messages.
diff --git a/docs/usage/advanced/state-machine.md b/docs/usage/advanced/state-machine.md
new file mode 100644
index 0000000000..371300995a
--- /dev/null
+++ b/docs/usage/advanced/state-machine.md
@@ -0,0 +1,11 @@
+# State Transitions in Resource Updates
+
+The code [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/test/JsonApiDotNetCoreTests/IntegrationTests/InputValidation/RequestBody) shows how to validate state transitions when updating a resource.
+
+This feature is implemented using a custom resource definition:
+
+- The `Workflow` resource type contains a `Stage` property of type `WorkflowStage`.
+- The `WorkflowStage` enumeration lists a workflow's possible states.
+- `WorkflowDefinition` contains a hard-coded stage transition table defining the valid transitions. For example, a workflow in stage `InProgress` can be changed to `OnHold` or `Canceled`, but not `Created`.
+ - The `OnPrepareWriteAsync` method is overridden to capture the stage currently stored in the database in the `_previousStage` private field.
+ - The `OnWritingAsync` method is overridden to verify whether the stage change is permitted. It consults the stage transition table to determine whether there's a path from `_previousStage` to the to-be-stored stage, producing an error if there isn't.
diff --git a/docs/usage/advanced/toc.yml b/docs/usage/advanced/toc.yml
new file mode 100644
index 0000000000..9d45cd04b3
--- /dev/null
+++ b/docs/usage/advanced/toc.yml
@@ -0,0 +1,38 @@
+- name: Authorization Scopes
+ href: auth-scopes.md
+- name: BLOBs
+ href: blobs.md
+- name: Microservices
+ href: microservices.md
+- name: Multi-tenancy
+ href: multi-tenancy.md
+- name: Atomic Operations
+ href: operations.md
+- name: Query String Functions
+ href: query-string-functions.md
+- name: Alternate Routes
+ href: alternate-routes.md
+- name: Content Negotiation
+ href: content-negotiation.md
+- name: Error Handling
+ href: error-handling.md
+- name: Hosting in IIS
+ href: hosting-iis.md
+- name: ID Obfuscation
+ href: id-obfuscation.md
+- name: Soft Deletion
+ href: soft-deletion.md
+- name: Archiving
+ href: archiving.md
+- name: ASP.NET Model Validation
+ href: model-state.md
+- name: State Transitions in Resource Updates
+ href: state-machine.md
+- name: Links
+ href: links.md
+- name: Composite Keys
+ href: composite-keys.md
+- name: Eager Loading
+ href: eager-loading.md
+- name: Injecting services in resource types
+ href: resource-injection.md
diff --git a/docs/usage/caching.md b/docs/usage/caching.md
index 28d6a6a36e..4243fd8be2 100644
--- a/docs/usage/caching.md
+++ b/docs/usage/caching.md
@@ -4,8 +4,8 @@ _since v4.2_
GET requests return an [ETag](https://developer.mozilla.org/docs/Web/HTTP/Headers/ETag) HTTP header, which can be used by the client in subsequent requests to save network bandwidth.
-Be aware that the returned ETag represents the entire response body (a 'resource' in HTTP terminology) for a request URL that includes the query string.
-This is unrelated to JSON:API resources. Therefore, we do not use ETags for optimistic concurrency.
+Be aware that the returned ETag represents the entire response body (a "resource" in HTTP terminology) for the full request URL, including the query string.
+A resource in HTTP is unrelated to a JSON:API resource. Therefore, we do not use ETags for optimistic concurrency.
Getting a list of resources returns an ETag:
@@ -26,7 +26,7 @@ ETag: "7FFF010786E2CE8FC901896E83870E00"
}
```
-The request is later resent using the received ETag. The server data has not changed at this point.
+The request is later resent using the same ETag received earlier. The server data has not changed at this point.
```http
GET /articles?sort=-lastModifiedAt HTTP/1.1
diff --git a/docs/usage/extensibility/toc.yml b/docs/usage/extensibility/toc.yml
new file mode 100644
index 0000000000..4a32581a60
--- /dev/null
+++ b/docs/usage/extensibility/toc.yml
@@ -0,0 +1,14 @@
+- name: Layer Overview
+ href: layer-overview.md
+- name: Resource Definitions
+ href: resource-definitions.md
+- name: Controllers
+ href: controllers.md
+- name: Resource Services
+ href: services.md
+- name: Resource Repositories
+ href: repositories.md
+- name: Middleware
+ href: middleware.md
+- name: Query Strings
+ href: query-strings.md
diff --git a/docs/usage/faq.md b/docs/usage/faq.md
new file mode 100644
index 0000000000..cbb32c4c00
--- /dev/null
+++ b/docs/usage/faq.md
@@ -0,0 +1,176 @@
+# Frequently Asked Questions
+
+#### Where can I find documentation and examples?
+The [documentation](~/usage/resources/index.md) covers basic features, as well as [advanced use cases](~/usage/advanced/index.md). Several runnable example projects are available [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/tree/master/src/Examples).
+
+#### Why don't you use the built-in OpenAPI support in ASP.NET Core?
+The structure of JSON:API request and response bodies differs significantly from the signature of JsonApiDotNetCore controllers.
+JsonApiDotNetCore provides OpenAPI support using [Swashbuckle](https://github.com/domaindrivendev/Swashbuckle.AspNetCore), a mature and feature-rich library that is highly extensible.
+The [OpenAPI support in ASP.NET Core](https://learn.microsoft.com/en-us/aspnet/core/fundamentals/openapi/overview) is still very young
+and doesn't provide the level of extensibility needed for JsonApiDotNetCore.
+
+#### What's available to implement a JSON:API client?
+To generate a typed client (specific to the resource types in your project), consider using our [OpenAPI](https://www.jsonapi.net/usage/openapi.html) NuGet package.
+
+If you need a generic client, it depends on the programming language used. There's an overwhelming list of client libraries at https://jsonapi.org/implementations/#client-libraries.
+
+The JSON object model inside JsonApiDotNetCore is tweaked for server-side handling (be tolerant at inputs and strict at outputs).
+While you technically *could* use our `JsonSerializer` converters from a .NET client application with some hacks, we don't recommend doing so.
+You'll need to build the resource graph on the client and rely on internal implementation details that are subject to change in future versions.
+
+#### How can I debug my API project?
+Due to auto-generated controllers, you may find it hard to determine where to put your breakpoints.
+In Visual Studio, controllers are accessible below **Solution Explorer > Project > Dependencies > Analyzers > JsonApiDotNetCore.SourceGenerators**.
+
+After turning on [Source Link](https://devblogs.microsoft.com/dotnet/improving-debug-time-productivity-with-source-link/#enabling-source-link) (which enables to download the JsonApiDotNetCore source code from GitHub), you can step into our source code and add breakpoints there too.
+
+Here are some key places in the execution pipeline to set a breakpoint:
+- `JsonApiRoutingConvention.Apply`: Controllers are registered here (executes once at startup)
+- `JsonApiMiddleware.InvokeAsync`: Content negotiation and `IJsonApiRequest` setup
+- `QueryStringReader.ReadAll`: Parses the query string parameters
+- `JsonApiReader.ReadAsync`: Parses the request body
+- `OperationsProcessor.ProcessAsync`: Entry point for handling atomic operations
+- `JsonApiResourceService`: Called by controllers, delegating to the repository layer
+- `EntityFrameworkCoreRepository.ApplyQueryLayer`: Builds the `IQueryable<>` that is offered to Entity Framework Core (which turns it into SQL)
+- `JsonApiWriter.WriteAsync`: Renders the response body
+- `ExceptionHandler.HandleException`: Interception point for thrown exceptions
+
+Aside from debugging, you can get more info by:
+- Including exception stack traces and incoming request bodies in error responses, as well as writing human-readable JSON:
+
+ ```c#
+ // Program.cs
+ builder.Services.AddJsonApi(options =>
+ {
+ options.IncludeExceptionStackTraceInErrors = true;
+ options.IncludeRequestBodyInErrors = true;
+ options.SerializerOptions.WriteIndented = true;
+ });
+ ```
+- Turning on trace logging, or/and logging of executed SQL statements, by adding the following to your `appsettings.Development.json`:
+
+ ```json
+ {
+ "Logging": {
+ "LogLevel": {
+ "Default": "Warning",
+ "Microsoft.EntityFrameworkCore.Database.Command": "Information",
+ "JsonApiDotNetCore": "Trace"
+ }
+ }
+ }
+ ```
+- Activate debug logging of LINQ expressions by adding a NuGet reference to [AgileObjects.ReadableExpressions](https://www.nuget.org/packages/AgileObjects.ReadableExpressions) in your project.
+
+#### What if my JSON:API resources do not exactly match the shape of my database tables?
+We often find users trying to write custom code to solve that. They usually get it wrong or incomplete, and it may not perform well.
+Or it simply fails because it cannot be translated to SQL.
+The good news is that there's an easier solution most of the time: configure Entity Framework Core mappings to do the work.
+
+For example, if your primary key column is named "CustomerId" instead of "Id":
+```c#
+builder.Entity().Property(x => x.Id).HasColumnName("CustomerId");
+```
+
+It certainly pays off to read up on these capabilities at [Creating and Configuring a Model](https://learn.microsoft.com/ef/core/modeling/).
+Another great resource is [Learn Entity Framework Core](https://www.learnentityframeworkcore.com/configuration).
+
+#### Can I share my resource models with .NET Framework projects?
+Yes, you can. Put your model classes in a separate project that only references [JsonApiDotNetCore.Annotations](https://www.nuget.org/packages/JsonApiDotNetCore.Annotations/).
+This package contains just the JSON:API attributes and targets NetStandard 1.0, which makes it flexible to consume.
+At startup, use [Auto-discovery](~/usage/resource-graph.md#auto-discovery) and point it to your shared project.
+
+#### What's the best place to put my custom business/validation logic?
+For basic input validation, use the attributes from [ASP.NET ModelState Validation](https://learn.microsoft.com/aspnet/core/mvc/models/validation?source=recommendations&view=aspnetcore-7.0#built-in-attributes) to get the best experience.
+JsonApiDotNetCore is aware of them and adjusts behavior accordingly. And it produces the best possible error responses.
+
+For non-trivial business rules that require custom code, the place to be is [Resource Definitions](~/usage/extensibility/resource-definitions.md).
+They provide a callback-based model where you can respond to everything going on.
+The great thing is that your callbacks are invoked for various endpoints.
+For example, the filter callback on Author executes at `GET /authors?filter=`, `GET /books/1/authors?filter=` and `GET /books?include=authors?filter[authors]=`.
+Likewise, the callbacks for changing relationships execute for POST/PATCH resource endpoints, as well as POST/PATCH/DELETE relationship endpoints.
+
+#### Can API users send multiple changes in a single request?
+Yes, just activate [atomic operations](~/usage/writing/bulk-batch-operations.md).
+It enables sending multiple changes in a batch request, which are executed in a database transaction.
+If something fails, all changes are rolled back. The error response indicates which operation failed.
+
+#### Is there any way to add `[Authorize(Roles = "...")]` to the generated controllers?
+Sure, this is possible. Simply add the attribute at the class level.
+See the docs on [Augmenting controllers](~/usage/extensibility/controllers.md#augmenting-controllers).
+
+#### How do I expose non-JSON:API endpoints?
+You can add your own controllers that do not derive from `(Base)JsonApiController` or `(Base)JsonApiOperationsController`.
+Whatever you do in those is completely ignored by JsonApiDotNetCore.
+This is useful if you want to add a few RPC-style endpoints or provide binary file uploads/downloads.
+
+A middle-ground approach is to add custom action methods to existing JSON:API controllers.
+While you can route them as you like, they must return JSON:API resources.
+And on error, a JSON:API error response is produced.
+This is useful if you want to stay in the JSON:API-compliant world, but need to expose something non-standard, for example: `GET /users/me`.
+
+#### How do I optimize for high scalability and prevent denial of service?
+Fortunately, JsonApiDotNetCore [scales pretty well](https://github.com/json-api-dotnet/PerformanceReports) under high load and/or large database tables.
+It never executes filtering, sorting, or pagination in-memory and tries pretty hard to produce the most efficient query possible.
+There are a few things to keep in mind, though:
+- Prevent users from executing slow queries by locking down [attribute capabilities](~/usage/resources/attributes.md#capabilities) and [relationship capabilities](~/usage/resources/relationships.md#capabilities).
+ Ensure the right database indexes are in place for what you enable.
+- Prevent users from fetching lots of data by tweaking [maximum page size/number](~/usage/options.md#pagination) and [maximum include depth](~/usage/options.md#maximum-include-depth).
+- Avoid long-running transactions by tweaking `MaximumOperationsPerRequest` in options.
+- Tell your users to utilize [E-Tags](~/usage/caching.md) to reduce network traffic.
+- Not included in JsonApiDotNetCore: Apply general practices such as rate limiting, load balancing, authentication/authorization, blocking very large URLs/request bodies, etc.
+
+#### Can I offload requests to a background process?
+Yes, that's possible. Override controller methods to return `HTTP 202 Accepted`, with a `Location` HTTP header where users can retrieve the result.
+Your controller method needs to store the request state (URL, query string, and request body) in a queue, which your background process can read from.
+From within your background process job handler, reconstruct the request state, execute the appropriate `JsonApiResourceService` method and store the result.
+There's a basic example available at https://github.com/json-api-dotnet/JsonApiDotNetCore/pull/1144, which processes a captured query string.
+
+#### What if I want to use something other than Entity Framework Core?
+This basically means you'll need to implement data access yourself. There are two approaches for interception: at the resource service level and at the repository level.
+Either way, you can use the built-in query string and request body parsing, as well as routing, error handling, and rendering of responses.
+
+Here are some injectable request-scoped types to be aware of:
+- `IJsonApiRequest`: This contains routing information, such as whether a primary, secondary, or relationship endpoint is being accessed.
+- `ITargetedFields`: Lists the attributes and relationships from an incoming POST/PATCH resource request. Any fields missing there should not be stored (partial updates).
+- `IEnumerable`: Provides access to the parsed query string parameters.
+- `IEvaluatedIncludeCache`: This tells the response serializer which related resources to render.
+- `ISparseFieldSetCache`: This tells the response serializer which fields to render in the `attributes` and `relationships` objects.
+
+You may also want to inject the singletons `IJsonApiOptions` (which contains settings such as default page size) and `IResourceGraph` (the JSON:API model of resources, attributes and relationships).
+
+So, back to the topic of where to intercept. It helps to familiarize yourself with the [execution pipeline](~/internals/queries.md).
+Replacing at the service level is the simplest. But it means you'll need to read the parsed query string parameters and invoke
+all resource definition callbacks yourself. And you won't get change detection (HTTP 203 Not Modified).
+Take a look at [JsonApiResourceService](https://github.com/json-api-dotnet/JsonApiDotNetCore/blob/master/src/JsonApiDotNetCore/Services/JsonApiResourceService.cs) to see what you're missing out on.
+
+You'll get a lot more out of the box if replacing at the repository level instead. You don't need to apply options or analyze query strings.
+And most resource definition callbacks are handled.
+That's because the built-in resource service translates all JSON:API query aspects of the request into a database-agnostic data structure called `QueryLayer`.
+Now the hard part for you becomes reading that data structure and producing data access calls from that.
+If your data store provides a LINQ provider, you can probably reuse [QueryableBuilder](https://github.com/json-api-dotnet/JsonApiDotNetCore/blob/master/src/JsonApiDotNetCore/Queries/QueryableBuilding/QueryableBuilder.cs),
+which drives the translation into [System.Linq.Expressions](https://learn.microsoft.com/dotnet/csharp/programming-guide/concepts/expression-trees/).
+Note however, that it also produces calls to `.Include("")`, which is an Entity Framework Core-specific extension method, so you'll need to
+[prevent that from happening](https://github.com/json-api-dotnet/JsonApiDotNetCore/blob/master/src/JsonApiDotNetCore/Queries/QueryableBuilding/QueryLayerIncludeConverter.cs).
+
+The example [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/blob/master/src/Examples/NoEntityFrameworkExample/Repositories/InMemoryResourceRepository.cs) compiles and executes
+the LINQ query against an in-memory list of resources.
+For [MongoDB](https://github.com/json-api-dotnet/JsonApiDotNetCore.MongoDb/blob/master/src/JsonApiDotNetCore.MongoDb/Repositories/MongoRepository.cs), we use the MongoDB LINQ provider.
+If there's no LINQ provider available, the example [here](https://github.com/json-api-dotnet/JsonApiDotNetCore/blob/master/src/Examples/DapperExample/Repositories/DapperRepository.cs) may be of help,
+which produces SQL and uses [Dapper](https://github.com/DapperLib/Dapper) for data access.
+
+> [!TIP]
+> [ReadableExpressions](https://github.com/agileobjects/ReadableExpressions) is very helpful in trying to debug LINQ expression trees!
+
+#### I love JsonApiDotNetCore! How can I support the team?
+The best way to express your gratitude is by starring our repository.
+This increases our leverage when asking for bug fixes in dependent projects, such as the .NET runtime and Entity Framework Core.
+You can also [sponsor](https://github.com/sponsors/json-api-dotnet) our project.
+Of course, a simple thank-you message in our [Gitter channel](https://gitter.im/json-api-dotnet-core/Lobby) is appreciated too!
+
+If you'd like to do more: try things out, ask questions, create GitHub bug reports or feature requests, or upvote existing issues that are important to you.
+We welcome PRs, but keep in mind: The worst thing in the world is opening a PR that gets rejected after you've put a lot of effort into it.
+So for any non-trivial changes, please open an issue first to discuss your approach and ensure it fits the product vision.
+
+#### Is there anything else I should be aware of?
+See [Common Pitfalls](~/usage/common-pitfalls.md).
diff --git a/docs/usage/meta.md b/docs/usage/meta.md
index a115e25740..674d39413b 100644
--- a/docs/usage/meta.md
+++ b/docs/usage/meta.md
@@ -60,7 +60,7 @@ public class PersonDefinition : JsonApiResourceDefinition
{
return new Dictionary
{
- ["notice"] = "Check our intranet at http://www.example.com/employees/" +
+ ["notice"] = "Check our intranet at https://www.example.com/employees/" +
$"{person.StringId} for personal details."
};
}
@@ -80,7 +80,7 @@ public class PersonDefinition : JsonApiResourceDefinition
...
},
"meta": {
- "notice": "Check our intranet at http://www.example.com/employees/1 for personal details."
+ "notice": "Check our intranet at https://www.example.com/employees/1 for personal details."
}
}
]
diff --git a/docs/usage/openapi-client.md b/docs/usage/openapi-client.md
index c0717d47ca..5dc40ce6fc 100644
--- a/docs/usage/openapi-client.md
+++ b/docs/usage/openapi-client.md
@@ -19,7 +19,7 @@ For C# clients, we provide an additional package that provides workarounds for b
To add it to your project, run the following command:
```
-dotnet add package JsonApiDotNetCore.OpenApi.Client.NSwag
+dotnet add package JsonApiDotNetCore.OpenApi.Client.NSwag --prerelease
```
# [Kiota](#tab/kiota)
@@ -28,7 +28,7 @@ For C# clients, we provide an additional package that provides workarounds for b
To add it to your project, run the following command:
```
-dotnet add package JsonApiDotNetCore.OpenApi.Client.Kiota
+dotnet add package JsonApiDotNetCore.OpenApi.Client.Kiota --prerelease
```
---
@@ -60,7 +60,7 @@ The following steps describe how to generate and use a JSON:API client in C#, co
1. Add our client package to your project:
```
- dotnet add package JsonApiDotNetCore.OpenApi.Client.NSwag
+ dotnet add package JsonApiDotNetCore.OpenApi.Client.NSwag --prerelease
```
1. Add code that calls one of your JSON:API endpoints.
@@ -340,7 +340,6 @@ demonstrates how to use them. It uses local IDs to:
| --- | --- | --- |
| Properties are always nullable | - | https://github.com/microsoft/kiota/issues/3911 |
| JSON:API query strings are inaccessible | Use `SetQueryStringHttpMessageHandler.CreateScope` from `JsonApiDotNetCore.OpenApi.Client.Kiota` package | https://github.com/microsoft/kiota/issues/3800 |
-| Properties set to `null` are sent twice | - | https://github.com/microsoft/kiota-dotnet/issues/535 |
| HTTP 304 (Not Modified) is not properly recognized | Catch `ApiException` and inspect the response status code | https://github.com/microsoft/kiota/issues/4190, https://github.com/microsoft/kiota-dotnet/issues/531 |
| Generator warns about unsupported formats | Use `JsonApiDotNetCore.OpenApi.Client.Kiota` package | https://github.com/microsoft/kiota/issues/4227 |
| `Stream` response for HEAD request | - | https://github.com/microsoft/kiota/issues/4245 |
diff --git a/docs/usage/openapi.md b/docs/usage/openapi.md
index e49f120a14..83f3ce8a3b 100644
--- a/docs/usage/openapi.md
+++ b/docs/usage/openapi.md
@@ -15,13 +15,9 @@ provides OpenAPI support for JSON:API by integrating with [Swashbuckle](https://
1. Install the `JsonApiDotNetCore.OpenApi.Swashbuckle` NuGet package:
```
- dotnet add package JsonApiDotNetCore.OpenApi.Swashbuckle
+ dotnet add package JsonApiDotNetCore.OpenApi.Swashbuckle --prerelease
```
- > [!NOTE]
- > Because this package is still experimental, it's not yet available on NuGet.
- > Use the steps [here](https://github.com/json-api-dotnet/JsonApiDotNetCore?tab=readme-ov-file#trying-out-the-latest-build) to install.
-
2. Add the JSON:API support to your `Program.cs` file.
```c#
diff --git a/docs/usage/reading/toc.yml b/docs/usage/reading/toc.yml
new file mode 100644
index 0000000000..aa1ecb6bca
--- /dev/null
+++ b/docs/usage/reading/toc.yml
@@ -0,0 +1,10 @@
+- name: Filtering
+ href: filtering.md
+- name: Sorting
+ href: sorting.md
+- name: Pagination
+ href: pagination.md
+- name: Sparse Fieldset Selection
+ href: sparse-fieldset-selection.md
+- name: Including Related Resources
+ href: including-relationships.md
diff --git a/docs/usage/resources/index.md b/docs/usage/resources/index.md
index f8e7d29156..09e0224c57 100644
--- a/docs/usage/resources/index.md
+++ b/docs/usage/resources/index.md
@@ -22,10 +22,9 @@ public class Person : Identifiable
}
```
-If your resource must inherit from another class,
-you can always implement the interface yourself.
-In this example, `ApplicationUser` inherits from `IdentityUser`
-which already contains an Id property of type string.
+If your resource must inherit from another class, you can always implement the interface yourself.
+In this example, `ApplicationUser` inherits from [`IdentityUser`](https://learn.microsoft.com/dotnet/api/microsoft.aspnetcore.identity.entityframeworkcore.identityuser),
+which already contains an `Id` property of type `string`.
```c#
public class ApplicationUser : IdentityUser, IIdentifiable
diff --git a/docs/usage/resources/inheritance.md b/docs/usage/resources/inheritance.md
index 47cf85ca67..56c046ef82 100644
--- a/docs/usage/resources/inheritance.md
+++ b/docs/usage/resources/inheritance.md
@@ -143,7 +143,7 @@ GET /humans HTTP/1.1
}
```
-### Spare fieldsets
+### Sparse fieldsets
If you only want to retrieve the fields from the base type, you can use [sparse fieldsets](~/usage/reading/sparse-fieldset-selection.md).
diff --git a/docs/usage/resources/toc.yml b/docs/usage/resources/toc.yml
new file mode 100644
index 0000000000..d4daf205d4
--- /dev/null
+++ b/docs/usage/resources/toc.yml
@@ -0,0 +1,8 @@
+- name: Attributes
+ href: attributes.md
+- name: Relationships
+ href: relationships.md
+- name: Inheritance
+ href: inheritance.md
+- name: Nullability
+ href: nullability.md
diff --git a/docs/usage/toc.md b/docs/usage/toc.md
deleted file mode 100644
index bdeb0e4958..0000000000
--- a/docs/usage/toc.md
+++ /dev/null
@@ -1,39 +0,0 @@
-# [Resources](resources/index.md)
-## [Attributes](resources/attributes.md)
-## [Relationships](resources/relationships.md)
-## [Inheritance](resources/inheritance.md)
-## [Nullability](resources/nullability.md)
-
-# Reading data
-## [Filtering](reading/filtering.md)
-## [Sorting](reading/sorting.md)
-## [Pagination](reading/pagination.md)
-## [Sparse Fieldset Selection](reading/sparse-fieldset-selection.md)
-## [Including Relationships](reading/including-relationships.md)
-
-# Writing data
-## [Creating](writing/creating.md)
-## [Updating](writing/updating.md)
-## [Deleting](writing/deleting.md)
-## [Bulk/batch](writing/bulk-batch-operations.md)
-
-# [Resource Graph](resource-graph.md)
-# [Options](options.md)
-# [Routing](routing.md)
-# [Errors](errors.md)
-# [Metadata](meta.md)
-# [Caching](caching.md)
-# [Common Pitfalls](common-pitfalls.md)
-
-# [OpenAPI](openapi.md)
-## [Documentation](openapi-documentation.md)
-## [Clients](openapi-client.md)
-
-# Extensibility
-## [Layer Overview](extensibility/layer-overview.md)
-## [Resource Definitions](extensibility/resource-definitions.md)
-## [Controllers](extensibility/controllers.md)
-## [Resource Services](extensibility/services.md)
-## [Resource Repositories](extensibility/repositories.md)
-## [Middleware](extensibility/middleware.md)
-## [Query Strings](extensibility/query-strings.md)
diff --git a/docs/usage/toc.yml b/docs/usage/toc.yml
new file mode 100644
index 0000000000..f5d60e9a1f
--- /dev/null
+++ b/docs/usage/toc.yml
@@ -0,0 +1,35 @@
+- name: FAQ
+ href: faq.md
+- name: Common Pitfalls
+ href: common-pitfalls.md
+- name: Resources
+ href: resources/toc.yml
+ topicHref: resources/index.md
+- name: Reading data
+ href: reading/toc.yml
+- name: Writing data
+ href: writing/toc.yml
+- name: Resource Graph
+ href: resource-graph.md
+- name: Options
+ href: options.md
+- name: Routing
+ href: routing.md
+- name: Errors
+ href: errors.md
+- name: Metadata
+ href: meta.md
+- name: Caching
+ href: caching.md
+- name: OpenAPI
+ href: openapi.md
+ items:
+ - name: Documentation
+ href: openapi-documentation.md
+ - name: Clients
+ href: openapi-client.md
+- name: Extensibility
+ href: extensibility/toc.yml
+- name: Advanced
+ href: advanced/toc.yml
+ topicHref: advanced/index.md
diff --git a/docs/usage/writing/toc.yml b/docs/usage/writing/toc.yml
new file mode 100644
index 0000000000..db836e548f
--- /dev/null
+++ b/docs/usage/writing/toc.yml
@@ -0,0 +1,8 @@
+- name: Creating
+ href: creating.md
+- name: Updating
+ href: updating.md
+- name: Deleting
+ href: deleting.md
+- name: Bulk/Batch
+ href: bulk-batch-operations.md
diff --git a/package-versions.props b/package-versions.props
index 8b528ff324..0f2c3f6e7e 100644
--- a/package-versions.props
+++ b/package-versions.props
@@ -4,14 +4,14 @@
4.1.0
0.4.1
2.14.1
- 8.0.0
+ 9.0.1
13.0.3
- 0.14.*
+ 0.15.*
1.0.*
35.6.*
- 4.13.*
+ 4.14.*
6.0.*
2.1.*
7.2.*
@@ -20,14 +20,15 @@
1.*
9.0.*
9.0.*
- 14.3.*
+ 14.4.*
13.0.*
- 2.1.*
- 8.*-*
+ 4.1.*
+ 2.4.*
+ 9.*-*
9.0.*
- 17.13.*
+ 17.14.*
2.9.*
- 2.8.*
+ 3.1.*
diff --git a/run-docker-postgres.ps1 b/run-docker-postgres.ps1
index 0cd42b3893..25b631a7ad 100644
--- a/run-docker-postgres.ps1
+++ b/run-docker-postgres.ps1
@@ -11,7 +11,7 @@ param(
docker container stop jsonapi-postgresql-db
docker container stop jsonapi-postgresql-management
-docker run --pull always --rm --detach --name jsonapi-postgresql-db -e POSTGRES_USER=postgres -e POSTGRES_PASSWORD=postgres -p 5432:5432 postgres:latest
+docker run --pull always --rm --detach --name jsonapi-postgresql-db -e POSTGRES_USER=postgres -e POSTGRES_PASSWORD=postgres -p 5432:5432 postgres:latest -N 500
if ($UI) {
docker run --pull always --rm --detach --name jsonapi-postgresql-management --link jsonapi-postgresql-db:db -e PGADMIN_DEFAULT_EMAIL=admin@admin.com -e PGADMIN_DEFAULT_PASSWORD=postgres -p 5050:80 dpage/pgadmin4:latest
diff --git a/src/Examples/DapperExample/Properties/launchSettings.json b/src/Examples/DapperExample/Properties/launchSettings.json
index 137620d860..0d86e8f61a 100644
--- a/src/Examples/DapperExample/Properties/launchSettings.json
+++ b/src/Examples/DapperExample/Properties/launchSettings.json
@@ -1,5 +1,5 @@
{
- "$schema": "http://json.schemastore.org/launchsettings.json",
+ "$schema": "https://json.schemastore.org/launchsettings.json",
"iisSettings": {
"windowsAuthentication": false,
"anonymousAuthentication": true,
diff --git a/src/Examples/DatabasePerTenantExample/Properties/launchSettings.json b/src/Examples/DatabasePerTenantExample/Properties/launchSettings.json
index 1ab75296f7..43ae84e51e 100644
--- a/src/Examples/DatabasePerTenantExample/Properties/launchSettings.json
+++ b/src/Examples/DatabasePerTenantExample/Properties/launchSettings.json
@@ -1,5 +1,5 @@
{
- "$schema": "http://json.schemastore.org/launchsettings.json",
+ "$schema": "https://json.schemastore.org/launchsettings.json",
"iisSettings": {
"windowsAuthentication": false,
"anonymousAuthentication": true,
diff --git a/src/Examples/GettingStarted/Properties/launchSettings.json b/src/Examples/GettingStarted/Properties/launchSettings.json
index d806502bcd..304c377082 100644
--- a/src/Examples/GettingStarted/Properties/launchSettings.json
+++ b/src/Examples/GettingStarted/Properties/launchSettings.json
@@ -1,5 +1,5 @@
{
- "$schema": "http://json.schemastore.org/launchsettings.json",
+ "$schema": "https://json.schemastore.org/launchsettings.json",
"iisSettings": {
"windowsAuthentication": false,
"anonymousAuthentication": true,
diff --git a/src/Examples/GettingStarted/README.md b/src/Examples/GettingStarted/README.md
index 8d8da60bc8..4d94ffd825 100644
--- a/src/Examples/GettingStarted/README.md
+++ b/src/Examples/GettingStarted/README.md
@@ -7,8 +7,7 @@
You can verify the project is running by checking this endpoint:
`localhost:14141/api/people`
-For further documentation and implementation of a JsonApiDotNetCore Application see the documentation or GitHub page:
+For further documentation and implementation of a JsonApiDotNetCore application, see the documentation or GitHub page:
Repository: https://github.com/json-api-dotnet/JsonApiDotNetCore
-
Documentation: https://www.jsonapi.net
diff --git a/src/Examples/JsonApiDotNetCoreExample/Program.cs b/src/Examples/JsonApiDotNetCoreExample/Program.cs
index d2677ea781..56448b271e 100644
--- a/src/Examples/JsonApiDotNetCoreExample/Program.cs
+++ b/src/Examples/JsonApiDotNetCoreExample/Program.cs
@@ -79,9 +79,7 @@ static void ConfigureServices(WebApplicationBuilder builder)
using (CodeTimingSessionManager.Current.Measure("AddOpenApiForJsonApi()"))
{
-#pragma warning disable JADNC_OA_001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
builder.Services.AddOpenApiForJsonApi(options => options.DocumentFilter());
-#pragma warning restore JADNC_OA_001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
}
}
diff --git a/src/Examples/JsonApiDotNetCoreExample/Properties/launchSettings.json b/src/Examples/JsonApiDotNetCoreExample/Properties/launchSettings.json
index 82b89e1843..7c4189f272 100644
--- a/src/Examples/JsonApiDotNetCoreExample/Properties/launchSettings.json
+++ b/src/Examples/JsonApiDotNetCoreExample/Properties/launchSettings.json
@@ -1,5 +1,5 @@
{
- "$schema": "http://json.schemastore.org/launchsettings.json",
+ "$schema": "https://json.schemastore.org/launchsettings.json",
"iisSettings": {
"windowsAuthentication": false,
"anonymousAuthentication": true,
diff --git a/src/Examples/MultiDbContextExample/Properties/launchSettings.json b/src/Examples/MultiDbContextExample/Properties/launchSettings.json
index 9d3467265f..2cb2d59cae 100644
--- a/src/Examples/MultiDbContextExample/Properties/launchSettings.json
+++ b/src/Examples/MultiDbContextExample/Properties/launchSettings.json
@@ -1,5 +1,5 @@
{
- "$schema": "http://json.schemastore.org/launchsettings.json",
+ "$schema": "https://json.schemastore.org/launchsettings.json",
"iisSettings": {
"windowsAuthentication": false,
"anonymousAuthentication": true,
diff --git a/src/Examples/NoEntityFrameworkExample/Properties/launchSettings.json b/src/Examples/NoEntityFrameworkExample/Properties/launchSettings.json
index d1e2e0ca67..e5d1b8837c 100644
--- a/src/Examples/NoEntityFrameworkExample/Properties/launchSettings.json
+++ b/src/Examples/NoEntityFrameworkExample/Properties/launchSettings.json
@@ -1,5 +1,5 @@
{
- "$schema": "http://json.schemastore.org/launchsettings.json",
+ "$schema": "https://json.schemastore.org/launchsettings.json",
"iisSettings": {
"windowsAuthentication": false,
"anonymousAuthentication": true,
diff --git a/src/Examples/OpenApiKiotaClientExample/Properties/launchSettings.json b/src/Examples/OpenApiKiotaClientExample/Properties/launchSettings.json
index afb5e5dac4..142f412e8a 100644
--- a/src/Examples/OpenApiKiotaClientExample/Properties/launchSettings.json
+++ b/src/Examples/OpenApiKiotaClientExample/Properties/launchSettings.json
@@ -1,5 +1,5 @@
{
- "$schema": "http://json.schemastore.org/launchsettings.json",
+ "$schema": "https://json.schemastore.org/launchsettings.json",
"profiles": {
"Kestrel": {
"commandName": "Project",
diff --git a/src/Examples/OpenApiNSwagClientExample/Properties/launchSettings.json b/src/Examples/OpenApiNSwagClientExample/Properties/launchSettings.json
index afb5e5dac4..142f412e8a 100644
--- a/src/Examples/OpenApiNSwagClientExample/Properties/launchSettings.json
+++ b/src/Examples/OpenApiNSwagClientExample/Properties/launchSettings.json
@@ -1,5 +1,5 @@
{
- "$schema": "http://json.schemastore.org/launchsettings.json",
+ "$schema": "https://json.schemastore.org/launchsettings.json",
"profiles": {
"Kestrel": {
"commandName": "Project",
diff --git a/src/Examples/ReportsExample/Properties/launchSettings.json b/src/Examples/ReportsExample/Properties/launchSettings.json
index 7add074ef2..83e6baea4c 100644
--- a/src/Examples/ReportsExample/Properties/launchSettings.json
+++ b/src/Examples/ReportsExample/Properties/launchSettings.json
@@ -1,5 +1,5 @@
{
- "$schema": "http://json.schemastore.org/launchsettings.json",
+ "$schema": "https://json.schemastore.org/launchsettings.json",
"iisSettings": {
"windowsAuthentication": false,
"anonymousAuthentication": true,
diff --git a/src/JsonApiDotNetCore.Annotations/CollectionConverter.cs b/src/JsonApiDotNetCore.Annotations/CollectionConverter.cs
index cbf834b630..683e34764b 100644
--- a/src/JsonApiDotNetCore.Annotations/CollectionConverter.cs
+++ b/src/JsonApiDotNetCore.Annotations/CollectionConverter.cs
@@ -104,17 +104,26 @@ public IReadOnlyCollection ExtractResources(object? value)
///
public Type? FindCollectionElementType(Type? type)
{
- if (type is { IsGenericType: true, GenericTypeArguments.Length: 1 })
+ if (type != null)
{
- if (type.IsOrImplementsInterface())
+ Type? enumerableClosedType = IsEnumerableClosedType(type) ? type : null;
+ enumerableClosedType ??= type.GetInterfaces().FirstOrDefault(IsEnumerableClosedType);
+
+ if (enumerableClosedType != null)
{
- return type.GenericTypeArguments[0];
+ return enumerableClosedType.GenericTypeArguments[0];
}
}
return null;
}
+ private static bool IsEnumerableClosedType(Type type)
+ {
+ bool isClosedType = type is { IsGenericType: true, ContainsGenericParameters: false };
+ return isClosedType && type.GetGenericTypeDefinition() == typeof(IEnumerable<>);
+ }
+
///
/// Indicates whether a instance can be assigned to the specified type, for example:
///
jsonapidotnetcore;jsonapi;json:api;dotnet;asp.net;rest;web-api
- Annotations for JsonApiDotNetCore, a framework for building JSON:API compliant REST APIs using ASP.NET and Entity Framework Core.
+ Annotations for JsonApiDotNetCore, which is a framework for building JSON:API compliant REST APIs using ASP.NET Core and Entity Framework Core.
json-api-dotnet
https://www.jsonapi.net/
MIT
diff --git a/src/JsonApiDotNetCore.OpenApi.Client.Kiota/Build/JsonApiDotNetCore.OpenApi.Client.Kiota.targets b/src/JsonApiDotNetCore.OpenApi.Client.Kiota/Build/JsonApiDotNetCore.OpenApi.Client.Kiota.targets
index 72b32aa7a5..44586a10ae 100644
--- a/src/JsonApiDotNetCore.OpenApi.Client.Kiota/Build/JsonApiDotNetCore.OpenApi.Client.Kiota.targets
+++ b/src/JsonApiDotNetCore.OpenApi.Client.Kiota/Build/JsonApiDotNetCore.OpenApi.Client.Kiota.targets
@@ -149,8 +149,8 @@
-
+
<_WildcardGroup Include="%2A%2A/%2A.cs">
%(KiotaReference._NonEmptyOutputPath)
diff --git a/src/JsonApiDotNetCore.OpenApi.Client.NSwag/ApiException.cs b/src/JsonApiDotNetCore.OpenApi.Client.NSwag/ApiException.cs
index 8b66839e9e..a86118c875 100644
--- a/src/JsonApiDotNetCore.OpenApi.Client.NSwag/ApiException.cs
+++ b/src/JsonApiDotNetCore.OpenApi.Client.NSwag/ApiException.cs
@@ -5,6 +5,13 @@
namespace JsonApiDotNetCore.OpenApi.Client.NSwag;
+///
+/// Replacement for the auto-generated
+///
+/// ApiException
+///
+/// class from NSwag.
+///
[UsedImplicitly(ImplicitUseTargetFlags.Members)]
public class ApiException(string message, int statusCode, string? response, IReadOnlyDictionary> headers, Exception? innerException)
: Exception($"HTTP {statusCode}: {message}", innerException)
@@ -14,6 +21,13 @@ public class ApiException(string message, int statusCode, string? response, IRea
public IReadOnlyDictionary> Headers { get; } = headers;
}
+///
+/// Replacement for the auto-generated
+///
+/// ApiException<TResult>
+///
+/// class from NSwag.
+///
[UsedImplicitly(ImplicitUseTargetFlags.Members)]
public sealed class ApiException(
string message, int statusCode, string? response, IReadOnlyDictionary> headers, TResult result, Exception? innerException)
diff --git a/src/JsonApiDotNetCore.OpenApi.Client.NSwag/ApiResponse.cs b/src/JsonApiDotNetCore.OpenApi.Client.NSwag/ApiResponse.cs
index 74ee77127f..7d3d7c2a52 100644
--- a/src/JsonApiDotNetCore.OpenApi.Client.NSwag/ApiResponse.cs
+++ b/src/JsonApiDotNetCore.OpenApi.Client.NSwag/ApiResponse.cs
@@ -3,6 +3,13 @@
namespace JsonApiDotNetCore.OpenApi.Client.NSwag;
+///
+/// Replacement for the auto-generated
+///
+/// SwaggerResponse
+///
+/// class from NSwag.
+///
[PublicAPI]
public class ApiResponse(int statusCode, IReadOnlyDictionary> headers)
{
@@ -71,6 +78,13 @@ public static async Task TranslateAsync(Func> ope
}
}
+///
+/// Replacement for the auto-generated
+///
+/// SwaggerResponse<TResult>
+///
+/// class from NSwag.
+///
[PublicAPI]
public class ApiResponse(int statusCode, IReadOnlyDictionary> headers, TResult result)
: ApiResponse(statusCode, headers)
diff --git a/src/JsonApiDotNetCore.OpenApi.Client.NSwag/BlockedJsonInheritanceConverter.cs b/src/JsonApiDotNetCore.OpenApi.Client.NSwag/BlockedJsonInheritanceConverter.cs
index a3a7e627db..602bacce63 100644
--- a/src/JsonApiDotNetCore.OpenApi.Client.NSwag/BlockedJsonInheritanceConverter.cs
+++ b/src/JsonApiDotNetCore.OpenApi.Client.NSwag/BlockedJsonInheritanceConverter.cs
@@ -4,6 +4,13 @@
namespace JsonApiDotNetCore.OpenApi.Client.NSwag;
// Referenced from liquid template, to ensure the built-in JsonInheritanceConverter from NSwag is never used.
+///
+/// Exists to block usage of the default
+///
+/// JsonInheritanceConverter
+///
+/// from NSwag, which is incompatible with JSON:API.
+///
[PublicAPI]
public abstract class BlockedJsonInheritanceConverter : JsonConverter
{
@@ -31,11 +38,17 @@ public override bool CanConvert(Type objectType)
return true;
}
+ ///
+ /// Always throws an .
+ ///
public override void WriteJson(JsonWriter writer, object? value, JsonSerializer serializer)
{
throw new InvalidOperationException("JsonInheritanceConverter is incompatible with JSON:API and must not be used.");
}
+ ///
+ /// Always throws an .
+ ///
public override object ReadJson(JsonReader reader, Type objectType, object? existingValue, JsonSerializer serializer)
{
throw new InvalidOperationException("JsonInheritanceConverter is incompatible with JSON:API and must not be used.");
diff --git a/src/JsonApiDotNetCore.OpenApi.Client.NSwag/IJsonApiClient.cs b/src/JsonApiDotNetCore.OpenApi.Client.NSwag/IJsonApiClient.cs
deleted file mode 100644
index df6a35d78e..0000000000
--- a/src/JsonApiDotNetCore.OpenApi.Client.NSwag/IJsonApiClient.cs
+++ /dev/null
@@ -1,41 +0,0 @@
-using System.Linq.Expressions;
-using JetBrains.Annotations;
-
-namespace JsonApiDotNetCore.OpenApi.Client.NSwag;
-
-[PublicAPI]
-public interface IJsonApiClient
-{
- ///
- /// Ensures correct serialization of JSON:API attributes in the request body of a POST/PATCH request at a resource endpoint. Properties with default
- /// values are omitted, unless explicitly included using
- ///
- /// In JSON:API, an omitted attribute indicates to ignore it, while an attribute that is set to null means to clear it. This poses a problem,
- /// because the serializer cannot distinguish between "you have explicitly set this .NET property to its default value" vs "you didn't touch it, so it
- /// contains its default value" when converting to JSON.
- ///
- ///
- ///
- /// The request document instance for which default values should be omitted.
- ///
- ///
- /// Optional. A list of lambda expressions that indicate which properties to always include in the JSON request body. For example:
- /// video.Title, video => video.Summary
- /// ]]>
- ///
- ///
- /// The type of the request document.
- ///
- ///
- /// The type of the attributes object inside .
- ///
- ///
- /// An to clear the current registration. For efficient memory usage, it is recommended to wrap calls to this method in a
- /// using statement, so the registrations are cleaned up after executing the request. After disposal, the client can be reused without the
- /// registrations added earlier.
- ///
- IDisposable WithPartialAttributeSerialization(TRequestDocument requestDocument,
- params Expression>[] alwaysIncludedAttributeSelectors)
- where TRequestDocument : class;
-}
diff --git a/src/JsonApiDotNetCore.OpenApi.Client.NSwag/NotifyPropertySet.cs b/src/JsonApiDotNetCore.OpenApi.Client.NSwag/NotifyPropertySet.cs
index 80adb56477..111b894879 100644
--- a/src/JsonApiDotNetCore.OpenApi.Client.NSwag/NotifyPropertySet.cs
+++ b/src/JsonApiDotNetCore.OpenApi.Client.NSwag/NotifyPropertySet.cs
@@ -11,7 +11,8 @@
namespace JsonApiDotNetCore.OpenApi.Client.NSwag;
///
-/// Implementation of that doesn't detect changes.
+/// Implementation of that unconditionally raises the event when a property is
+/// assigned. Exists to support JSON:API partial POST/PATCH.
///
[PublicAPI]
public abstract class NotifyPropertySet : INotifyPropertyChanged
diff --git a/src/JsonApiDotNetCore.OpenApi.Swashbuckle/JsonApiDotNetCore.OpenApi.Swashbuckle.csproj b/src/JsonApiDotNetCore.OpenApi.Swashbuckle/JsonApiDotNetCore.OpenApi.Swashbuckle.csproj
index 89822ff4b3..4a57ca1c85 100644
--- a/src/JsonApiDotNetCore.OpenApi.Swashbuckle/JsonApiDotNetCore.OpenApi.Swashbuckle.csproj
+++ b/src/JsonApiDotNetCore.OpenApi.Swashbuckle/JsonApiDotNetCore.OpenApi.Swashbuckle.csproj
@@ -11,7 +11,7 @@
$(VersionPrefix)-preview.$(OpenApiPreviewNumber)
jsonapidotnetcore;jsonapi;json:api;dotnet;asp.net;rest;web-api;openapi;swagger;swaggerui;swashbuckle
- A Swashbuckle integration that enables you to describe a JsonApiDotNetCore API with an OpenAPI specification.
+ Provides OpenAPI document generation for JsonApiDotNetCore APIs by using Swashbuckle.
json-api-dotnet
https://www.jsonapi.net/
MIT
diff --git a/src/JsonApiDotNetCore.OpenApi.Swashbuckle/ServiceCollectionExtensions.cs b/src/JsonApiDotNetCore.OpenApi.Swashbuckle/ServiceCollectionExtensions.cs
index df5247d9de..6872115289 100644
--- a/src/JsonApiDotNetCore.OpenApi.Swashbuckle/ServiceCollectionExtensions.cs
+++ b/src/JsonApiDotNetCore.OpenApi.Swashbuckle/ServiceCollectionExtensions.cs
@@ -1,5 +1,5 @@
-using System.Diagnostics.CodeAnalysis;
using JsonApiDotNetCore.Configuration;
+using JsonApiDotNetCore.Errors;
using JsonApiDotNetCore.Middleware;
using JsonApiDotNetCore.OpenApi.Swashbuckle.JsonApiMetadata;
using JsonApiDotNetCore.OpenApi.Swashbuckle.SchemaGenerators;
@@ -21,10 +21,10 @@ public static class ServiceCollectionExtensions
///
/// Configures OpenAPI for JsonApiDotNetCore using Swashbuckle.
///
- [Experimental("JADNC_OA_001", UrlFormat = "https://github.com/json-api-dotnet/JsonApiDotNetCore/blob/master/docs/usage/openapi.md")]
public static void AddOpenApiForJsonApi(this IServiceCollection services, Action? configureSwaggerGenOptions = null)
{
ArgumentNullException.ThrowIfNull(services);
+ AssertHasJsonApi(services);
AddCustomApiExplorer(services);
AddCustomSwaggerComponents(services);
@@ -40,6 +40,14 @@ public static void AddOpenApiForJsonApi(this IServiceCollection services, Action
services.Replace(ServiceDescriptor.Singleton());
}
+ private static void AssertHasJsonApi(IServiceCollection services)
+ {
+ if (services.FirstOrDefault(descriptor => descriptor.ServiceType == typeof(IJsonApiOptions)) == null)
+ {
+ throw new InvalidConfigurationException("Call 'services.AddJsonApi()' before calling 'services.AddOpenApiForJsonApi()'.");
+ }
+ }
+
private static void AddCustomApiExplorer(IServiceCollection services)
{
services.TryAddSingleton();
diff --git a/src/JsonApiDotNetCore.SourceGenerators/JsonApiDotNetCore.SourceGenerators.csproj b/src/JsonApiDotNetCore.SourceGenerators/JsonApiDotNetCore.SourceGenerators.csproj
index 8f9e397df3..db6f039bd1 100644
--- a/src/JsonApiDotNetCore.SourceGenerators/JsonApiDotNetCore.SourceGenerators.csproj
+++ b/src/JsonApiDotNetCore.SourceGenerators/JsonApiDotNetCore.SourceGenerators.csproj
@@ -12,7 +12,7 @@
jsonapidotnetcore;jsonapi;json:api;dotnet;asp.net;rest;web-api
- Source generators for JsonApiDotNetCore, a framework for building JSON:API compliant REST APIs using ASP.NET and Entity Framework Core.
+ Source generators for JsonApiDotNetCore, which is a framework for building JSON:API compliant REST APIs using ASP.NET Core and Entity Framework Core.
json-api-dotnet
https://www.jsonapi.net/
MIT
diff --git a/src/JsonApiDotNetCore/Configuration/ApplicationBuilderExtensions.cs b/src/JsonApiDotNetCore/Configuration/ApplicationBuilderExtensions.cs
index 3957a28835..fb69fa5ae5 100644
--- a/src/JsonApiDotNetCore/Configuration/ApplicationBuilderExtensions.cs
+++ b/src/JsonApiDotNetCore/Configuration/ApplicationBuilderExtensions.cs
@@ -1,3 +1,4 @@
+using JsonApiDotNetCore.Errors;
using JsonApiDotNetCore.Middleware;
using Microsoft.AspNetCore.Builder;
using Microsoft.Extensions.DependencyInjection;
@@ -60,8 +61,9 @@ private static void AssertAspNetCoreOpenApiIsNotRegistered(IServiceProvider serv
if (configureInstance != null)
{
- throw new InvalidOperationException("JsonApiDotNetCore is incompatible with ASP.NET OpenAPI. " +
- "Replace 'services.AddOpenApi()' with 'services.AddOpenApiForJsonApi()' from the JsonApiDotNetCore.OpenApi.Swashbuckle NuGet package.");
+ throw new InvalidConfigurationException("JsonApiDotNetCore is incompatible with ASP.NET OpenAPI. " +
+ "Remove 'services.AddOpenApi()', or replace it by calling 'services.AddOpenApiForJsonApi()' after 'services.AddJsonApi()' " +
+ "from the JsonApiDotNetCore.OpenApi.Swashbuckle NuGet package.");
}
}
}
diff --git a/src/JsonApiDotNetCore/Configuration/ResourceGraphBuilder.cs b/src/JsonApiDotNetCore/Configuration/ResourceGraphBuilder.cs
index 7cdf04404b..8ab2120d92 100644
--- a/src/JsonApiDotNetCore/Configuration/ResourceGraphBuilder.cs
+++ b/src/JsonApiDotNetCore/Configuration/ResourceGraphBuilder.cs
@@ -396,8 +396,8 @@ private ReadOnlyCollection GetEagerLoads(Type resourceClrTyp
continue;
}
- Type innerType = TypeOrElementType(property.PropertyType);
- eagerLoad.Children = GetEagerLoads(innerType, recursionDepth + 1);
+ Type rightType = CollectionConverter.Instance.FindCollectionElementType(property.PropertyType) ?? property.PropertyType;
+ eagerLoad.Children = GetEagerLoads(rightType, recursionDepth + 1);
eagerLoad.Property = property;
eagerLoads.Add(eagerLoad);
@@ -455,18 +455,10 @@ private static void AssertNoInfiniteRecursion(int recursionDepth)
{
if (recursionDepth >= 500)
{
- throw new InvalidOperationException("Infinite recursion detected in eager-load chain.");
+ throw new InvalidConfigurationException("Infinite recursion detected in eager-load chain.");
}
}
- private Type TypeOrElementType(Type type)
- {
- Type[] interfaces = type.GetInterfaces().Where(@interface => @interface.IsGenericType && @interface.GetGenericTypeDefinition() == typeof(IEnumerable<>))
- .ToArray();
-
- return interfaces.Length == 1 ? interfaces.Single().GenericTypeArguments[0] : type;
- }
-
private string FormatResourceName(Type resourceClrType)
{
var formatter = new ResourceNameFormatter(_options.SerializerOptions.PropertyNamingPolicy);
diff --git a/src/JsonApiDotNetCore/Configuration/TypeLocator.cs b/src/JsonApiDotNetCore/Configuration/TypeLocator.cs
index 6b8c545744..768f94a98d 100644
--- a/src/JsonApiDotNetCore/Configuration/TypeLocator.cs
+++ b/src/JsonApiDotNetCore/Configuration/TypeLocator.cs
@@ -82,8 +82,16 @@ internal sealed class TypeLocator
$"instead of {interfaceTypeArguments.Length}.", nameof(interfaceTypeArguments));
}
- return assembly.GetTypes().Select(type => GetContainerRegistrationFromType(type, unboundInterface, interfaceTypeArguments))
+ // @formatter:wrap_chained_method_calls chop_always
+ // @formatter:wrap_before_first_method_call true
+
+ return assembly
+ .GetTypes()
+ .Select(type => GetContainerRegistrationFromType(type, unboundInterface, interfaceTypeArguments))
.FirstOrDefault(result => result != null);
+
+ // @formatter:wrap_before_first_method_call restore
+ // @formatter:wrap_chained_method_calls restore
}
private static (Type implementationType, Type serviceInterface)? GetContainerRegistrationFromType(Type nextType, Type unboundInterface,
diff --git a/src/JsonApiDotNetCore/JsonApiDotNetCore.csproj b/src/JsonApiDotNetCore/JsonApiDotNetCore.csproj
index 1c1ba7ab7f..d36600e878 100644
--- a/src/JsonApiDotNetCore/JsonApiDotNetCore.csproj
+++ b/src/JsonApiDotNetCore/JsonApiDotNetCore.csproj
@@ -9,7 +9,7 @@
jsonapidotnetcore;jsonapi;json:api;dotnet;asp.net;rest;web-api
- A framework for building JSON:API compliant REST APIs using ASP.NET and Entity Framework Core. Includes support for Atomic Operations. The ultimate goal of this library is to eliminate as much boilerplate as possible by offering out-of-the-box features such as sorting, filtering and pagination. You just need to focus on defining the resources and implementing your custom business logic. This library has been designed around dependency injection making extensibility incredibly easy.
+ A framework for building JSON:API compliant REST APIs using ASP.NET Core and Entity Framework Core. Includes support for the Atomic Operations extension. The ultimate goal of this library is to eliminate as much boilerplate as possible by offering out-of-the-box features, such as sorting, filtering, pagination, sparse fieldset selection, and side-loading related resources. You just need to focus on defining the resources and implementing your custom business logic. This library has been designed around dependency injection, making extensibility incredibly easy.
json-api-dotnet
https://www.jsonapi.net/
MIT
diff --git a/src/JsonApiDotNetCore/Middleware/TraceLogWriter.cs b/src/JsonApiDotNetCore/Middleware/TraceLogWriter.cs
index 70ed7fdd01..23e6733a44 100644
--- a/src/JsonApiDotNetCore/Middleware/TraceLogWriter.cs
+++ b/src/JsonApiDotNetCore/Middleware/TraceLogWriter.cs
@@ -1,3 +1,4 @@
+using System.Linq.Expressions;
using System.Reflection;
using System.Runtime.CompilerServices;
using System.Text;
@@ -5,6 +6,8 @@
using System.Text.Json;
using System.Text.Json.Serialization;
using JsonApiDotNetCore.Configuration;
+using JsonApiDotNetCore.Queries;
+using JsonApiDotNetCore.Queries.QueryableBuilding;
using JsonApiDotNetCore.Resources;
using JsonApiDotNetCore.Resources.Annotations;
using Microsoft.Extensions.Logging;
@@ -204,9 +207,45 @@ private static string SerializeObject(object? value)
}
}
+ public void LogDebug(QueryLayer queryLayer)
+ {
+ ArgumentNullException.ThrowIfNull(queryLayer);
+
+ LogQueryLayer(queryLayer);
+ }
+
+ public void LogDebug(Expression expression)
+ {
+ ArgumentNullException.ThrowIfNull(expression);
+
+ if (_logger.IsEnabled(LogLevel.Debug))
+ {
+ string? text = ExpressionTreeFormatter.Instance.GetText(expression);
+
+ if (text != null)
+ {
+ LogExpression(text);
+ }
+ else
+ {
+ LogReadableExpressionsAssemblyUnavailable();
+ }
+ }
+ }
+
[LoggerMessage(Level = LogLevel.Trace, SkipEnabledCheck = true, Message = "Entering {MemberName}({ParameterValues})")]
private partial void LogEnteringMemberWithParameters(string memberName, string parameterValues);
[LoggerMessage(Level = LogLevel.Trace, SkipEnabledCheck = true, Message = "Entering {MemberName}()")]
private partial void LogEnteringMember(string memberName);
+
+ [LoggerMessage(Level = LogLevel.Debug, Message = "QueryLayer: {queryLayer}")]
+ private partial void LogQueryLayer(QueryLayer queryLayer);
+
+ [LoggerMessage(Level = LogLevel.Debug, SkipEnabledCheck = true, Message = "Expression tree: {expression}")]
+ private partial void LogExpression(string expression);
+
+ [LoggerMessage(Level = LogLevel.Debug, SkipEnabledCheck = true,
+ Message = "Failed to load assembly. To log expression trees, add a NuGet reference to 'AgileObjects.ReadableExpressions' in your project.")]
+ private partial void LogReadableExpressionsAssemblyUnavailable();
}
diff --git a/src/JsonApiDotNetCore/Queries/Parsing/QueryTokenizer.cs b/src/JsonApiDotNetCore/Queries/Parsing/QueryTokenizer.cs
index 0c5f634375..0e1e7660a2 100644
--- a/src/JsonApiDotNetCore/Queries/Parsing/QueryTokenizer.cs
+++ b/src/JsonApiDotNetCore/Queries/Parsing/QueryTokenizer.cs
@@ -1,3 +1,4 @@
+using System.Collections.ObjectModel;
using System.Text;
using JetBrains.Annotations;
@@ -6,17 +7,18 @@ namespace JsonApiDotNetCore.Queries.Parsing;
[PublicAPI]
public sealed class QueryTokenizer
{
- public static readonly Dictionary SingleCharacterToTokenKinds = new()
- {
- ['('] = TokenKind.OpenParen,
- [')'] = TokenKind.CloseParen,
- ['['] = TokenKind.OpenBracket,
- [']'] = TokenKind.CloseBracket,
- ['.'] = TokenKind.Period,
- [','] = TokenKind.Comma,
- [':'] = TokenKind.Colon,
- ['-'] = TokenKind.Minus
- };
+ public static readonly IReadOnlyDictionary SingleCharacterToTokenKinds = new ReadOnlyDictionary(
+ new Dictionary
+ {
+ ['('] = TokenKind.OpenParen,
+ [')'] = TokenKind.CloseParen,
+ ['['] = TokenKind.OpenBracket,
+ [']'] = TokenKind.CloseBracket,
+ ['.'] = TokenKind.Period,
+ [','] = TokenKind.Comma,
+ [':'] = TokenKind.Colon,
+ ['-'] = TokenKind.Minus
+ });
private readonly string _source;
private readonly StringBuilder _textBuffer = new();
diff --git a/src/JsonApiDotNetCore/Queries/QueryLayer.cs b/src/JsonApiDotNetCore/Queries/QueryLayer.cs
index 1ff8e34dcf..49a9ee92a2 100644
--- a/src/JsonApiDotNetCore/Queries/QueryLayer.cs
+++ b/src/JsonApiDotNetCore/Queries/QueryLayer.cs
@@ -11,6 +11,8 @@ namespace JsonApiDotNetCore.Queries;
[PublicAPI]
public sealed class QueryLayer
{
+ internal bool IsEmpty => Filter == null && Sort == null && Pagination?.PageSize == null && (Selection == null || Selection.IsEmpty);
+
public ResourceType ResourceType { get; }
public IncludeExpression? Include { get; set; }
diff --git a/src/JsonApiDotNetCore/Queries/QueryLayerComposer.cs b/src/JsonApiDotNetCore/Queries/QueryLayerComposer.cs
index f7843b12cf..7954aa0e76 100644
--- a/src/JsonApiDotNetCore/Queries/QueryLayerComposer.cs
+++ b/src/JsonApiDotNetCore/Queries/QueryLayerComposer.cs
@@ -173,13 +173,20 @@ private QueryLayer ComposeTopLayer(ImmutableArray constraints
_paginationContext.PageSize = topPagination.PageSize;
_paginationContext.PageNumber = topPagination.PageNumber;
- return new QueryLayer(resourceType)
+ var topLayer = new QueryLayer(resourceType)
{
Filter = GetFilter(expressionsInTopScope, resourceType),
Sort = GetSort(expressionsInTopScope, resourceType),
Pagination = topPagination,
Selection = GetSelectionForSparseAttributeSet(resourceType)
};
+
+ if (topLayer is { Pagination.PageSize: not null, Sort: null })
+ {
+ topLayer.Sort = CreateSortById(resourceType);
+ }
+
+ return topLayer;
}
private IncludeExpression ComposeChildren(QueryLayer topLayer, ImmutableArray constraints)
@@ -237,7 +244,7 @@ private IImmutableSet ProcessIncludeSet(IImmutableSet<
ResourceType resourceType = includeElement.Relationship.RightType;
bool isToManyRelationship = includeElement.Relationship is HasManyAttribute;
- var child = new QueryLayer(resourceType)
+ var subLayer = new QueryLayer(resourceType)
{
Filter = isToManyRelationship ? GetFilter(expressionsInCurrentScope, resourceType) : null,
Sort = isToManyRelationship ? GetSort(expressionsInCurrentScope, resourceType) : null,
@@ -245,9 +252,14 @@ private IImmutableSet ProcessIncludeSet(IImmutableSet<
Selection = GetSelectionForSparseAttributeSet(resourceType)
};
- selectors.IncludeRelationship(includeElement.Relationship, child);
+ if (subLayer is { Pagination.PageSize: not null, Sort: null })
+ {
+ subLayer.Sort = CreateSortById(resourceType);
+ }
- IImmutableSet updatedChildren = ProcessIncludeSet(includeElement.Children, child, relationshipChain, constraints);
+ selectors.IncludeRelationship(includeElement.Relationship, subLayer);
+
+ IImmutableSet updatedChildren = ProcessIncludeSet(includeElement.Children, subLayer, relationshipChain, constraints);
if (!ReferenceEquals(includeElement.Children, updatedChildren))
{
@@ -256,9 +268,30 @@ private IImmutableSet ProcessIncludeSet(IImmutableSet<
}
}
+ EliminateRedundantSelectors(parentLayer);
+
return updatesInChildren.Count == 0 ? includeElementsEvaluated : ApplyIncludeElementUpdates(includeElementsEvaluated, updatesInChildren);
}
+ private static void EliminateRedundantSelectors(QueryLayer parentLayer)
+ {
+ if (parentLayer.Selection != null)
+ {
+ foreach ((ResourceType resourceType, FieldSelectors selectors) in parentLayer.Selection.ToArray())
+ {
+ if (selectors.ContainsOnlyRelationships && selectors.Values.OfType().All(subLayer => subLayer.IsEmpty))
+ {
+ parentLayer.Selection.Remove(resourceType);
+ }
+ }
+
+ if (parentLayer.Selection.IsEmpty)
+ {
+ parentLayer.Selection = null;
+ }
+ }
+ }
+
private static ImmutableHashSet ApplyIncludeElementUpdates(IImmutableSet includeElements,
Dictionary> updatesInChildren)
{
@@ -507,23 +540,21 @@ protected virtual IImmutableSet GetIncludeElements(IIm
return _resourceDefinitionAccessor.OnApplyFilter(resourceType, filter);
}
- protected virtual SortExpression GetSort(IReadOnlyCollection expressionsInScope, ResourceType resourceType)
+ protected virtual SortExpression? GetSort(IReadOnlyCollection expressionsInScope, ResourceType resourceType)
{
ArgumentNullException.ThrowIfNull(expressionsInScope);
ArgumentNullException.ThrowIfNull(resourceType);
SortExpression? sort = expressionsInScope.OfType().FirstOrDefault();
- sort = _resourceDefinitionAccessor.OnApplySort(resourceType, sort);
-
- if (sort == null)
- {
- AttrAttribute idAttribute = GetIdAttribute(resourceType);
- var idAscendingSort = new SortElementExpression(new ResourceFieldChainExpression(idAttribute), true);
- sort = new SortExpression(ImmutableArray.Create(idAscendingSort));
- }
+ return _resourceDefinitionAccessor.OnApplySort(resourceType, sort);
+ }
- return sort;
+ private SortExpression CreateSortById(ResourceType resourceType)
+ {
+ AttrAttribute idAttribute = GetIdAttribute(resourceType);
+ var idAscendingSort = new SortElementExpression(new ResourceFieldChainExpression(idAttribute), true);
+ return new SortExpression(ImmutableArray.Create(idAscendingSort));
}
protected virtual PaginationExpression GetPagination(IReadOnlyCollection expressionsInScope, ResourceType resourceType)
diff --git a/src/JsonApiDotNetCore/Queries/QueryableBuilding/ExpressionTreeFormatter.cs b/src/JsonApiDotNetCore/Queries/QueryableBuilding/ExpressionTreeFormatter.cs
new file mode 100644
index 0000000000..c6b1bc4bb3
--- /dev/null
+++ b/src/JsonApiDotNetCore/Queries/QueryableBuilding/ExpressionTreeFormatter.cs
@@ -0,0 +1,53 @@
+using System.Linq.Expressions;
+using System.Reflection;
+
+namespace JsonApiDotNetCore.Queries.QueryableBuilding;
+
+///
+/// Converts a to readable text, if the AgileObjects.ReadableExpressions NuGet package is referenced.
+///
+internal sealed class ExpressionTreeFormatter
+{
+ private static readonly Lazy LazyToReadableStringMethod = new(GetToReadableStringMethod, LazyThreadSafetyMode.ExecutionAndPublication);
+
+ public static ExpressionTreeFormatter Instance { get; } = new();
+
+ private ExpressionTreeFormatter()
+ {
+ }
+
+ private static MethodInvoker? GetToReadableStringMethod()
+ {
+ Assembly? assembly = TryLoadAssembly();
+ Type? type = assembly?.GetType("AgileObjects.ReadableExpressions.ExpressionExtensions", false);
+ MethodInfo? method = type?.GetMethods(BindingFlags.Public | BindingFlags.Static).FirstOrDefault(method => method.Name == "ToReadableString");
+ return method != null ? MethodInvoker.Create(method) : null;
+ }
+
+ private static Assembly? TryLoadAssembly()
+ {
+ try
+ {
+ return Assembly.Load("AgileObjects.ReadableExpressions");
+ }
+ catch (Exception exception) when (exception is ArgumentException or IOException or BadImageFormatException)
+ {
+ }
+
+ return null;
+ }
+
+ public string? GetText(Expression expression)
+ {
+ ArgumentNullException.ThrowIfNull(expression);
+
+ try
+ {
+ return LazyToReadableStringMethod.Value?.Invoke(null, expression, null) as string;
+ }
+ catch (Exception exception) when (exception is TargetException or InvalidOperationException or TargetParameterCountException or NotSupportedException)
+ {
+ return null;
+ }
+ }
+}
diff --git a/src/JsonApiDotNetCore/Repositories/EntityFrameworkCoreRepository.cs b/src/JsonApiDotNetCore/Repositories/EntityFrameworkCoreRepository.cs
index 214987828a..f4c9af37c0 100644
--- a/src/JsonApiDotNetCore/Repositories/EntityFrameworkCoreRepository.cs
+++ b/src/JsonApiDotNetCore/Repositories/EntityFrameworkCoreRepository.cs
@@ -122,6 +122,8 @@ protected virtual IQueryable ApplyQueryLayer(QueryLayer queryLayer)
ArgumentNullException.ThrowIfNull(queryLayer);
+ _traceWriter.LogDebug(queryLayer);
+
using (CodeTimingSessionManager.Current.Measure("Convert QueryLayer to System.Expression"))
{
IQueryable source = GetAll();
@@ -151,6 +153,8 @@ protected virtual IQueryable ApplyQueryLayer(QueryLayer queryLayer)
var context = QueryableBuilderContext.CreateRoot(source, typeof(Queryable), _dbContext.Model, null);
Expression expression = builder.ApplyQuery(queryLayer, context);
+ _traceWriter.LogDebug(expression);
+
using (CodeTimingSessionManager.Current.Measure("Convert System.Expression to IQueryable"))
{
return source.Provider.CreateQuery(expression);
diff --git a/test/DapperTests/IntegrationTests/QueryStrings/FilterTests.cs b/test/DapperTests/IntegrationTests/QueryStrings/FilterTests.cs
index f7da3533f9..c303d70341 100644
--- a/test/DapperTests/IntegrationTests/QueryStrings/FilterTests.cs
+++ b/test/DapperTests/IntegrationTests/QueryStrings/FilterTests.cs
@@ -78,7 +78,6 @@ SELECT COUNT(*)
FROM "Tags" AS t1
LEFT JOIN "RgbColors" AS t2 ON t1."Id" = t2."TagId"
WHERE t2."Id" = @p1
- ORDER BY t1."Id"
"""));
command.Parameters.Should().HaveCount(1);
@@ -144,7 +143,6 @@ SELECT COUNT(*)
FROM "Tags" AS t1
LEFT JOIN "RgbColors" AS t2 ON t1."Id" = t2."TagId"
WHERE t2."Id" IN (@p1, @p2)
- ORDER BY t1."Id"
"""));
command.Parameters.Should().HaveCount(2);
@@ -662,7 +660,6 @@ SELECT COUNT(*)
SELECT t1."Id", t1."FirstName", t1."LastName"
FROM "People" AS t1
WHERE (NOT (t1."FirstName" = @p1)) OR (t1."FirstName" IS NULL)
- ORDER BY t1."Id"
"""));
command.Parameters.Should().HaveCount(1);
@@ -867,7 +864,6 @@ SELECT COUNT(*)
SELECT t1."Id", t1."Name"
FROM "Tags" AS t1
WHERE (t1."Name" LIKE '%A\%%' ESCAPE '\') OR (t1."Name" LIKE '%A\_%' ESCAPE '\') OR (t1."Name" LIKE '%A\\%' ESCAPE '\') OR (t1."Name" LIKE '%A''%') OR (t1."Name" LIKE '%\%\_\\''%' ESCAPE '\')
- ORDER BY t1."Id"
"""));
command.Parameters.Should().BeEmpty();
@@ -1177,7 +1173,6 @@ SELECT 1
LEFT JOIN "People" AS t3 ON t2."AssigneeId" = t3."Id"
WHERE (t1."Id" = t2."OwnerId") AND (NOT (t3."Id" IS NULL)) AND (t3."FirstName" IS NULL)
)
- ORDER BY t1."Id"
"""));
command.Parameters.Should().BeEmpty();
diff --git a/test/DapperTests/IntegrationTests/QueryStrings/IncludeTests.cs b/test/DapperTests/IntegrationTests/QueryStrings/IncludeTests.cs
index 77805ee1b5..84625b463f 100644
--- a/test/DapperTests/IntegrationTests/QueryStrings/IncludeTests.cs
+++ b/test/DapperTests/IntegrationTests/QueryStrings/IncludeTests.cs
@@ -165,7 +165,7 @@ SELECT COUNT(*)
INNER JOIN "People" AS t3 ON t1."OwnerId" = t3."Id"
LEFT JOIN "TodoItems" AS t4 ON t3."Id" = t4."AssigneeId"
LEFT JOIN "Tags" AS t5 ON t1."Id" = t5."TodoItemId"
- ORDER BY t1."Priority", t1."LastModifiedAt" DESC, t4."Priority", t4."LastModifiedAt" DESC, t5."Id"
+ ORDER BY t1."Priority", t1."LastModifiedAt" DESC, t4."Priority", t4."LastModifiedAt" DESC
"""));
command.Parameters.Should().BeEmpty();
@@ -231,7 +231,7 @@ SELECT COUNT(*)
FROM "TodoItems" AS t1
LEFT JOIN "Tags" AS t2 ON t1."Id" = t2."TodoItemId"
LEFT JOIN "RgbColors" AS t3 ON t2."Id" = t3."TagId"
- ORDER BY t1."Priority", t1."LastModifiedAt" DESC, t2."Id"
+ ORDER BY t1."Priority", t1."LastModifiedAt" DESC
"""));
command.Parameters.Should().BeEmpty();
diff --git a/test/DapperTests/IntegrationTests/QueryStrings/SortTests.cs b/test/DapperTests/IntegrationTests/QueryStrings/SortTests.cs
index 488dda2cc3..6a155d1524 100644
--- a/test/DapperTests/IntegrationTests/QueryStrings/SortTests.cs
+++ b/test/DapperTests/IntegrationTests/QueryStrings/SortTests.cs
@@ -349,7 +349,7 @@ ORDER BY (
SELECT COUNT(*)
FROM "Tags" AS t3
WHERE t2."Id" = t3."TodoItemId"
- ) DESC, t2."Id", t4."Id"
+ ) DESC, t2."Id"
"""));
command.Parameters.Should().HaveCount(1);
@@ -415,7 +415,7 @@ SELECT COUNT(*)
SELECT t1."Id", t1."FirstName", t1."LastName", t2."Id", t2."CreatedAt", t2."Description", t2."DurationInHours", t2."LastModifiedAt", t2."Priority"
FROM "People" AS t1
LEFT JOIN "TodoItems" AS t2 ON t1."Id" = t2."OwnerId"
- ORDER BY t1."Id", (
+ ORDER BY (
SELECT COUNT(*)
FROM "Tags" AS t3
WHERE t2."Id" = t3."TodoItemId"
diff --git a/test/DapperTests/IntegrationTests/QueryStrings/SparseFieldSets.cs b/test/DapperTests/IntegrationTests/QueryStrings/SparseFieldSets.cs
index b2e0c68f8c..a1d4524c92 100644
--- a/test/DapperTests/IntegrationTests/QueryStrings/SparseFieldSets.cs
+++ b/test/DapperTests/IntegrationTests/QueryStrings/SparseFieldSets.cs
@@ -215,7 +215,6 @@ SELECT COUNT(*)
FROM "TodoItems" AS t1
LEFT JOIN "Tags" AS t2 ON t1."Id" = t2."TodoItemId"
WHERE t1."Id" = @p1
- ORDER BY t2."Id"
"""));
command.Parameters.Should().HaveCount(1);
@@ -400,7 +399,6 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
FROM "TodoItems" AS t1
LEFT JOIN "Tags" AS t2 ON t1."Id" = t2."TodoItemId"
WHERE t1."Id" = @p1
- ORDER BY t2."Id"
"""));
command.Parameters.Should().HaveCount(1);
diff --git a/test/DapperTests/IntegrationTests/ReadWrite/Relationships/FetchRelationshipTests.cs b/test/DapperTests/IntegrationTests/ReadWrite/Relationships/FetchRelationshipTests.cs
index d4703dc99a..9783672e63 100644
--- a/test/DapperTests/IntegrationTests/ReadWrite/Relationships/FetchRelationshipTests.cs
+++ b/test/DapperTests/IntegrationTests/ReadWrite/Relationships/FetchRelationshipTests.cs
@@ -168,7 +168,6 @@ SELECT COUNT(*)
FROM "TodoItems" AS t1
LEFT JOIN "Tags" AS t2 ON t1."Id" = t2."TodoItemId"
WHERE t1."Id" = @p1
- ORDER BY t2."Id"
"""));
command.Parameters.Should().HaveCount(1);
diff --git a/test/DapperTests/IntegrationTests/ReadWrite/Resources/FetchResourceTests.cs b/test/DapperTests/IntegrationTests/ReadWrite/Resources/FetchResourceTests.cs
index bd7139e5c4..52bb378b2a 100644
--- a/test/DapperTests/IntegrationTests/ReadWrite/Resources/FetchResourceTests.cs
+++ b/test/DapperTests/IntegrationTests/ReadWrite/Resources/FetchResourceTests.cs
@@ -246,7 +246,6 @@ SELECT COUNT(*)
FROM "TodoItems" AS t1
LEFT JOIN "Tags" AS t2 ON t1."Id" = t2."TodoItemId"
WHERE t1."Id" = @p1
- ORDER BY t2."Id"
"""));
command.Parameters.Should().HaveCount(1);
diff --git a/test/DapperTests/IntegrationTests/Sql/SubQueryInJoinTests.cs b/test/DapperTests/IntegrationTests/Sql/SubQueryInJoinTests.cs
index 8b7d18d2d2..9b6e62f39b 100644
--- a/test/DapperTests/IntegrationTests/Sql/SubQueryInJoinTests.cs
+++ b/test/DapperTests/IntegrationTests/Sql/SubQueryInJoinTests.cs
@@ -62,7 +62,6 @@ SELECT COUNT(*)
SELECT t1."Id", t1."FirstName", t1."LastName", t2."Id", t2."LastUsedAt", t2."UserName"
FROM "People" AS t1
LEFT JOIN "LoginAccounts" AS t2 ON t1."AccountId" = t2."Id"
- ORDER BY t1."Id"
"""));
command.Parameters.Should().BeEmpty();
@@ -111,7 +110,7 @@ SELECT COUNT(*)
SELECT t1."Id", t1."FirstName", t1."LastName", t2."Id", t2."CreatedAt", t2."Description", t2."DurationInHours", t2."LastModifiedAt", t2."Priority"
FROM "People" AS t1
LEFT JOIN "TodoItems" AS t2 ON t1."Id" = t2."OwnerId"
- ORDER BY t1."Id", t2."Priority", t2."LastModifiedAt" DESC
+ ORDER BY t2."Priority", t2."LastModifiedAt" DESC
"""));
command.Parameters.Should().BeEmpty();
@@ -160,7 +159,7 @@ SELECT COUNT(*)
SELECT t1."Id", t1."FirstName", t1."LastName", t2."Id", t2."CreatedAt", t2."Description", t2."DurationInHours", t2."LastModifiedAt", t2."Priority"
FROM "People" AS t1
LEFT JOIN "TodoItems" AS t2 ON t1."Id" = t2."OwnerId"
- ORDER BY t1."Id", t2."Description"
+ ORDER BY t2."Description"
"""));
command.Parameters.Should().BeEmpty();
@@ -209,7 +208,7 @@ SELECT COUNT(*)
SELECT t1."Id", t1."FirstName", t1."LastName", t2."Id", t2."CreatedAt", t2."Description", t2."DurationInHours", t2."LastModifiedAt", t2."Priority"
FROM "People" AS t1
LEFT JOIN "TodoItems" AS t2 ON t1."Id" = t2."OwnerId"
- ORDER BY t1."Id", (
+ ORDER BY (
SELECT COUNT(*)
FROM "Tags" AS t3
WHERE t2."Id" = t3."TodoItemId"
@@ -263,7 +262,7 @@ SELECT COUNT(*)
FROM "People" AS t1
LEFT JOIN "TodoItems" AS t2 ON t1."Id" = t2."OwnerId"
LEFT JOIN "Tags" AS t4 ON t2."Id" = t4."TodoItemId"
- ORDER BY t1."Id", (
+ ORDER BY (
SELECT COUNT(*)
FROM "Tags" AS t3
WHERE t2."Id" = t3."TodoItemId"
@@ -326,11 +325,11 @@ SELECT COUNT(*)
SELECT COUNT(*)
FROM "Tags" AS t4
WHERE t3."Id" = t4."TodoItemId"
- ), t5."Id", (
+ ), (
SELECT COUNT(*)
FROM "Tags" AS t7
WHERE t6."Id" = t7."TodoItemId"
- ), t8."Id"
+ )
"""));
command.Parameters.Should().BeEmpty();
@@ -383,7 +382,7 @@ LEFT JOIN (
FROM "TodoItems" AS t2
WHERE t2."Description" = @p1
) AS t3 ON t1."Id" = t3."OwnerId"
- ORDER BY t1."Id", t3."Priority", t3."LastModifiedAt" DESC
+ ORDER BY t3."Priority", t3."LastModifiedAt" DESC
"""));
command.Parameters.Should().HaveCount(1);
@@ -441,7 +440,7 @@ SELECT 1
WHERE t2."Id" = t3."TodoItemId"
)
) AS t4 ON t1."Id" = t4."OwnerId"
- ORDER BY t1."Id", t4."Priority", t4."LastModifiedAt" DESC
+ ORDER BY t4."Priority", t4."LastModifiedAt" DESC
"""));
command.Parameters.Should().BeEmpty();
@@ -498,7 +497,7 @@ SELECT COUNT(*)
WHERE t2."Id" = t3."TodoItemId"
) > @p1
) AS t4 ON t1."Id" = t4."OwnerId"
- ORDER BY t1."Id", t4."Priority", t4."LastModifiedAt" DESC
+ ORDER BY t4."Priority", t4."LastModifiedAt" DESC
"""));
command.Parameters.Should().HaveCount(1);
@@ -554,7 +553,7 @@ LEFT JOIN (
LEFT JOIN "Tags" AS t4 ON t2."Id" = t4."TodoItemId"
WHERE t2."Description" = @p1
) AS t5 ON t1."Id" = t5."OwnerId"
- ORDER BY t1."Id", (
+ ORDER BY (
SELECT COUNT(*)
FROM "Tags" AS t3
WHERE t5."Id" = t3."TodoItemId"
@@ -620,7 +619,7 @@ WHERE NOT (t5."Name" = @p2)
) AS t6 ON t2."Id" = t6."TodoItemId"
WHERE NOT (t2."Description" = @p1)
) AS t7 ON t1."Id" = t7."OwnerId"
- ORDER BY t1."Id", (
+ ORDER BY (
SELECT COUNT(*)
FROM "Tags" AS t3
WHERE t7."Id" = t3."TodoItemId"
diff --git a/test/DiscoveryTests/AspNetOpenApiTests.cs b/test/DiscoveryTests/AspNetOpenApiTests.cs
index 20619f4cc1..06dfcee914 100644
--- a/test/DiscoveryTests/AspNetOpenApiTests.cs
+++ b/test/DiscoveryTests/AspNetOpenApiTests.cs
@@ -1,6 +1,7 @@
#if !NET8_0
using FluentAssertions;
using JsonApiDotNetCore.Configuration;
+using JsonApiDotNetCore.Errors;
using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.TestHost;
using Microsoft.Extensions.DependencyInjection;
@@ -24,8 +25,9 @@ public async Task Throws_when_AspNet_OpenApi_is_registered()
Action action = app.UseJsonApi;
// Assert
- action.Should().ThrowExactly().WithMessage("JsonApiDotNetCore is incompatible with ASP.NET OpenAPI. " +
- "Replace 'services.AddOpenApi()' with 'services.AddOpenApiForJsonApi()' from the JsonApiDotNetCore.OpenApi.Swashbuckle NuGet package.");
+ action.Should().ThrowExactly().WithMessage("JsonApiDotNetCore is incompatible with ASP.NET OpenAPI. " +
+ "Remove 'services.AddOpenApi()', or replace it by calling 'services.AddOpenApiForJsonApi()' after 'services.AddJsonApi()' " +
+ "from the JsonApiDotNetCore.OpenApi.Swashbuckle NuGet package.");
}
}
#endif
diff --git a/test/DiscoveryTests/DiscoveryTests.csproj b/test/DiscoveryTests/DiscoveryTests.csproj
index 825056684e..11567b9113 100644
--- a/test/DiscoveryTests/DiscoveryTests.csproj
+++ b/test/DiscoveryTests/DiscoveryTests.csproj
@@ -1,4 +1,4 @@
-
+
net9.0;net8.0
@@ -15,5 +15,6 @@
+
diff --git a/test/DiscoveryTests/LoggingTests.cs b/test/DiscoveryTests/LoggingTests.cs
new file mode 100644
index 0000000000..9afb7c7888
--- /dev/null
+++ b/test/DiscoveryTests/LoggingTests.cs
@@ -0,0 +1,52 @@
+using FluentAssertions;
+using JsonApiDotNetCore.Configuration;
+using JsonApiDotNetCore.Queries;
+using JsonApiDotNetCore.Repositories;
+using Microsoft.AspNetCore.Builder;
+using Microsoft.AspNetCore.TestHost;
+using Microsoft.EntityFrameworkCore;
+using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Logging;
+using TestBuildingBlocks;
+using Xunit;
+
+namespace DiscoveryTests;
+
+public sealed class LoggingTests
+{
+ [Fact]
+ public async Task Logs_message_to_add_NuGet_reference()
+ {
+ // Arrange
+ using var loggerProvider =
+ new CapturingLoggerProvider((category, _) => category.StartsWith("JsonApiDotNetCore.Repositories", StringComparison.Ordinal));
+
+ WebApplicationBuilder builder = WebApplication.CreateEmptyBuilder(new WebApplicationOptions());
+ builder.Logging.AddProvider(loggerProvider);
+ builder.Logging.SetMinimumLevel(LogLevel.Debug);
+ builder.Services.AddDbContext(options => options.UseInMemoryDatabase(Guid.NewGuid().ToString()));
+ builder.Services.AddJsonApi();
+ builder.WebHost.UseTestServer();
+ await using WebApplication app = builder.Build();
+
+ var resourceGraph = app.Services.GetRequiredService();
+ ResourceType resourceType = resourceGraph.GetResourceType();
+
+ var repository = app.Services.GetRequiredService>();
+
+ // Act
+ _ = await repository.GetAsync(new QueryLayer(resourceType), CancellationToken.None);
+
+ // Assert
+ IReadOnlyList logLines = loggerProvider.GetLines();
+
+ logLines.Should().Contain(
+ "[DEBUG] Failed to load assembly. To log expression trees, add a NuGet reference to 'AgileObjects.ReadableExpressions' in your project.");
+ }
+
+ private sealed class TestDbContext(DbContextOptions options)
+ : DbContext(options)
+ {
+ public DbSet PrivateResources => Set();
+ }
+}
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Mixed/AtomicTraceLoggingTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Mixed/AtomicTraceLoggingTests.cs
index 6eb2ce3a37..0ea01e7d33 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Mixed/AtomicTraceLoggingTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Mixed/AtomicTraceLoggingTests.cs
@@ -22,7 +22,7 @@ public AtomicTraceLoggingTests(IntegrationTestContext
{
var loggerProvider = new CapturingLoggerProvider((category, level) =>
- level >= LogLevel.Trace && category.StartsWith("JsonApiDotNetCore.", StringComparison.Ordinal));
+ level == LogLevel.Trace && category.StartsWith("JsonApiDotNetCore.", StringComparison.Ordinal));
options.AddProvider(loggerProvider);
options.SetMinimumLevel(LogLevel.Trace);
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Playlist.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Playlist.cs
index e8baf731d0..0d6409e761 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Playlist.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/AtomicOperations/Playlist.cs
@@ -12,8 +12,8 @@ public sealed class Playlist : Identifiable
[Attr]
public string Name { get; set; } = null!;
- [NotMapped]
[Attr]
+ [NotMapped]
public bool IsArchived => false;
[HasMany]
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/CompositeKeys/CarCompositeKeyAwareRepository.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/CompositeKeys/CarCompositeKeyAwareRepository.cs
index 089f487908..d320c65d0f 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/CompositeKeys/CarCompositeKeyAwareRepository.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/CompositeKeys/CarCompositeKeyAwareRepository.cs
@@ -39,11 +39,21 @@ private void RecursiveRewriteFilterInLayer(QueryLayer queryLayer)
if (queryLayer.Selection is { IsEmpty: false })
{
- foreach (QueryLayer? nextLayer in queryLayer.Selection.GetResourceTypes().Select(queryLayer.Selection.GetOrCreateSelectors)
- .SelectMany(selectors => selectors.Select(selector => selector.Value).Where(layer => layer != null)))
+ // @formatter:wrap_chained_method_calls chop_always
+ // @formatter:keep_existing_linebreaks true
+
+ foreach (QueryLayer? nextLayer in queryLayer.Selection
+ .GetResourceTypes()
+ .Select(queryLayer.Selection.GetOrCreateSelectors)
+ .SelectMany(selectors => selectors
+ .Select(selector => selector.Value)
+ .Where(layer => layer != null)))
{
RecursiveRewriteFilterInLayer(nextLayer!);
}
+
+ // @formatter:keep_existing_linebreaks restore
+ // @formatter:wrap_chained_method_calls restore
}
}
}
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/EagerLoading/Building.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/EagerLoading/Building.cs
index ea3805cb22..78ab514636 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/EagerLoading/Building.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/EagerLoading/Building.cs
@@ -14,12 +14,12 @@ public sealed class Building : Identifiable
[Attr]
public string Number { get; set; } = null!;
- [NotMapped]
[Attr]
+ [NotMapped]
public int WindowCount => Windows.Count;
- [NotMapped]
[Attr(Capabilities = AttrCapabilities.AllowView | AttrCapabilities.AllowChange)]
+ [NotMapped]
public string PrimaryDoorColor
{
get
@@ -50,8 +50,8 @@ public string PrimaryDoorColor
}
}
- [NotMapped]
[Attr(Capabilities = AttrCapabilities.AllowView)]
+ [NotMapped]
public string? SecondaryDoorColor => SecondaryDoor?.Color;
[EagerLoad]
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/EagerLoading/Street.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/EagerLoading/Street.cs
index db440ad85d..263bb6cfd4 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/EagerLoading/Street.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/EagerLoading/Street.cs
@@ -12,16 +12,16 @@ public sealed class Street : Identifiable
[Attr]
public string Name { get; set; } = null!;
- [NotMapped]
[Attr(Capabilities = AttrCapabilities.AllowView)]
+ [NotMapped]
public int BuildingCount => Buildings.Count;
- [NotMapped]
[Attr(Capabilities = AttrCapabilities.AllowView)]
+ [NotMapped]
public int DoorTotalCount => Buildings.Sum(building => building.SecondaryDoor == null ? 1 : 2);
- [NotMapped]
[Attr(Capabilities = AttrCapabilities.AllowView)]
+ [NotMapped]
public int WindowTotalCount => Buildings.Sum(building => building.WindowCount);
[EagerLoad]
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/Logging/Fruit.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/Logging/Fruit.cs
index fd0fbf0dfa..4e26c558ff 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/Logging/Fruit.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/Logging/Fruit.cs
@@ -10,4 +10,7 @@ public abstract class Fruit : Identifiable
{
[Attr]
public abstract string Color { get; }
+
+ [Attr]
+ public double WeightInKilograms { get; set; }
}
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/Logging/LoggingFakers.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/Logging/LoggingFakers.cs
index a66cdcdf55..aa34ff32f5 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/Logging/LoggingFakers.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/Logging/LoggingFakers.cs
@@ -15,10 +15,12 @@ internal sealed class LoggingFakers
private readonly Lazy> _lazyBananaFaker = new(() => new Faker()
.MakeDeterministic()
+ .RuleFor(banana => banana.WeightInKilograms, faker => faker.Random.Double(.2, .3))
.RuleFor(banana => banana.LengthInCentimeters, faker => faker.Random.Double(10, 25)));
private readonly Lazy> _lazyPeachFaker = new(() => new Faker()
.MakeDeterministic()
+ .RuleFor(peach => peach.WeightInKilograms, faker => faker.Random.Double(.2, .3))
.RuleFor(peach => peach.DiameterInCentimeters, faker => faker.Random.Double(6, 7.5)));
public Faker AuditEntry => _lazyAuditEntryFaker.Value;
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/Logging/LoggingTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/Logging/LoggingTests.cs
index 9fbd9e8051..4d35403f9e 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/Logging/LoggingTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/Logging/LoggingTests.cs
@@ -152,9 +152,9 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
responseDocument.Should().BeEmpty();
- IReadOnlyList logLines = loggerProvider.GetLines();
+ string[] traceLines = loggerProvider.GetMessages().Where(message => message.LogLevel == LogLevel.Trace).Select(message => message.ToString()).ToArray();
- logLines.Should().BeEquivalentTo(new[]
+ traceLines.Should().BeEquivalentTo(new[]
{
$$"""
[TRACE] Received POST request at 'http://localhost/fruitBowls/{{existingBowl.StringId}}/relationships/fruits' with body: <<{
@@ -215,6 +215,7 @@ [TRACE] Entering AddToToManyRelationshipAsync(leftResource: null, leftId: {{exis
{
"Color": "Yellow",
"LengthInCentimeters": {{existingBanana.LengthInCentimeters.ToString(CultureInfo.InvariantCulture)}},
+ "WeightInKilograms": {{existingBanana.WeightInKilograms.ToString(CultureInfo.InvariantCulture)}},
"Id": {{existingBanana.Id}},
"StringId": "{{existingBanana.StringId}}"
}
@@ -262,9 +263,9 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
responseDocument.Should().BeEmpty();
- IReadOnlyList logLines = loggerProvider.GetLines();
+ string[] traceLines = loggerProvider.GetMessages().Where(message => message.LogLevel == LogLevel.Trace).Select(message => message.ToString()).ToArray();
- logLines.Should().BeEquivalentTo(new[]
+ traceLines.Should().BeEquivalentTo(new[]
{
$$"""
[TRACE] Received POST request at 'http://localhost/fruitBowls/{{existingBowl.StringId}}/relationships/fruits' with body: <<{
@@ -281,6 +282,7 @@ [TRACE] Entering PostRelationshipAsync(id: {{existingBowl.StringId}}, relationsh
{
"Color": "Red/Yellow",
"DiameterInCentimeters": 0,
+ "WeightInKilograms": 0,
"Id": {{existingPeach.Id}},
"StringId": "{{existingPeach.StringId}}"
}
@@ -291,6 +293,7 @@ [TRACE] Entering AddToToManyRelationshipAsync(leftId: {{existingBowl.StringId}},
{
"Color": "Red/Yellow",
"DiameterInCentimeters": 0,
+ "WeightInKilograms": 0,
"Id": {{existingPeach.Id}},
"StringId": "{{existingPeach.StringId}}"
}
@@ -329,6 +332,7 @@ [TRACE] Entering AddToToManyRelationshipAsync(leftResource: null, leftId: {{exis
{
"Color": "Red/Yellow",
"DiameterInCentimeters": 0,
+ "WeightInKilograms": 0,
"Id": {{existingPeach.Id}},
"StringId": "{{existingPeach.StringId}}"
}
@@ -336,4 +340,94 @@ [TRACE] Entering AddToToManyRelationshipAsync(leftResource: null, leftId: {{exis
"""
}, options => options.Using(IgnoreLineEndingsComparer.Instance).WithStrictOrdering());
}
+
+ [Fact]
+ public async Task Logs_query_layer_and_expression_at_Debug_level()
+ {
+ // Arrange
+ var loggerProvider = _testContext.Factory.Services.GetRequiredService();
+ loggerProvider.Clear();
+
+ var bowl = new FruitBowl();
+ bowl.Fruits.Add(_fakers.Peach.GenerateOne());
+
+ await _testContext.RunOnDatabaseAsync(async dbContext =>
+ {
+ dbContext.FruitBowls.Add(bowl);
+ await dbContext.SaveChangesAsync();
+ });
+
+ string route = $"/fruitBowls/{bowl.StringId}/fruits?filter=greaterThan(weightInKilograms,'0.1')&fields[peaches]=color&sort=-id";
+
+ // Act
+ (HttpResponseMessage httpResponse, string responseDocument) = await _testContext.ExecuteGetAsync(route);
+
+ // Assert
+ httpResponse.ShouldHaveStatusCode(HttpStatusCode.OK);
+
+ responseDocument.Should().NotBeEmpty();
+
+ LogMessage queryLayerMessage = loggerProvider.GetMessages().Should()
+ .ContainSingle(message => message.LogLevel == LogLevel.Debug && message.Text.StartsWith("QueryLayer:", StringComparison.Ordinal)).Subject;
+
+ queryLayerMessage.Text.Should().Be($$"""
+ QueryLayer: QueryLayer
+ {
+ Include: fruits
+ Filter: equals(id,'{{bowl.StringId}}')
+ Selection
+ {
+ FieldSelectors
+ {
+ id
+ fruits: QueryLayer
+ {
+ Filter: greaterThan(weightInKilograms,'0.1')
+ Sort: -id
+ Pagination: Page number: 1, size: 10
+ Selection
+ {
+ FieldSelectors
+ {
+ color
+ id
+ }
+ }
+ }
+ }
+ }
+ }
+
+ """);
+
+ LogMessage expressionMessage = loggerProvider.GetMessages().Should().ContainSingle(message =>
+ message.LogLevel == LogLevel.Debug && message.Text.StartsWith("Expression tree:", StringComparison.Ordinal)).Subject;
+
+ expressionMessage.Text.Should().Be("""
+ Expression tree: [Microsoft.EntityFrameworkCore.Query.EntityQueryRootExpression]
+ .AsNoTrackingWithIdentityResolution()
+ .Include("Fruits")
+ .Where(fruitBowl => fruitBowl.Id == value)
+ .Select(
+ fruitBowl => new FruitBowl
+ {
+ Id = fruitBowl.Id,
+ Fruits = fruitBowl.Fruits
+ .Where(fruit => fruit.WeightInKilograms > value)
+ .OrderByDescending(fruit => fruit.Id)
+ .Take(value)
+ .Select(
+ fruit => (fruit.GetType() == value)
+ ? (Fruit)new Peach
+ {
+ Id = fruit.Id,
+ WeightInKilograms = fruit.WeightInKilograms,
+ DiameterInCentimeters = ((Peach)fruit).DiameterInCentimeters,
+ Id = fruit.Id
+ }
+ : fruit)
+ .ToHashSet()
+ })
+ """);
+ }
}
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/Meta/TopLevelCountTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/Meta/TopLevelCountTests.cs
index 5a72d4af80..aa4eb06598 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/Meta/TopLevelCountTests.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/Meta/TopLevelCountTests.cs
@@ -83,10 +83,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
public async Task Renders_resource_count_for_empty_collection()
{
// Arrange
- await _testContext.RunOnDatabaseAsync(async dbContext =>
- {
- await dbContext.ClearTableAsync();
- });
+ await _testContext.RunOnDatabaseAsync(async dbContext => await dbContext.ClearTableAsync());
const string route = "/supportTickets";
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/ReadWrite/WorkItem.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/ReadWrite/WorkItem.cs
index c722592e83..baf2da12cf 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/ReadWrite/WorkItem.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/ReadWrite/WorkItem.cs
@@ -18,8 +18,8 @@ public sealed class WorkItem : Identifiable
[Attr]
public WorkItemPriority Priority { get; set; }
- [NotMapped]
[Attr(Capabilities = AttrCapabilities.All & ~(AttrCapabilities.AllowCreate | AttrCapabilities.AllowChange))]
+ [NotMapped]
public bool IsImportant
{
get => Priority == WorkItemPriority.High;
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/ReadWrite/WorkItemGroup.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/ReadWrite/WorkItemGroup.cs
index 7f132c8994..b5b94258f2 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/ReadWrite/WorkItemGroup.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/ReadWrite/WorkItemGroup.cs
@@ -15,8 +15,8 @@ public sealed class WorkItemGroup : Identifiable
[Attr]
public bool IsPublic { get; set; }
- [NotMapped]
[Attr]
+ [NotMapped]
public bool IsDeprecated => !string.IsNullOrEmpty(Name) && Name.StartsWith("DEPRECATED:", StringComparison.OrdinalIgnoreCase);
[HasOne]
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/ResourceInheritance/Models/AlwaysMovingTandem.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/ResourceInheritance/Models/AlwaysMovingTandem.cs
index 590e053339..c90aad6ade 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/ResourceInheritance/Models/AlwaysMovingTandem.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/ResourceInheritance/Models/AlwaysMovingTandem.cs
@@ -9,8 +9,8 @@ namespace JsonApiDotNetCoreTests.IntegrationTests.ResourceInheritance.Models;
[Resource(ControllerNamespace = "JsonApiDotNetCoreTests.IntegrationTests.ResourceInheritance", GenerateControllerEndpoints = JsonApiEndpoints.None)]
public sealed class AlwaysMovingTandem : Bike
{
- [NotMapped]
[Attr]
+ [NotMapped]
public Guid LocationToken
{
get => Guid.NewGuid();
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/ZeroKeys/Game.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/ZeroKeys/Game.cs
index 55372d4b0f..a983c66d7b 100644
--- a/test/JsonApiDotNetCoreTests/IntegrationTests/ZeroKeys/Game.cs
+++ b/test/JsonApiDotNetCoreTests/IntegrationTests/ZeroKeys/Game.cs
@@ -13,8 +13,8 @@ public sealed class Game : Identifiable
[Attr]
public string Title { get; set; } = null!;
- [NotMapped]
[Attr]
+ [NotMapped]
public Guid SessionToken => Guid.NewGuid();
[HasOne]
diff --git a/test/JsonApiDotNetCoreTests/JsonApiDotNetCoreTests.csproj b/test/JsonApiDotNetCoreTests/JsonApiDotNetCoreTests.csproj
index 6bc5a666a1..bdfea682d9 100644
--- a/test/JsonApiDotNetCoreTests/JsonApiDotNetCoreTests.csproj
+++ b/test/JsonApiDotNetCoreTests/JsonApiDotNetCoreTests.csproj
@@ -12,6 +12,7 @@
+
diff --git a/test/JsonApiDotNetCoreTests/UnitTests/TypeConversion/CollectionConverterTests.cs b/test/JsonApiDotNetCoreTests/UnitTests/TypeConversion/CollectionConverterTests.cs
new file mode 100644
index 0000000000..1f679912ba
--- /dev/null
+++ b/test/JsonApiDotNetCoreTests/UnitTests/TypeConversion/CollectionConverterTests.cs
@@ -0,0 +1,104 @@
+using FluentAssertions;
+using JsonApiDotNetCore;
+using Xunit;
+
+namespace JsonApiDotNetCoreTests.UnitTests.TypeConversion;
+
+public sealed class CollectionConverterTests
+{
+ [Fact]
+ public void Finds_element_type_for_generic_list()
+ {
+ // Arrange
+ Type sourceType = typeof(List);
+
+ // Act
+ Type? elementType = CollectionConverter.Instance.FindCollectionElementType(sourceType);
+
+ // Assert
+ elementType.Should().Be();
+ }
+
+ [Fact]
+ public void Finds_element_type_for_generic_enumerable()
+ {
+ // Arrange
+ Type sourceType = typeof(IEnumerable);
+
+ // Act
+ Type? elementType = CollectionConverter.Instance.FindCollectionElementType(sourceType);
+
+ // Assert
+ elementType.Should().Be();
+ }
+
+ [Fact]
+ public void Finds_element_type_for_custom_generic_collection_with_multiple_type_parameters()
+ {
+ // Arrange
+ Type sourceType = typeof(CustomCollection);
+
+ // Act
+ Type? elementType = CollectionConverter.Instance.FindCollectionElementType(sourceType);
+
+ // Assert
+ elementType.Should().Be();
+ }
+
+ [Fact]
+ public void Finds_element_type_for_custom_non_generic_collection()
+ {
+ // Arrange
+ Type sourceType = typeof(CustomCollectionOfIntString);
+
+ // Act
+ Type? elementType = CollectionConverter.Instance.FindCollectionElementType(sourceType);
+
+ // Assert
+ elementType.Should().Be();
+ }
+
+ [Fact]
+ public void Finds_no_element_type_for_non_generic_type()
+ {
+ // Arrange
+ Type sourceType = typeof(int);
+
+ // Act
+ Type? elementType = CollectionConverter.Instance.FindCollectionElementType(sourceType);
+
+ // Assert
+ elementType.Should().BeNull();
+ }
+
+ [Fact]
+ public void Finds_no_element_type_for_non_collection_generic_type()
+ {
+ // Arrange
+ Type sourceType = typeof(Tuple);
+
+ // Act
+ Type? elementType = CollectionConverter.Instance.FindCollectionElementType(sourceType);
+
+ // Assert
+ elementType.Should().BeNull();
+ }
+
+ [Fact]
+ public void Finds_no_element_type_for_unbound_generic_type()
+ {
+ // Arrange
+ Type sourceType = typeof(List<>);
+
+ // Act
+ Type? elementType = CollectionConverter.Instance.FindCollectionElementType(sourceType);
+
+ // Assert
+ elementType.Should().BeNull();
+ }
+
+ // ReSharper disable once UnusedTypeParameter
+ private class CustomCollection : List;
+
+ private sealed class CustomCollectionOfIntString : CustomCollection;
+}
diff --git a/test/OpenApiTests/OpenApiGenerationFailures/IncorrectSetupOrder/RegistrationTests.cs b/test/OpenApiTests/OpenApiGenerationFailures/IncorrectSetupOrder/RegistrationTests.cs
new file mode 100644
index 0000000000..6033100080
--- /dev/null
+++ b/test/OpenApiTests/OpenApiGenerationFailures/IncorrectSetupOrder/RegistrationTests.cs
@@ -0,0 +1,24 @@
+using FluentAssertions;
+using JsonApiDotNetCore.Errors;
+using JsonApiDotNetCore.OpenApi.Swashbuckle;
+using Microsoft.Extensions.DependencyInjection;
+using Xunit;
+
+namespace OpenApiTests.OpenApiGenerationFailures.IncorrectSetupOrder;
+
+public sealed class RegistrationTests
+{
+ [Fact]
+ public void Fails_when_OpenAPI_registered_without_JsonApi()
+ {
+ // Arrange
+ var services = new ServiceCollection();
+
+ // Act
+ Action action = () => services.AddOpenApiForJsonApi();
+
+ // Arrange
+ action.Should().ThrowExactly()
+ .WithMessage("Call 'services.AddJsonApi()' before calling 'services.AddOpenApiForJsonApi()'.");
+ }
+}
diff --git a/test/OpenApiTests/OpenApiStartup.cs b/test/OpenApiTests/OpenApiStartup.cs
index ba0a5256ca..e8ee0fdb20 100644
--- a/test/OpenApiTests/OpenApiStartup.cs
+++ b/test/OpenApiTests/OpenApiStartup.cs
@@ -14,10 +14,7 @@ public class OpenApiStartup : TestableStartup
public override void ConfigureServices(IServiceCollection services)
{
base.ConfigureServices(services);
-
-#pragma warning disable JADNC_OA_001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
services.AddOpenApiForJsonApi(SetupSwaggerGenAction);
-#pragma warning restore JADNC_OA_001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
}
protected override void SetJsonApiOptions(JsonApiOptions options)
diff --git a/test/TestBuildingBlocks/ServiceCollectionExtensions.cs b/test/TestBuildingBlocks/ServiceCollectionExtensions.cs
index 8e5102fa23..886a5f0fb4 100644
--- a/test/TestBuildingBlocks/ServiceCollectionExtensions.cs
+++ b/test/TestBuildingBlocks/ServiceCollectionExtensions.cs
@@ -10,6 +10,7 @@ internal static class ServiceCollectionExtensions
public static void ReplaceControllers(this IServiceCollection services, TestControllerProvider provider)
{
ArgumentNullException.ThrowIfNull(services);
+ ArgumentNullException.ThrowIfNull(provider);
services.AddMvcCore().ConfigureApplicationPartManager(manager =>
{
pFad - Phonifier reborn
Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.
Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.
Alternative Proxies: