From 4ea810299a2660568c0b4bd31cfd8438ab65ce32 Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Sun, 16 Apr 2023 22:27:03 -0700 Subject: [PATCH] [Tests] `prop-types`: add failing tests for #3521 --- lib/rules/prop-types.js | 3 ++- tests/lib/rules/prop-types.js | 29 +++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 1 deletion(-) diff --git a/lib/rules/prop-types.js b/lib/rules/prop-types.js index bb317a2467..d899bdbe8f 100644 --- a/lib/rules/prop-types.js +++ b/lib/rules/prop-types.js @@ -154,7 +154,7 @@ module.exports = { while (node) { const component = components.get(node); - const isDeclared = component && component.confidence === 2 + const isDeclared = component && component.confidence >= 2 && internalIsDeclaredInComponent(component.declaredPropTypes || {}, names); if (isDeclared) { @@ -176,6 +176,7 @@ module.exports = { && !isIgnored(propType.allNames[0]) && !isDeclaredInComponent(component.node, propType.allNames) )); + undeclareds.forEach((propType) => { report(context, messages.missingPropType, 'missingPropType', { node: propType.node, diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js index e17d63661c..2340b97167 100644 --- a/tests/lib/rules/prop-types.js +++ b/tests/lib/rules/prop-types.js @@ -4138,6 +4138,35 @@ ruleTester.run('prop-types', rule, { }; `, features: ['ts', 'no-babel'], + }, + { + code: ` + import React, { forwardRef, memo } from 'react'; + + interface Props1 { + age: number; + } + const HelloTemp = forwardRef(({ age }: Props1) => { + return

Hello {age}

; + }); + export const Hello = memo(HelloTemp); + `, + features: ['types'], + }, + { + code: ` + import React, { forwardRef, memo } from 'react'; + + interface Props1 { + age: number; + } + export const Hello = memo( + forwardRef(({ age }: Props1) => { + return

Hello {age}

; + }), + ); + `, + features: ['types'], } )), pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies: