Skip to content

[WIP] test: add test to check that image/container override on IntegrationSource is not allowed #8616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] test: add test to check that image/container override on IntegrationSource is not allowed #8616

wants to merge 1 commit into from
+10 −1

Conversation

S-Mann
Copy link
Contributor

@S-Mann S-Mann commented Jul 3, 2025

Fixes #8609

Proposed Changes

  • Added test cases that will confirm that our source containers aren't modified

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Docs

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 3, 2025

Hi @S-Mann. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 3, 2025
@knative-prow knative-prow bot requested review from aliok and matzew July 3, 2025 22:51
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: S-Mann
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@S-Mann
Copy link
Contributor Author

S-Mann commented Jul 3, 2025

/cc @Cali0707

@knative-prow knative-prow bot requested a review from Cali0707 July 3, 2025 22:51
@S-Mann
Copy link
Contributor Author

S-Mann commented Jul 3, 2025

@Cali0707 I think the current test case in pkg/reconciler/integration/source/resources/containersource_test.go is already catching if the expected spec matches the generated one. So we are already covered?

@codecov Codecov
Copy link

codecov bot commented Jul 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.35%. Comparing base (50d5a26) to head (4ae1330).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8616      +/-   ##
==========================================
- Coverage   52.38%   52.35%   -0.03%     
==========================================
  Files         399      399              
  Lines       25076    25076              
==========================================
- Hits        13135    13129       -6     
- Misses      11141    11145       +4     
- Partials      800      802       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@S-Mann
⚗️ Trying to add a test case that checks if containers were modified
4ae1330 
Signed-off-by: S-Mann <29407727+S-Mann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliok aliok Awaiting requested review from aliok

@matzew matzew Awaiting requested review from matzew

@Cali0707 Cali0707 Awaiting requested review from Cali0707

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test to check that image/container override on IntegrationSource is not allowed
1 participant
@S-Mann
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy