Don't use regex to trim whitespace

kornelski · kornelski · commit 560b2d8ef452 · 2023-01-27T01:22:14.000Z
diff --git a/index.js b/index.js
@@ -80,10 +80,10 @@ function parseCacheControl(header) {
 
     // TODO: When there is more than one value present for a given directive (e.g., two Expires header fields, multiple Cache-Control: max-age directives),
     // the directive's value is considered invalid. Caches are encouraged to consider responses that have invalid freshness information to be stale
-    const parts = header.trim().split(/\s*,\s*/); // TODO: lame parsing
+    const parts = header.trim().split(/,/);
     for (const part of parts) {
-        const [k, v] = part.split(/\s*=\s*/, 2);
-        cc[k] = v === undefined ? true : v.replace(/^"|"$/g, ''); // TODO: lame unquoting
+        const [k, v] = part.split(/=/, 2);
+        cc[k.trim()] = v === undefined ? true : v.trim().replace(/^"|"$/g, '');
     }
 
     return cc;
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "http-cache-semantics",
-    "version": "4.1.0",
+    "version": "4.1.1",
     "description": "Parses Cache-Control and other headers. Helps building correct HTTP caches and proxies",
     "repository": "https://github.com/kornelski/http-cache-semantics.git",
     "main": "index.js",

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "http-cache-semantics",`
`3`		`- "version": "4.1.0",`
	`3`	`+ "version": "4.1.1",`
`4`	`4`	`"description": "Parses Cache-Control and other headers. Helps building correct HTTP caches and proxies",`
`5`	`5`	`"repository": "https://github.com/kornelski/http-cache-semantics.git",`
`6`	`6`	`"main": "index.js",`