Skip to content

codegen tool: resolves GOBIN via go env #132378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

codegen tool: resolves GOBIN via go env #132378

merged 1 commit into from
Jul 18, 2025
+24 −18

Conversation

bartoszmajsak
Copy link
Contributor

@bartoszmajsak bartoszmajsak commented Jun 18, 2025 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Using go env GOBIN to locate where codegen binaries should be installed provides a more reliable and flexible solution.

  • Picks up a user's custom GOBIN whether it's set as an environment variable or only in go env
  • Falls back to $GOPATH/bin if no GOBIN is defined

This handles setups (e.g. using tools like mise) where GOBIN is configured internally but not exported.

The old lookup missed those internally configured values and could fail if the binary isn't present in the assumed location (or worse invoke the wrong codegen binary :)).

Which issue(s) this PR is related to:

Fixes #132377

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 18, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @bartoszmajsak!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 18, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @bartoszmajsak. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 18, 2025
@k8s-ci-robot k8s-ci-robot requested review from sttts and wojtek-t June 18, 2025 19:34
@dims
Copy link
Member

dims commented Jun 20, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 20, 2025
BenTheElder
BenTheElder reviewed Jun 23, 2025
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

We expect GOBIN to be setup by kube::golang::setup_env, not sure why that isn't being used here

/assign @thockin

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2025
thockin
thockin reviewed Jun 24, 2025
View reviewed changes
@aaron-prindle
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 1, 2025
@thockin
Copy link
Member

thockin commented Jul 12, 2025

Ping this one before code freze

@bartoszmajsak bartoszmajsak mentioned this pull request Jul 13, 2025
Open
@bartoszmajsak @thockin
codegen tool: resolves GOBIN via go env
6462ad9 
Using `go env GOBIN` to locate where codegen binaries should be installed
provides a more reliable and flexible solution.

- Picks up a user's custom `GOBIN` whether it's set as an environment
  variable or only in `go env`
- Falls back to `$GOPATH/bin` if no `GOBIN` is defined

This handles setups (e.g. using tools like [`mise`](https://mise.jdx.dev/lang/go.html))
where `GOBIN` is configured internally but not exported.

The old lookup missed those internally-configured values and
could invoke the wrong codegen binary.

Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>

Co-authored-by: Tim Hockin <thockin@google.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 13, 2025
@thockin
Copy link
Member

thockin commented Jul 13, 2025

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7614b9710da31ccb174885d18d275f20c271e2f2

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bartoszmajsak, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2025
@bartoszmajsak
Copy link
Contributor Author

@thockin PR is blocked b/c of do-not-merge/hold label. Is there a reason for it?

@BenTheElder BenTheElder mentioned this pull request Jul 17, 2025
Closed
@thockin thockin removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit de66ad5 into kubernetes:master Jul 18, 2025
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jul 18, 2025
rushmash91 pushed a commit to rushmash91/kubernetes that referenced this pull request Jul 18, 2025
@k8s-ci-robot @rushmash91
Merge pull request kubernetes#132378 from bartoszmajsak/gobin-fix
7a01a79 
codegen tool: resolves GOBIN via `go env`
rushmash91 pushed a commit to rushmash91/kubernetes that referenced this pull request Jul 18, 2025
@k8s-ci-robot @rushmash91
Merge pull request kubernetes#132378 from bartoszmajsak/gobin-fix
6745761 
codegen tool: resolves GOBIN via `go env`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@thockin thockin thockin left review comments

@sttts sttts Awaiting requested review from sttts

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.

kube_codegen.sh does not resolve "local" GOBIN when invoking the tools
6 participants
@bartoszmajsak @k8s-ci-robot @dims @aaron-prindle @thockin @BenTheElder
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy