refactor extra/*/types keywords as max values #4474
Draft
+20
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, extra/atom/types, extra/bond/types, etc. keywords must match the exact number of types that will be added before the first run.
This refactor will make these keywords behave more like the extra/*/per/atom keywords, where arguments are simply max storage values.
This initial commit is meant to provide proof of concept and start conversation.
This PR will effectively enable adding new interactions on the fly, with applications in data-driven MD simulations.
Demo/Example:
refactor_extra-types_example.zip
Previous behavior: Error thrown because extra/atom/types keywords is very high
New behavior: Extra/atom/types is max storage, atom->ntypes calculated as actual types are added
TODO:
Related Issue(s)
Regression testing.
Author(s)
Jake
Licensing
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
Backward Compatibility
Yes
Implementation Notes
Post Submission Checklist
Further Information, Files, and Links