chore: fix acNf bug in bv_decide by switching over to grind #9309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug seems to be because
acNfUnnormalized
creates asimp
set that loops. I'll isolate an explanation of what's going on later.For now, we choose instead to justify our rewrites using
grind
. We will improve this to usegrind
's internalCommRing
solver, rather than all of the grind infrastructure.We make this change as we wish to implement more of bitwuzla's associativity/commutatitivy normalization, which rely on canonicalizing non-linear combinations (such as$$x (y + x) + x y \mapsto 2xy + x^2$$ ), which requires a theory solver at least as powerful as
ring
to justify.