tests: Replace C-style casts with static_cast<>

Fohlen · murraycu · commit 2131f6be0a8c · 2020-01-06T00:00:19.000+01:00
murrayc-tuple-utils Pull Request #4 .
diff --git a/tests/test_tuple_for_each.cc b/tests/test_tuple_for_each.cc
@@ -40,7 +40,7 @@ test_tuple_for_each_same_types()
   }
 
   {
-    auto t_original = std::make_tuple(1, (double)2.1f, 3);
+    auto t_original = std::make_tuple(1, static_cast<double>(2.1f), 3);
     sigc::internal::tuple_for_each<for_each_simple>(t_original);
   }
 }
@@ -60,7 +60,7 @@ void
 test_tuple_for_each_same_types_with_extras()
 {
   {
-    auto t_original = std::make_tuple(1, (double)2.1f, 3);
+    auto t_original = std::make_tuple(1, static_cast<double>(2.1f), 3);
     sigc::internal::tuple_for_each<for_each_simple_with_extras>(t_original, 89, "eightynine");
   }
 }
@@ -76,7 +76,7 @@ void
 test_tuple_for_each_same_types_with_nonconst_extras()
 {
   {
-    auto t_original = std::make_tuple(1, (double)2.1f, 3);
+    auto t_original = std::make_tuple(1, static_cast<double>(2.1f), 3);
     int extra = 0;
 
     sigc::internal::tuple_for_each<for_each_simple_with_nonconst_extras>(t_original, extra);
@@ -138,7 +138,7 @@ class visitor_with_specializations<const char*>
 void
 test_tuple_for_each_multiple_types()
 {
-  auto t_original = std::make_tuple(1, (double)2.1f, std::string("3"));
+  auto t_original = std::make_tuple(1, static_cast<double>(2.1f), std::string("3"));
   sigc::internal::tuple_for_each<visitor_with_specializations>(t_original);
 }
 
@@ -220,7 +220,7 @@ test_tuple_for_each_empty_tuple()
 constexpr void
 test_tuple_for_each_constexpr()
 {
-  constexpr auto t_original = std::make_tuple(1, (double)2.1f, "3");
+  constexpr auto t_original = std::make_tuple(1, static_cast<double>(2.1f), "3");
   sigc::internal::tuple_for_each<visitor_with_specializations>(t_original);
 }
 
diff --git a/tests/test_tuple_transform_each.cc b/tests/test_tuple_transform_each.cc
@@ -49,7 +49,7 @@ test_tuple_transform_each_same_types()
   }
 
   {
-    auto t_original = std::make_tuple(1, (double)2.1f, 3);
+    auto t_original = std::make_tuple(1, static_cast<double>(2.1f), 3);
     auto t_transformed = sigc::internal::tuple_transform_each<transform_to_string>(t_original);
     auto t_expected = std::make_tuple(std::string("1"), std::string("2"), std::string("3"));
 
@@ -99,7 +99,7 @@ class transform_to_something<std::string>
 void
 test_tuple_transform_each_multiple_types()
 {
-  auto t_original = std::make_tuple(1, (double)2.1f, std::string("3"));
+  auto t_original = std::make_tuple(1, static_cast<double>(2.1f), std::string("3"));
   auto t_transformed = sigc::internal::tuple_transform_each<transform_to_something>(t_original);
   auto t_expected = std::make_tuple(std::string("1"), '2', 3);
 
@@ -269,7 +269,7 @@ class transform_as_constexpr_to_something<const double>
 constexpr
 void
 test_tuple_transform_each_constexpr() {
-  constexpr auto t_original = std::make_tuple(1, (double)2.1f);
+  constexpr auto t_original = std::make_tuple(1, static_cast<double>(2.1f));
   constexpr auto t_transformed =
     sigc::internal::tuple_transform_each<transform_as_constexpr_to_something>(t_original);
   constexpr auto t_expected = std::make_tuple('b', 2);

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ test_tuple_for_each_same_types()`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`{`
`43`		`- auto t_original = std::make_tuple(1, (double)2.1f, 3);`
	`43`	`+ auto t_original = std::make_tuple(1, static_cast<double>(2.1f), 3);`
`44`	`44`	`sigc::internal::tuple_for_each<for_each_simple>(t_original);`
`45`	`45`	`}`
`46`	`46`	`}`
`@@ -60,7 +60,7 @@ void`
`60`	`60`	`test_tuple_for_each_same_types_with_extras()`
`61`	`61`	`{`
`62`	`62`	`{`
`63`		`- auto t_original = std::make_tuple(1, (double)2.1f, 3);`
	`63`	`+ auto t_original = std::make_tuple(1, static_cast<double>(2.1f), 3);`
`64`	`64`	`sigc::internal::tuple_for_each<for_each_simple_with_extras>(t_original, 89, "eightynine");`
`65`	`65`	`}`
`66`	`66`	`}`
`@@ -76,7 +76,7 @@ void`
`76`	`76`	`test_tuple_for_each_same_types_with_nonconst_extras()`
`77`	`77`	`{`
`78`	`78`	`{`
`79`		`- auto t_original = std::make_tuple(1, (double)2.1f, 3);`
	`79`	`+ auto t_original = std::make_tuple(1, static_cast<double>(2.1f), 3);`
`80`	`80`	`int extra = 0;`
`81`	`81`
`82`	`82`	`sigc::internal::tuple_for_each<for_each_simple_with_nonconst_extras>(t_original, extra);`
`@@ -138,7 +138,7 @@ class visitor_with_specializations<const char*>`
`138`	`138`	`void`
`139`	`139`	`test_tuple_for_each_multiple_types()`
`140`	`140`	`{`
`141`		`- auto t_original = std::make_tuple(1, (double)2.1f, std::string("3"));`
	`141`	`+ auto t_original = std::make_tuple(1, static_cast<double>(2.1f), std::string("3"));`
`142`	`142`	`sigc::internal::tuple_for_each<visitor_with_specializations>(t_original);`
`143`	`143`	`}`
`144`	`144`
`@@ -220,7 +220,7 @@ test_tuple_for_each_empty_tuple()`
`220`	`220`	`constexpr void`
`221`	`221`	`test_tuple_for_each_constexpr()`
`222`	`222`	`{`
`223`		`- constexpr auto t_original = std::make_tuple(1, (double)2.1f, "3");`
	`223`	`+ constexpr auto t_original = std::make_tuple(1, static_cast<double>(2.1f), "3");`
`224`	`224`	`sigc::internal::tuple_for_each<visitor_with_specializations>(t_original);`
`225`	`225`	`}`
`226`	`226`