Tests: Add comments by uses after move.

murraycu · murraycu · commit 4986e9056231 · 2017-07-21T08:40:06.000+02:00
Because we really do want to test this.
We do not explicitly promise that it's safe to use moved-from libsigc++
objects, but we choose to make it safe.
diff --git a/tests/test_signal_move.cc b/tests/test_signal_move.cc
@@ -35,14 +35,14 @@ main(int argc, char* argv[])
 
   // Test the move constructor:
   sigc::signal<int(int)> sig2(std::move(sig));
-  sig(-2);
+  sig(-2); // Test that the moved-from slot does nothing.
   sig2(2);
   util->check_result(result_stream, "foo(int 2)");
 
   // Test the move assignment operator:
   sigc::signal<int(int)> sig3;
   sig3 = std::move(sig2);
-  sig2(-3);
+  sig2(-3); // Test that the moved-from slot does nothing.
   sig3(3);
   util->check_result(result_stream, "foo(int 3)");
 
diff --git a/tests/test_slot_move.cc b/tests/test_slot_move.cc
@@ -43,14 +43,14 @@ main(int argc, char* argv[])
 
   // test move constructor:
   sigc::slot<void(int)> s2(std::move(s1));
-  s1(-2);
+  s1(-2); // Test that the moved-from slot does nothing.
   s2(2);
   util->check_result(result_stream, "foo(int 2)");
 
   // test move assignment:
   sigc::slot<void(int)> s3;
   s3 = std::move(s2);
-  s2(-3);
+  s2(-3); // Test that the moved-from slot does nothing.
   s3(3);
   util->check_result(result_stream, "foo(int 3)");
 
diff --git a/tests/test_trackable_move.cc b/tests/test_trackable_move.cc
@@ -23,11 +23,11 @@ class my_class : public sigc::trackable
     src.i = 0;
   }
 
-  my_class& operator=(my_class&& src)
+  my_class& operator=(my_class&& src) noexcept
   {
     sigc::trackable::operator=(std::move(src));
     i = std::move(src.i);
-    src.i = 0;
+    src.i = 0; // Make the moved-from object zeroed. Undefined behaviour would be acceptable too.
     return *this;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -23,11 +23,11 @@ class my_class : public sigc::trackable`
`23`	`23`	`src.i = 0;`
`24`	`24`	`}`
`25`	`25`
`26`		`- my_class& operator=(my_class&& src)`
	`26`	`+ my_class& operator=(my_class&& src) noexcept`
`27`	`27`	`{`
`28`	`28`	`sigc::trackable::operator=(std::move(src));`
`29`	`29`	`i = std::move(src.i);`
`30`		`- src.i = 0;`
	`30`	`+ src.i = 0; // Make the moved-from object zeroed. Undefined behaviour would be acceptable too.`
`31`	`31`	`return *this;`
`32`	`32`	`}`
`33`	`33`