MSVC build: Add code comments

studoot · murraycu · commit 858e3daca271 · 2019-10-25T12:57:31.000+02:00
diff --git a/sigc++/tuple-utils/tuple_end.h b/sigc++/tuple-utils/tuple_end.h
@@ -56,6 +56,7 @@ tuple_end(T&& t) {
   static_assert(len <= size, "The tuple size must be less than or equal to the length.");
 
   if constexpr(len == 0) {
+    // Prevent 'unreferenced formal parameter' warning from MSVC by 'using' t
     static_cast<void>(t);
     // Recursive calls to tuple_cdr() would result in this eventually,
     // but this avoids the extra work:
diff --git a/sigc++/tuple-utils/tuple_for_each.h b/sigc++/tuple-utils/tuple_for_each.h
@@ -104,6 +104,7 @@ tuple_for_each(T&& t, T_extras&&... extras)
     detail::tuple_for_each_impl<T_visitor, size, T_extras...>::tuple_for_each(
       std::forward<T>(t), std::forward<T_extras>(extras)...);
   } else {
+    // Prevent 'unreferenced formal parameter' warning from MSVC by 'using' t
     static_cast<void>(t);
   }
 }
diff --git a/sigc++/tuple-utils/tuple_transform_each.h b/sigc++/tuple-utils/tuple_transform_each.h
@@ -35,6 +35,8 @@ struct tuple_transform_each_impl {
   static decltype(auto)
   tuple_transform_each(T_current&& t, T_original& t_original) {
     if constexpr(size_from_index == 0) {
+    // Prevent 'unreferenced formal parameter' warning from MSVC by 'using'
+    // t_original
       static_cast<void>(t_original);
       //Do nothing because the tuple has no elements.
       return std::forward<T_current>(t);
diff --git a/sigc++/visit_each.h b/sigc++/visit_each.h
@@ -48,6 +48,7 @@ struct limit_trackable_target
     if constexpr(is_base_of_or_same_v<sigc::trackable, T_type>) {
         std::invoke(action_, type);
     } else {
+    // Prevent 'unreferenced formal parameter' warning from MSVC by 'using' type
       static_cast<void>(type);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -104,6 +104,7 @@ tuple_for_each(T&& t, T_extras&&... extras)`
`104`	`104`	`detail::tuple_for_each_impl<T_visitor, size, T_extras...>::tuple_for_each(`
`105`	`105`	`std::forward<T>(t), std::forward<T_extras>(extras)...);`
`106`	`106`	`} else {`
	`107`	`+ // Prevent 'unreferenced formal parameter' warning from MSVC by 'using' t`
`107`	`108`	`static_cast<void>(t);`
`108`	`109`	`}`
`109`	`110`	`}`
Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,7 @@ struct limit_trackable_target`
`48`	`48`	`if constexpr(is_base_of_or_same_v<sigc::trackable, T_type>) {`
`49`	`49`	`std::invoke(action_, type);`
`50`	`50`	`} else {`
	`51`	`+ // Prevent 'unreferenced formal parameter' warning from MSVC by 'using' type`
`51`	`52`	`static_cast<void>(type);`
`52`	`53`	`}`
`53`	`54`	`}`