Skip to content

Commit a1df5b6

Browse files
authored
Bump the node dependencies (#2389)
Signed-off-by: grampelberg <thomas@saunter.org>
1 parent 8c4d49d commit a1df5b6

File tree

7 files changed

+3007
-17
lines changed

7 files changed

+3007
-17
lines changed

.circleci/config.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,11 @@ jobs:
5757
name: Install Node.js
5858
command: |
5959
set -x
60-
if [ ! -f node-v6.10.2-linux-x64.tar.xz ]; then
61-
curl -sLO https://nodejs.org/dist/v6.10.2/node-v6.10.2-linux-x64.tar.xz
60+
if [ ! -f node-v14.2.0-linux-x64.tar.xz ]; then
61+
curl -sLO https://nodejs.org/dist/v14.2.0/node-v14.2.0-linux-x64.tar.xz
6262
fi
63-
tar -xf node-v6.10.2-linux-x64.tar.xz
64-
cp -a node-v6.10.2-linux-x64/* /usr/
63+
tar -xf node-v14.2.0-linux-x64.tar.xz
64+
cp -a node-v14.2.0-linux-x64/* /usr/
6565
6666
# Run ./sbt update, optionally run ./ci/twitter-develop.sh if
6767
# $TWITTER_DEVELOP is set. Dependencies may already be in cache.
@@ -103,7 +103,7 @@ jobs:
103103
key: linkerd-{{ checksum "/tmp/project-seed.txt" }}
104104
paths:
105105
- "docker-17.03.0-ce.tgz"
106-
- "node-v6.10.2-linux-x64.tar.xz"
106+
- "node-v14.2.0-linux-x64.tar.xz"
107107
- "~/.gitshas"
108108
- "~/.ivy2"
109109
- "~/.sbt"

admin/src/main/resources/io/buoyant/admin/js/spec/BarChartSpec.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,18 +63,22 @@ define([
6363
it("updates the bar's color when new data is added", function() {
6464
lbBarChart.update(generateData(21, 30));
6565
var $barContainer = getBarContainer($lbContainer);
66+
6667
expect($barContainer.attr('class')).toContain("green");
6768

6869
lbBarChart.update(generateData(19, 30));
6970
$barContainer = getBarContainer($lbContainer);
71+
7072
expect($barContainer.attr('class')).toContain("orange");
7173

7274
lbBarChart.update(generateData(6, 30));
7375
$barContainer = getBarContainer($lbContainer);
76+
7477
expect($barContainer.attr('class')).toContain("red");
7578

7679
lbBarChart.update(generateData(40, 30));
7780
$barContainer = getBarContainer($lbContainer);
81+
7882
expect($barContainer.attr('class')).toContain("green");
7983
});
8084

admin/src/main/resources/io/buoyant/admin/js/spec/RouterClientsSpec.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,7 @@ define([
192192
_.each(clientContainers, function(clientContainer) {
193193
expect($(clientContainer).hasClass("hidden")).toBe(false);
194194
});
195+
195196
expect(clientContainers.length).toBe(3);
196197

197198
realCollector.__update__(expiredMetricsJson);
@@ -239,6 +240,7 @@ define([
239240

240241
clientContainers = $clientsEl.find(".client-container");
241242
contentContainers = $clientsEl.find(".client-content-container");
243+
242244
expect(clientContainers.length).toBe(9);
243245
expect(contentContainers.length).toBe(9);
244246

@@ -286,6 +288,7 @@ define([
286288

287289
clientContainers = $clientsEl.find(".client-container");
288290
contentContainers = $clientsEl.find(".client-content-container");
291+
289292
expect(clientContainers.length).toBe(9);
290293
expect(contentContainers.length).toBe(9);
291294

admin/src/main/resources/io/buoyant/admin/js/spec/UtilsSpec.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,9 +138,11 @@ define(['jQuery', 'src/utils'], function($, Utils) {
138138

139139
it("adds metrics to track", function() {
140140
chart.setMetrics([{ name: "successRate" }]);
141+
141142
expect(chart.metrics).toEqual(["successRate"]);
142143

143144
chart.addMetrics([{ name: "failureRate" }]);
145+
144146
expect(chart.metrics).toEqual(["successRate", "failureRate"]);
145147
});
146148

@@ -153,13 +155,15 @@ define(['jQuery', 'src/utils'], function($, Utils) {
153155
expect(chart.metrics).toEqual(["successRate"]);
154156

155157
chart.updateMetrics([{name: "successRate", delta: 999}]);
158+
156159
expect(chart.tsMap.successRate.data[0][1]).toBe(999);
157160
});
158161

159162
it("updates timeseries options", function() {
160163
expect(chart.tsOpts("foo").strokeStyle).toBe("black");
161164
var timeseriesParams = function(_name) { return { strokeStyle: "white" }; }
162165
chart.updateTsOpts(timeseriesParams);
166+
163167
expect(chart.tsOpts("foo").strokeStyle).toBe("white");
164168
});
165169
});

admin/src/main/resources/io/buoyant/admin/js/src/router_clients.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ define([
1919
var clientContainerTemplate = templates.router_client_container;
2020
var rateMetricPartial = templates["rate_metric.partial"];
2121
var EXPAND_CLIENT_THRESHOLD = 6;
22-
var TRANSFORMER_RE = /(\/%\/[^\$#]*)?(\/[\$#]\/.*)/;
22+
var TRANSFORMER_RE = /(\/%\/[^$#]*)?(\/[$#]\/.*)/;
2323
var activeClients = {};
2424

2525
/*

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy