Merge pull request #274 from magento-gl/AC-14517-v1

sidolov · web-flow · commit 159cb6b966e7 · 2025-06-09T09:09:34.000-05:00
AC-14517 Investigate "use strict" is unnecessary inside of modules
diff --git a/composer.json b/composer.json
@@ -6,7 +6,7 @@
         "AFL-3.0"
     ],
     "type": "phpcodesniffer-standard",
-    "version": "37",
+    "version": "38",
     "require": {
         "php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
         "webonyx/graphql-php": "^15.0",
diff --git a/composer.lock b/composer.lock
diff --git a/eslint/eslint.config.mjs b/eslint/eslint.config.mjs
@@ -20,14 +20,25 @@ const compat = new FlatCompat({
     recommendedConfig: js.configs.recommended,
     allConfig: js.configs.all
 });
-export default defineConfig([{
-    extends: compat.extends(
-        "./.eslintrc-reset", // Resets all rules before applying custom ones
-        "./.eslintrc-magento", // Magento-specific coding standards
-        "./.eslintrc-jquery", // jQuery-related ESLint Rules
-        "./.eslintrc-misc", // Miscellaneous Rules
-    ),
-    plugins: {
-        "magento-coding-standard-eslint-plugin": magentoCodingStandardEslintPlugin,  // This is in flat config format (object)
+export default defineConfig([
+    {
+        extends: compat.extends(
+            "./.eslintrc-reset", // Resets all rules before applying custom ones
+            "./.eslintrc-magento", // Magento-specific coding standards
+            "./.eslintrc-jquery", // jQuery-related ESLint Rules
+            "./.eslintrc-misc", // Miscellaneous Rules
+        ),
+        plugins: {
+            "magento-coding-standard-eslint-plugin": magentoCodingStandardEslintPlugin,  // This is in flat config format (object)
+        }
+    },
+    {
+        ignores: ['**/eslint/rules/*.js'],
+        languageOptions: {
+            sourceType: "script"  // ensures non-module (classic script) parsing
+        },
+        rules: {
+            strict: ["error", "function"]  // enforces "use strict" inside functions
+        }
     }
-}]);
+]);
