Fix multi-file usage

sandersn · sandersn · commit e466bb94c173 · 2020-05-22T09:06:05.000-07:00
1. Follow aliases with getSupers.
2. Make fix in file with superclass, not with the error.
diff --git a/src/services/codefixes/fixPropertyOverrideAccessor.ts b/src/services/codefixes/fixPropertyOverrideAccessor.ts
@@ -47,6 +47,7 @@ namespace ts.codefix {
 
             startPosition = baseProp.valueDeclaration.pos;
             endPosition = baseProp.valueDeclaration.end;
+            file = getSourceFileOfNode(baseProp.valueDeclaration);
         }
         else {
             Debug.fail("fixPropertyOverrideAccessor codefix got unexpected error code " + code);
diff --git a/src/services/codefixes/generateAccessors.ts b/src/services/codefixes/generateAccessors.ts
@@ -229,8 +229,11 @@ namespace ts.codefix {
         while (decl) {
             const superElement = getClassExtendsHeritageElement(decl);
             const superSymbol = superElement && checker.getSymbolAtLocation(superElement.expression);
-            const superDecl = superSymbol && find(superSymbol.declarations, isClassLike);
-            if (superDecl) { res.push(superDecl); }
+            if (!superSymbol) break;
+            const symbol = superSymbol.flags & SymbolFlags.Alias ? checker.getAliasedSymbol(superSymbol) : superSymbol;
+            const superDecl = find(symbol.declarations, isClassLike);
+            if (!superDecl) break;
+            res.push(superDecl);
             decl = superDecl;
         }
         return res;
diff --git a/tests/cases/fourslash/codeFixPropertyOverrideAccess3.ts b/tests/cases/fourslash/codeFixPropertyOverrideAccess3.ts
@@ -0,0 +1,28 @@
+/// <reference path='fourslash.ts' />
+
+// @strict: true
+
+// @Filename: foo.ts
+//// import { A } from './source'
+//// class B extends A {
+////     get x() { return 2 }
+//// }
+// @Filename: source.ts
+//// export class A {
+////     x = 1
+//// }
+
+verify.codeFix({
+    description: `Generate 'get' and 'set' accessors`,
+    newFileContent: {
+        '/tests/cases/fourslash/source.ts': `export class A {
+    private _x = 1;
+    public get x() {
+        return this._x;
+    }
+    public set x(value) {
+        this._x = value;
+    }
+}`},
+    index: 0
+})

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,7 @@ namespace ts.codefix {`
`47`	`47`
`48`	`48`	`startPosition = baseProp.valueDeclaration.pos;`
`49`	`49`	`endPosition = baseProp.valueDeclaration.end;`
	`50`	`+ file = getSourceFileOfNode(baseProp.valueDeclaration);`
`50`	`51`	`}`
`51`	`52`	`else {`
`52`	`53`	`Debug.fail("fixPropertyOverrideAccessor codefix got unexpected error code " + code);`