Skip to content

TSServer 'references' only Works if Target Location is in property name  #13309

@mjbvz

Description

@mjbvz

Needed for microsoft/vscode#18205

TypeScript Version: 2.2.0-dev.20170104

class Foo {
    public abc;
}

var foo = new Foo()
foo.abc = 10

I'm trying to execute a references request against the TSServer for the property abc. Currently, this only works if the target location is somewhere within the string abc. I believe the references command should work if the target location is anywhere inside of public abc instead.

This blocks adopting a references code lens provider in VSCode. The problem is that when determining which symbols in the document we want to have show reference counts for, the navtree request for the document returns abc with the entire public abc span. This span does not work with the references request that we later fire off.

Metadata

Metadata

Assignees

Labels

BugA bug in TypeScriptDomain: Symbol NavigationRelates to go-to-definition, find-all-references, highlighting/occurrences.VS Code PriorityCritical issues that VS Code needs fixed in the current TypeScript milestoneVS Code TrackedThere is a VS Code equivalent to this issue

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions

    pFad - Phonifier reborn

    Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

    Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


    Alternative Proxies:

    Alternative Proxy

    pFad Proxy

    pFad v3 Proxy

    pFad v4 Proxy