WL#11226: Clear all compile warnings -- post push fixes

rsomla1 · rsomla1 · commit de988dba9467 · 2025-03-18T13:12:03.000+01:00
diff --git a/cdk/CMakeLists.txt b/cdk/CMakeLists.txt
@@ -28,9 +28,9 @@
 
 
 
-CMAKE_MINIMUM_REQUIRED(VERSION 3.8)
+CMAKE_MINIMUM_REQUIRED(VERSION 3.15)
 
-cmake_policy(VERSION 3.0)
+cmake_policy(VERSION 3.15)
 
 if(POLICY CMP0022)
   cmake_policy(SET CMP0022 NEW)  # consistently use INTERFACE_LINK_LIBRARIES property
diff --git a/common/CMakeLists.txt b/common/CMakeLists.txt
@@ -29,20 +29,33 @@
 
 file(GLOB HEADERS *.h)
 
+#TODO: Remove -Wno-delete-non-abstract-non-virtual-dtor when bumping ABI and
+#      adding virtual destructor for DbDoc, Value and Column_detail
+
+if(CLANG)
+
+set_compiler_flag(-Wno-delete-non-abstract-non-virtual-dtor)
+
+  # Note: GCC/clang and MSVC compilers have different rules for resolving
+  # relative paths in #include "..." directives [1]. The clang-cl compiler
+  # understands both conventions but gives warning when using MSVC rules. Since
+  # headers included by this code trigger the warning we disable it here (this
+  # is about version_info.h included from nysqlx/common_constants.h)
+  #
+  # [1] https://stackoverflow.com/questions/48538707/include-search-paths-from-included-header-varies-for-different-compilers
+
+  set_compiler_flag(-Wno-microsoft-include)
+
+endif()
+
+
 add_library(common STATIC
   session.cc result.cc collection.cc value.cc
   ${HEADERS}
 )
 
 target_link_libraries(common cdk)
 
-#TODO: Remove -Wno-delete-non-abstract-non-virtual-dtor when bumping ABI and
-  #      adding virtual destructor for DbDoc, Value and Column_detail
-if(CLANG)
-  target_compile_options(common PRIVATE
-    -Wno-delete-non-abstract-non-virtual-dtor
-  )
-endif()
 
 #
 # Note: generated version_info.h is placed in the build location
diff --git a/include/mysqlx/common_constants.h b/include/mysqlx/common_constants.h
@@ -31,7 +31,7 @@
 #ifndef MYSQL_COMMON_CONSTANTS_H
 #define MYSQL_COMMON_CONSTANTS_H
 
-#include <version_info.h>
+#include "version_info.h"
 
 #define DEFAULT_MYSQL_PORT  3306
 #define DEFAULT_MYSQLX_PORT 33060
