fixes #21975; Pragma block disabling warning has effect beyond block (#24934)

ringabout · web-flow · commit 433b725cbb65 · 2025-05-06T09:46:18.000+02:00
fixes #21975
diff --git a/compiler/semstmts.nim b/compiler/semstmts.nim
@@ -2821,9 +2821,24 @@ proc recursiveSetFlag(n: PNode, flag: TNodeFlag) =
     for i in 0..<n.safeLen: recursiveSetFlag(n[i], flag)
     incl(n.flags, flag)
 
+proc enterPragmaBlock(c: PContext): POptionEntry =
+  result = POptionEntry(options: c.config.options,
+    notes: c.config.notes,
+    warningAsErrors: c.config.warningAsErrors,
+    features: c.features)
+
+proc leavePragmaBlock(c: PContext, p: POptionEntry) =
+  c.config.options = p.options
+  c.config.notes = p.notes
+  c.config.warningAsErrors = p.warningAsErrors
+  c.features = p.features
+
 proc semPragmaBlock(c: PContext, n: PNode; expectedType: PType = nil): PNode =
   checkSonsLen(n, 2, c.config)
   let pragmaList = n[0]
+
+  let oldOptionEntry = enterPragmaBlock(c)
+
   pragma(c, nil, pragmaList, exprPragmas, isStatement = true)
 
   var inUncheckedAssignSection = 0
@@ -2848,6 +2863,8 @@ proc semPragmaBlock(c: PContext, n: PNode; expectedType: PType = nil): PNode =
     of wNoRewrite: recursiveSetFlag(result, nfNoRewrite)
     else: discard
 
+  leavePragmaBlock(c, oldOptionEntry)
+
 proc semStaticStmt(c: PContext, n: PNode): PNode =
   #echo "semStaticStmt"
   #writeStackTrace()
diff --git a/tests/pragmas/tpragmablock.nim b/tests/pragmas/tpragmablock.nim
@@ -0,0 +1,11 @@
+discard """
+  matrix: "--warningaserror:BareExcept"
+"""
+
+{.warning[BareExcept]:on.}:
+  discard
+
+try:
+  echo "Y"
+except:  # warning disabled here
+  discard
