Skip to content

Commit 02cb0c5

Browse files
committed
doc: ensure to revert node_version changes
PR-URL: #44760 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
1 parent 8934feb commit 02cb0c5

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

doc/contributing/releases.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -705,13 +705,17 @@ $ git pull upstream main
705705
$ git cherry-pick v1.x^
706706
```
707707

708-
Git should stop to let you fix conflicts. Revert all changes that were made to
709-
`src/node_version.h`:
708+
Git should stop to let you fix conflicts.
709+
710+
Revert all changes that were made to `src/node_version.h`:
710711

711712
```console
712713
$ git checkout --ours HEAD -- src/node_version.h
713714
```
714715

716+
Even if there are no conflicts, ensure that you revert all the changes that were
717+
made to `src/node_version.h`.
718+
715719
If there are conflicts in `doc` due to updated `REPLACEME`
716720
placeholders (that happens when a change previously landed on another release
717721
branch), keep both version numbers. Convert the YAML field to an array if it is

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy