test: make the vm timeout escape tests more lenient

joyeecheung · RafaelGSS · commit 0af15c71fbde · 2022-09-07T09:20:51.000-03:00
Previously the tests required that Node.js finish the initialization of the watchdog thread and fires the timeout within 100ms, which can be difficult on certain systems under load. This patch relaxes the requirement to 2000ms. If there is a bug and the timeout can actually be escaped, raising the timeout to 2000ms would not make a difference anyway. PR-URL: #44433 Refs: nodejs/reliability#333 Refs: nodejs/reliability#361 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
diff --git a/test/parallel/test-vm-timeout-escape-promise-2.js b/test/parallel/test-vm-timeout-escape-promise-2.js
@@ -16,7 +16,7 @@ function loop() {
   while (1) {
     const current = hrtime();
     const span = (current - start) / NS_PER_MS;
-    if (span >= 100n) {
+    if (span >= 2000n) {
       throw new Error(
         `escaped timeout at ${span} milliseconds!`);
     }
diff --git a/test/parallel/test-vm-timeout-escape-promise-module.js b/test/parallel/test-vm-timeout-escape-promise-module.js
@@ -18,7 +18,7 @@ function loop() {
   while (1) {
     const current = hrtime();
     const span = (current - start) / NS_PER_MS;
-    if (span >= 100n) {
+    if (span >= 2000n) {
       throw new Error(
         `escaped timeout at ${span} milliseconds!`);
     }
diff --git a/test/parallel/test-vm-timeout-escape-promise.js b/test/parallel/test-vm-timeout-escape-promise.js
@@ -17,7 +17,7 @@ function loop() {
   while (1) {
     const current = hrtime();
     const span = (current - start) / NS_PER_MS;
-    if (span >= 100n) {
+    if (span >= 2000n) {
       throw new Error(
         `escaped timeout at ${span} milliseconds!`);
     }

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ function loop() {`
`16`	`16`	`while (1) {`
`17`	`17`	`const current = hrtime();`
`18`	`18`	`const span = (current - start) / NS_PER_MS;`
`19`		`- if (span >= 100n) {`
	`19`	`+ if (span >= 2000n) {`
`20`	`20`	`throw new Error(`
`21`	`21`	`escaped timeout at ${span} milliseconds!`);
`22`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ function loop() {`
`18`	`18`	`while (1) {`
`19`	`19`	`const current = hrtime();`
`20`	`20`	`const span = (current - start) / NS_PER_MS;`
`21`		`- if (span >= 100n) {`
	`21`	`+ if (span >= 2000n) {`
`22`	`22`	`throw new Error(`
`23`	`23`	`escaped timeout at ${span} milliseconds!`);
`24`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ function loop() {`
`17`	`17`	`while (1) {`
`18`	`18`	`const current = hrtime();`
`19`	`19`	`const span = (current - start) / NS_PER_MS;`
`20`		`- if (span >= 100n) {`
	`20`	`+ if (span >= 2000n) {`
`21`	`21`	`throw new Error(`
`22`	`22`	`escaped timeout at ${span} milliseconds!`);
`23`	`23`	`}`