crypto: forbid passing Float16Array to getRandomValues()

LiviaMedeiros · RafaelGSS · commit 0f55a96e9c36 · 2025-05-02T17:06:29.000-03:00
PR-URL: #57880 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
diff --git a/lib/internal/crypto/random.js b/lib/internal/crypto/random.js
@@ -57,6 +57,7 @@ const {
   isArrayBufferView,
   isAnyArrayBuffer,
   isTypedArray,
+  isFloat16Array,
   isFloat32Array,
   isFloat64Array,
 } = require('internal/util/types');
@@ -315,6 +316,7 @@ function onJobDone(buf, callback, error) {
 // be an integer-type TypedArray.
 function getRandomValues(data) {
   if (!isTypedArray(data) ||
+      isFloat16Array(data) ||
       isFloat32Array(data) ||
       isFloat64Array(data)) {
     // Ordinarily this would be an ERR_INVALID_ARG_TYPE. However,
diff --git a/test/wpt/status/WebCryptoAPI.cjs b/test/wpt/status/WebCryptoAPI.cjs
@@ -11,14 +11,6 @@ module.exports = {
   'historical.any.js': {
     'skip': 'Not relevant in Node.js context',
   },
-  'getRandomValues.any.js': {
-    'fail': {
-      'note': 'Node.js does not support Float16Array',
-      'expected': [
-        'Float16 arrays',
-      ],
-    },
-  },
   'sign_verify/eddsa_small_order_points.https.any.js': {
     'fail': {
       'note': 'see https://github.com/nodejs/node/issues/54572',
diff --git a/test/wpt/test-webcrypto.js b/test/wpt/test-webcrypto.js
@@ -1,3 +1,5 @@
+// Flags: --js-float16array
+// TODO(LiviaMedeiros): once `Float16Array` is unflagged in v8, remove the line above
 'use strict';
 
 const common = require('../common');

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+// Flags: --js-float16array`
	`2`	+// TODO(LiviaMedeiros): once `Float16Array` is unflagged in v8, remove the line above
`1`	`3`	`'use strict';`
`2`	`4`
`3`	`5`	`const common = require('../common');`