Skip to content

Commit 12f4124

Browse files
tniessenRafaelGSS
authored andcommitted
Revert "test: add tests for REPL custom evals"
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures. PR-URL: #57793 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
1 parent 0509866 commit 12f4124

File tree

3 files changed

+34
-135
lines changed

3 files changed

+34
-135
lines changed

lib/repl.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -302,6 +302,7 @@ function REPLServer(prompt,
302302
options.useColors = shouldColorize(options.output);
303303
}
304304

305+
// TODO(devsnek): Add a test case for custom eval functions.
305306
const preview = options.terminal &&
306307
(options.preview !== undefined ? !!options.preview : !eval_);
307308

test/parallel/test-repl-custom-eval.js

Lines changed: 0 additions & 135 deletions
This file was deleted.

test/parallel/test-repl-eval.js

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
'use strict';
2+
const common = require('../common');
3+
const assert = require('assert');
4+
const repl = require('repl');
5+
6+
{
7+
let evalCalledWithExpectedArgs = false;
8+
9+
const options = {
10+
eval: common.mustCall((cmd, context) => {
11+
// Assertions here will not cause the test to exit with an error code
12+
// so set a boolean that is checked later instead.
13+
evalCalledWithExpectedArgs = (cmd === 'function f() {}\n' &&
14+
context.foo === 'bar');
15+
})
16+
};
17+
18+
const r = repl.start(options);
19+
r.context = { foo: 'bar' };
20+
21+
try {
22+
// Default preprocessor transforms
23+
// function f() {} to
24+
// var f = function f() {}
25+
// Test to ensure that original input is preserved.
26+
// Reference: https://github.com/nodejs/node/issues/9743
27+
r.write('function f() {}\n');
28+
} finally {
29+
r.write('.exit\n');
30+
}
31+
32+
assert(evalCalledWithExpectedArgs);
33+
}

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy