http: do not leak error listeners

ShogunPanda · danielleadams · commit 3af44c6cb60c · 2022-08-08T16:16:16.000-04:00
PR-URL: #43587 Fixes: #43548 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
diff --git a/lib/_http_server.js b/lib/_http_server.js
@@ -766,7 +766,10 @@ const requestHeaderFieldsTooLargeResponse = Buffer.from(
 function socketOnError(e) {
   // Ignore further errors
   this.removeListener('error', socketOnError);
-  this.on('error', noop);
+
+  if (this.listenerCount('error') === 0) {
+    this.on('error', noop);
+  }
 
   if (!this.server.emit('clientError', e, this)) {
     if (this.writable && this.bytesWritten === 0) {
diff --git a/test/parallel/test-http-socket-listeners.js b/test/parallel/test-http-socket-listeners.js
@@ -0,0 +1,44 @@
+'use strict';
+
+const common = require('../common');
+const assert = require('assert');
+const http = require('http');
+const net = require('net');
+
+// This test sends an invalid character to a HTTP server and purposely
+// does not handle clientError (even if it sets an event handler).
+//
+// The idea is to let the server emit multiple errors on the socket,
+// mostly due to parsing error, and make sure they don't result
+// in leaking event listeners.
+
+let i = 0;
+let socket;
+
+process.on('warning', common.mustNotCall());
+
+const server = http.createServer(common.mustNotCall());
+
+server.on('clientError', common.mustCallAtLeast((err) => {
+  assert.strictEqual(err.code, 'HPE_INVALID_METHOD');
+  assert.strictEqual(err.rawPacket.toString(), '*');
+
+  if (i === 20) {
+    socket.end();
+  } else {
+    socket.write('*');
+    i++;
+  }
+}, 1));
+
+server.listen(0, () => {
+  socket = net.createConnection({ port: server.address().port });
+
+  socket.on('connect', () => {
+    socket.write('*');
+  });
+
+  socket.on('close', () => {
+    server.close();
+  });
+});
