Skip to content

Commit 52f1f7e

Browse files
MGorkovmarco-ippolito
authored andcommitted
child_process: fix parsing messages with splitted length field
Fixes: #55834 PR-URL: #56106 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent aba280c commit 52f1f7e

File tree

2 files changed

+30
-1
lines changed

2 files changed

+30
-1
lines changed

lib/internal/child_process/serialization.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,12 @@ const advanced = {
6161
*parseChannelMessages(channel, readData) {
6262
if (readData.length === 0) return;
6363

64-
ArrayPrototypePush(channel[kMessageBuffer], readData);
64+
if (channel[kMessageBufferSize] && channel[kMessageBuffer][0].length < 4) {
65+
// Message length split into two buffers, so let's concatenate it.
66+
channel[kMessageBuffer][0] = Buffer.concat([channel[kMessageBuffer][0], readData]);
67+
} else {
68+
ArrayPrototypePush(channel[kMessageBuffer], readData);
69+
}
6570
channel[kMessageBufferSize] += readData.length;
6671

6772
// Index 0 should always be present because we just pushed data into it.
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
'use strict';
2+
const common = require('../common');
3+
const child_process = require('child_process');
4+
5+
// Regression test for https://github.com/nodejs/node/issues/55834
6+
const msgLen = 65521;
7+
let cnt = 10;
8+
9+
if (process.argv[2] === 'child') {
10+
const msg = Buffer.allocUnsafe(msgLen);
11+
(function send() {
12+
if (cnt--) {
13+
process.send(msg, send);
14+
} else {
15+
process.disconnect();
16+
}
17+
})();
18+
} else {
19+
const child = child_process.spawn(process.execPath, [__filename, 'child'], {
20+
stdio: ['inherit', 'inherit', 'inherit', 'ipc'],
21+
serialization: 'advanced'
22+
});
23+
child.on('message', common.mustCall(cnt));
24+
}

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy