repl: do not define wasi on global with no flag

cola119 · targos · commit 7892e23e68be · 2022-12-12T16:16:02.000Z
PR-URL: #45595 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/internal/main/repl.js b/lib/internal/main/repl.js
@@ -8,7 +8,6 @@ const {
   markBootstrapComplete
 } = require('internal/process/pre_execution');
 
-const esmLoader = require('internal/process/esm_loader');
 const {
   evalScript
 } = require('internal/process/execution');
@@ -37,6 +36,7 @@ if (process.env.NODE_REPL_EXTERNAL_MODULE) {
     process.exit(kGenericUserError);
   }
 
+  const esmLoader = require('internal/process/esm_loader');
   esmLoader.loadESM(() => {
     console.log(`Welcome to Node.js ${process.version}.\n` +
       'Type ".help" for more information.');
diff --git a/test/parallel/test-repl-built-in-modules.js b/test/parallel/test-repl-built-in-modules.js
@@ -30,3 +30,19 @@ assert.doesNotMatch(
   stdout,
   /Uncaught Error: Cannot find module 'wasi'[\w\W]+- <repl>\n/);
 assert.match(stdout, /{ WASI: \[class WASI\] }/);
+
+{
+  const res = cp.execFileSync(process.execPath, ['-i'], {
+    input: "'wasi' in global",
+    encoding: 'utf8',
+  });
+  // `wasi` shouldn't be defined on global when the flag is not set
+  assert.match(res, /false\n/);
+}
+{
+  const res = cp.execFileSync(process.execPath, ['-i', '--experimental-wasi-unstable-preview1'], {
+    input: "'wasi' in global",
+    encoding: 'utf8',
+  });
+  assert.match(res, /true\n/);
+}
