src: update NODE_MODULE_VERSION to 134

targos · targos · commit 7917b6731373 · 2025-01-31T12:46:02.000+01:00
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 13.0. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: #55014 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
diff --git a/doc/abi_version_registry.json b/doc/abi_version_registry.json
@@ -1,5 +1,6 @@
 {
   "NODE_MODULE_VERSION": [
+    { "modules": 134,"runtime": "node",     "variant": "v8_13.0",              "versions": "24.0.0-pre" },
     { "modules": 133,"runtime": "electron", "variant": "electron",             "versions": "35" },
     { "modules": 132,"runtime": "electron", "variant": "electron",             "versions": "34" },
     { "modules": 131,"runtime": "node",     "variant": "v8_12.9",              "versions": "23.0.0" },
diff --git a/src/node_version.h b/src/node_version.h
@@ -95,7 +95,7 @@
 #if defined(NODE_EMBEDDER_MODULE_VERSION)
 #define NODE_MODULE_VERSION NODE_EMBEDDER_MODULE_VERSION
 #else
-#define NODE_MODULE_VERSION 131
+#define NODE_MODULE_VERSION 134
 #endif
 
 // The NAPI_VERSION supported by the runtime. This is the inclusive range of

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"NODE_MODULE_VERSION": [`
	`3`	`+ { "modules": 134,"runtime": "node", "variant": "v8_13.0", "versions": "24.0.0-pre" },`
`3`	`4`	`{ "modules": 133,"runtime": "electron", "variant": "electron", "versions": "35" },`
`4`	`5`	`{ "modules": 132,"runtime": "electron", "variant": "electron", "versions": "34" },`
`5`	`6`	`{ "modules": 131,"runtime": "node", "variant": "v8_12.9", "versions": "23.0.0" },`