test: fix assertions in test-snapshot-dns-lookup*

tniessen · danielleadams · commit 847d74005c7b · 2023-04-03T07:49:39.000-04:00
Due to the unfortunate nature of JavaScript, the extraneous arguments are silently ignored. In this case, the assertion trivially passes regardless of the given regular expressions. Refs: #44633 PR-URL: #46618 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/test/internet/test-snapshot-dns-lookup.js b/test/internet/test-snapshot-dns-lookup.js
@@ -19,8 +19,8 @@ const env = {
 
 tmpdir.refresh();
 function checkOutput(stderr, stdout) {
-  assert(stdout.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/));
-  assert(stdout.match(stdout, /family: 4/));
+  assert.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/);
+  assert.match(stdout, /family: 4/);
   assert.strictEqual(stdout.trim().split('\n').length, 2);
 }
 {
diff --git a/test/parallel/test-snapshot-dns-lookup-localhost-promise.js b/test/parallel/test-snapshot-dns-lookup-localhost-promise.js
@@ -19,8 +19,8 @@ function checkOutput(stderr, stdout) {
   // We allow failures as it's not always possible to resolve localhost.
   // Functional tests are done in test/internet instead.
   if (!stderr.startsWith('error:')) {
-    assert(stdout.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/));
-    assert(stdout.match(stdout, /family: 4/));
+    assert.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/);
+    assert.match(stdout, /family: 4/);
     assert.strictEqual(stdout.trim().split('\n').length, 2);
   }
 }
diff --git a/test/parallel/test-snapshot-dns-lookup-localhost.js b/test/parallel/test-snapshot-dns-lookup-localhost.js
@@ -19,8 +19,8 @@ function checkOutput(stderr, stdout) {
   // We allow failures as it's not always possible to resolve localhost.
   // Functional tests are done in test/internet instead.
   if (!stderr.startsWith('error:')) {
-    assert(stdout.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/));
-    assert(stdout.match(stdout, /family: 4/));
+    assert.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/);
+    assert.match(stdout, /family: 4/);
     assert.strictEqual(stdout.trim().split('\n').length, 2);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -19,8 +19,8 @@ const env = {`
`19`	`19`
`20`	`20`	`tmpdir.refresh();`
`21`	`21`	`function checkOutput(stderr, stdout) {`
`22`		`- assert(stdout.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/));`
`23`		`- assert(stdout.match(stdout, /family: 4/));`
	`22`	`+ assert.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/);`
	`23`	`+ assert.match(stdout, /family: 4/);`
`24`	`24`	`assert.strictEqual(stdout.trim().split('\n').length, 2);`
`25`	`25`	`}`
`26`	`26`	`{`
Original file line number	Diff line number	Diff line change
`@@ -19,8 +19,8 @@ function checkOutput(stderr, stdout) {`
`19`	`19`	`// We allow failures as it's not always possible to resolve localhost.`
`20`	`20`	`// Functional tests are done in test/internet instead.`
`21`	`21`	`if (!stderr.startsWith('error:')) {`
`22`		`- assert(stdout.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/));`
`23`		`- assert(stdout.match(stdout, /family: 4/));`
	`22`	`+ assert.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/);`
	`23`	`+ assert.match(stdout, /family: 4/);`
`24`	`24`	`assert.strictEqual(stdout.trim().split('\n').length, 2);`
`25`	`25`	`}`
`26`	`26`	`}`