src: add dcheck_eq for Object::New constructor calls

JonasBa · RafaelGSS · commit 87fd838a7394 · 2025-05-02T17:06:41.000-03:00
PR-URL: #57943 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/src/node_sqlite.cc b/src/node_sqlite.cc
@@ -1996,6 +1996,7 @@ void StatementSync::All(const FunctionCallbackInfo<Value>& args) {
         row_values.emplace_back(val);
       }
 
+      DCHECK_EQ(row_keys.size(), row_values.size());
       Local<Object> row_obj = Object::New(
           isolate, Null(isolate), row_keys.data(), row_values.data(), num_cols);
       rows.emplace_back(row_obj);
@@ -2100,6 +2101,7 @@ void StatementSync::Get(const FunctionCallbackInfo<Value>& args) {
       values.emplace_back(val);
     }
 
+    DCHECK_EQ(keys.size(), values.size());
     Local<Object> result = Object::New(
         isolate, Null(isolate), keys.data(), values.data(), num_cols);
 
@@ -2448,6 +2450,7 @@ void StatementSyncIterator::Next(const FunctionCallbackInfo<Value>& args) {
   if (iter->done_) {
     LocalVector<Value> values(isolate,
                               {Boolean::New(isolate, true), Null(isolate)});
+    DCHECK_EQ(values.size(), keys.size());
     Local<Object> result = Object::New(
         isolate, Null(isolate), keys.data(), values.data(), keys.size());
     args.GetReturnValue().Set(result);
@@ -2461,6 +2464,7 @@ void StatementSyncIterator::Next(const FunctionCallbackInfo<Value>& args) {
     sqlite3_reset(iter->stmt_->statement_);
     LocalVector<Value> values(isolate,
                               {Boolean::New(isolate, true), Null(isolate)});
+    DCHECK_EQ(values.size(), keys.size());
     Local<Object> result = Object::New(
         isolate, Null(isolate), keys.data(), values.data(), keys.size());
     args.GetReturnValue().Set(result);
@@ -2493,11 +2497,13 @@ void StatementSyncIterator::Next(const FunctionCallbackInfo<Value>& args) {
       row_values.emplace_back(val);
     }
 
+    DCHECK_EQ(row_keys.size(), row_values.size());
     row_value = Object::New(
         isolate, Null(isolate), row_keys.data(), row_values.data(), num_cols);
   }
 
   LocalVector<Value> values(isolate, {Boolean::New(isolate, false), row_value});
+  DCHECK_EQ(keys.size(), values.size());
   Local<Object> result = Object::New(
       isolate, Null(isolate), keys.data(), values.data(), keys.size());
   args.GetReturnValue().Set(result);
@@ -2516,6 +2522,8 @@ void StatementSyncIterator::Return(const FunctionCallbackInfo<Value>& args) {
   LocalVector<Name> keys(isolate, {env->done_string(), env->value_string()});
   LocalVector<Value> values(isolate,
                             {Boolean::New(isolate, true), Null(isolate)});
+
+  DCHECK_EQ(keys.size(), values.size());
   Local<Object> result = Object::New(
       isolate, Null(isolate), keys.data(), values.data(), keys.size());
   args.GetReturnValue().Set(result);
