Skip to content

Commit 8e41dbb

Browse files
committed
doc: mention cherry-pick edge-case on release
PR-URL: #44408 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 048e440 commit 8e41dbb

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

doc/contributing/releases.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -699,10 +699,16 @@ placeholders (that happens when a change previously landed on another release
699699
branch), keep both version numbers. Convert the YAML field to an array if it is
700700
not already one.
701701

702+
[It's possible that the `cherry-pick` step will end up adding and/or
703+
changing unwanted lines](https://github.com/nodejs/Release/issues/771),
704+
please validate the changes in `doc/` folder files before confirming/continuing
705+
the cherry-pick step.
706+
702707
Then finish cherry-picking and push the commit upstream:
703708

704709
```console
705710
$ git add src/node_version.h doc
711+
$ git diff --staged src doc # read output to validate that changes shows up as expected
706712
$ git cherry-pick --continue
707713
$ make lint
708714
$ git push upstream main

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy