Skip to content

Commit 924ebcd

Browse files
joyeecheungRafaelGSS
authored andcommitted
http2: use args.This() instead of args.Holder()
args.Holder() has been removed in newer version of V8. PR-URL: #58004 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent 352df16 commit 924ebcd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/node_http2.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -768,7 +768,7 @@ void Http2Stream::EmitStatistics() {
768768

769769
void Http2Session::HasPendingData(const FunctionCallbackInfo<Value>& args) {
770770
Http2Session* session;
771-
ASSIGN_OR_RETURN_UNWRAP(&session, args.Holder());
771+
ASSIGN_OR_RETURN_UNWRAP(&session, args.This());
772772
args.GetReturnValue().Set(session->HasPendingData());
773773
}
774774

@@ -3578,7 +3578,7 @@ void Initialize(Local<Object> target,
35783578

35793579
void Http2Session::SetGracefulClose(const FunctionCallbackInfo<Value>& args) {
35803580
Http2Session* session;
3581-
ASSIGN_OR_RETURN_UNWRAP(&session, args.Holder());
3581+
ASSIGN_OR_RETURN_UNWRAP(&session, args.This());
35823582
CHECK_NOT_NULL(session);
35833583
// Set the graceful close flag
35843584
session->SetGracefulCloseInitiated(true);

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy