stream: improve views validation on BYOBRequest

daeyeon · danielleadams · commit 96c3373dbef9 · 2022-08-15T21:12:33.000-04:00
- This throws if the view is zero-length when there is an active reader when using `ReadableStreamBYOBRequest.respondWithNewView()`. - By doing that, we can get all tests passed in `readable-byte-streams/bad-buffers-and-views.any.js`. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #44155 Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-respond-with-new-view Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/internal/webstreams/readablestream.js b/lib/internal/webstreams/readablestream.js
@@ -2516,6 +2516,15 @@ function readableByteStreamControllerRespondWithNewView(controller, view) {
   const viewBuffer = ArrayBufferViewGetBuffer(view);
   const viewBufferByteLength = ArrayBufferGetByteLength(viewBuffer);
 
+  if (stream[kState].state === 'closed') {
+    if (viewByteLength !== 0)
+      throw new ERR_INVALID_STATE.TypeError('View is not zero-length');
+  } else {
+    assert(stream[kState].state === 'readable');
+    if (viewByteLength === 0)
+      throw new ERR_INVALID_STATE.TypeError('View is zero-length');
+  }
+
   const {
     byteOffset,
     byteLength,
diff --git a/test/wpt/status/streams.json b/test/wpt/status/streams.json
@@ -4,13 +4,5 @@
   },
   "transferable/deserialize-error.window.js": {
     "skip": "Browser-specific test"
-  },
-  "readable-byte-streams/bad-buffers-and-views.any.js": {
-    "fail": {
-      "note": "TODO: implement detached ArrayBuffer support",
-      "expected": [
-        "ReadableStream with byte source: respondWithNewView() throws if the supplied view's buffer is zero-length (in the readable state)"
-      ]
-    }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -4,13 +4,5 @@`
`4`	`4`	`},`
`5`	`5`	`"transferable/deserialize-error.window.js": {`
`6`	`6`	`"skip": "Browser-specific test"`
`7`		`- },`
`8`		`- "readable-byte-streams/bad-buffers-and-views.any.js": {`
`9`		`- "fail": {`
`10`		`- "note": "TODO: implement detached ArrayBuffer support",`
`11`		`- "expected": [`
`12`		`- "ReadableStream with byte source: respondWithNewView() throws if the supplied view's buffer is zero-length (in the readable state)"`
`13`		`- ]`
`14`		`- }`
`15`	`7`	`}`
`16`	`8`	`}`