http: be more generational GC friendly

ywave620 · targos · commit 974cec7a0a67 · 2025-02-02T17:37:04.000+01:00
Avoid any potential ref to Buffer in new generation from old generation PR-URL: #56767 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js
@@ -1218,6 +1218,8 @@ OutgoingMessage.prototype._flushOutput = function _flushOutput(socket) {
   // Refs: https://github.com/nodejs/node/pull/30958
   for (let i = 0; i < outputLength; i++) {
     const { data, encoding, callback } = outputData[i];
+    // Avoid any potential ref to Buffer in new generation from old generation
+    outputData[i].data = null;
     ret = socket.write(data, encoding, callback);
   }
   socket.uncork();

Original file line number	Diff line number	Diff line change
`@@ -1218,6 +1218,8 @@ OutgoingMessage.prototype._flushOutput = function _flushOutput(socket) {`
`1218`	`1218`	`// Refs: https://github.com/nodejs/node/pull/30958`
`1219`	`1219`	`for (let i = 0; i < outputLength; i++) {`
`1220`	`1220`	`const { data, encoding, callback } = outputData[i];`
	`1221`	`+ // Avoid any potential ref to Buffer in new generation from old generation`
	`1222`	`+ outputData[i].data = null;`
`1221`	`1223`	`ret = socket.write(data, encoding, callback);`
`1222`	`1224`	`}`
`1223`	`1225`	`socket.uncork();`