Skip to content

Commit a2b103a

Browse files
aduh95danielleadams
aduh95
authored and
danielleadams
committed
test: add trailing commas in test/pummel
PR-URL: #46610 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
1 parent 7eb1456 commit a2b103a

36 files changed

+175
-176
lines changed

‎test/.eslintrc.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ overrides:
7676
- es-module/*.mjs
7777
- parallel/*.js
7878
- parallel/*.mjs
79-
- pummel/*.js
8079
- sequential/*.js
8180
- sequential/*.mjs
8281
rules:

‎test/pummel/test-crypto-timing-safe-equal-benchmarks.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ const T_THRESHOLD = 3.892;
108108
const t = getTValue(crypto.timingSafeEqual);
109109
assert(
110110
Math.abs(t) < T_THRESHOLD,
111-
`timingSafeEqual should not leak information from its execution time (t=${t})`
111+
`timingSafeEqual should not leak information from its execution time (t=${t})`,
112112
);
113113

114114
// As a coherence check to make sure the statistical tests are working, run the
@@ -118,5 +118,5 @@ const unsafeCompare = (bufA, bufB) => bufA.equals(bufB);
118118
const t2 = getTValue(unsafeCompare);
119119
assert(
120120
Math.abs(t2) > T_THRESHOLD,
121-
`Buffer#equals should leak information from its execution time (t=${t2})`
121+
`Buffer#equals should leak information from its execution time (t=${t2})`,
122122
);

‎test/pummel/test-dh-regr.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,6 @@ for (let i = 0; i < 2000; i++) {
5454
bSecret,
5555
'Secrets should be equal.\n' +
5656
`aSecret: ${aSecret.toString('base64')}\n` +
57-
`bSecret: ${bSecret.toString('base64')}`
57+
`bSecret: ${bSecret.toString('base64')}`,
5858
);
5959
}

‎test/pummel/test-fs-readfile-tostring-fail.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ tmpdir.refresh();
1818

1919
const file = path.join(tmpdir.path, 'toobig.txt');
2020
const stream = fs.createWriteStream(file, {
21-
flags: 'a'
21+
flags: 'a',
2222
});
2323

2424
stream.on('error', (err) => { throw err; });
@@ -44,7 +44,7 @@ stream.on('finish', common.mustCall(function() {
4444
message: 'Cannot create a string longer than ' +
4545
`0x${stringLengthHex} characters`,
4646
code: 'ERR_STRING_TOO_LONG',
47-
name: 'Error'
47+
name: 'Error',
4848
})(err);
4949
}
5050
assert.strictEqual(buf, undefined);

‎test/pummel/test-fs-watch-file.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ fs.writeFileSync(filepathOne, 'hello');
5858

5959
assert.throws(
6060
() => { fs.watchFile(filepathOne); },
61-
{ code: 'ERR_INVALID_ARG_TYPE' }
61+
{ code: 'ERR_INVALID_ARG_TYPE' },
6262
);
6363

6464
// Does not throw.
@@ -78,7 +78,7 @@ fs.writeFileSync(filepathTwoAbs, 'howdy');
7878

7979
assert.throws(
8080
() => { fs.watchFile(filepathTwo); },
81-
{ code: 'ERR_INVALID_ARG_TYPE' }
81+
{ code: 'ERR_INVALID_ARG_TYPE' },
8282
);
8383

8484
{ // Does not throw.

‎test/pummel/test-heapdump-dns.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ validateSnapshotNodes('Node / ChannelWrap', [
1414
// `Node / ChannelWrap` (C++) -> `ChannelWrap` (JS)
1515
{ node_name: 'ChannelWrap', edge_name: 'native_to_javascript' },
1616
],
17-
detachedness: 2
17+
detachedness: 2,
1818
},
1919
]);

‎test/pummel/test-heapdump-env.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ validateSnapshotNodes('Node / Environment', [{
1818
{ node_name: 'Node / CleanupQueue', edge_name: 'cleanup_queue' },
1919
{ node_name: 'Node / IsolateData', edge_name: 'isolate_data' },
2020
{ node_name: 'Node / Realm', edge_name: 'principal_realm' },
21-
]
21+
],
2222
}]);
2323

2424
validateSnapshotNodes('Node / CleanupQueue', [
@@ -28,14 +28,14 @@ validateSnapshotNodes('Node / CleanupQueue', [
2828
{
2929
children: [
3030
{ node_name: 'Node / ContextifyScript' },
31-
]
31+
],
3232
},
3333
]);
3434

3535
validateSnapshotNodes('Node / Realm', [{
3636
children: [
3737
{ node_name: 'process', edge_name: 'process_object' },
38-
]
38+
],
3939
}]);
4040

4141
console.log(context); // Make sure it's not GC'ed

‎test/pummel/test-heapdump-fs-promise.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@ validateSnapshotNodes('Node / FSReqPromise', [
1111
children: [
1212
{ node_name: 'FSReqPromise', edge_name: 'native_to_javascript' },
1313
{ node_name: 'Float64Array', edge_name: 'stats_field_array' },
14-
]
14+
],
1515
},
1616
]);

‎test/pummel/test-heapdump-http2.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ server.listen(0, () => {
2929
children: [
3030
// current_headers and/or queue could be empty
3131
{ node_name: 'Http2Stream', edge_name: 'native_to_javascript' },
32-
]
32+
],
3333
},
3434
], { loose: true });
3535

@@ -39,29 +39,29 @@ server.listen(0, () => {
3939
children: [
4040
{ node_name: 'FileHandle', edge_name: 'native_to_javascript' },
4141
// current_headers could be empty
42-
]
42+
],
4343
},
4444
], { loose: true });
4545
state.validateSnapshotNodes('Node / TCPSocketWrap', [
4646
{
4747
children: [
4848
{ node_name: 'TCP', edge_name: 'native_to_javascript' },
49-
]
49+
],
5050
},
5151
], { loose: true });
5252
state.validateSnapshotNodes('Node / TCPServerWrap', [
5353
{
5454
children: [
5555
{ node_name: 'TCP', edge_name: 'native_to_javascript' },
56-
]
56+
],
5757
},
5858
], { loose: true });
5959
// `Node / StreamPipe` (C++) -> StreamPipe (JS)
6060
state.validateSnapshotNodes('Node / StreamPipe', [
6161
{
6262
children: [
6363
{ node_name: 'StreamPipe', edge_name: 'native_to_javascript' },
64-
]
64+
],
6565
},
6666
]);
6767
// `Node / Http2Session` (C++) -> Http2Session (JS)
@@ -71,11 +71,11 @@ server.listen(0, () => {
7171
{ node_name: 'Http2Session', edge_name: 'native_to_javascript' },
7272
{ node_name: 'Node / nghttp2_memory', edge_name: 'nghttp2_memory' },
7373
{
74-
node_name: 'Node / streams', edge_name: 'streams'
74+
node_name: 'Node / streams', edge_name: 'streams',
7575
},
7676
// outstanding_pings, outgoing_buffers, outgoing_storage,
7777
// pending_rst_streams could be empty
78-
]
78+
],
7979
},
8080
], { loose: true });
8181
}));

‎test/pummel/test-heapdump-inspector.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const inspector = require('inspector');
1010
const snapshotNode = {
1111
children: [
1212
{ node_name: 'Node / InspectorSession', edge_name: 'session' },
13-
]
13+
],
1414
};
1515

1616
// Starts with no JSBindingsConnection (or 1 if coverage enabled).
@@ -34,7 +34,7 @@ const snapshotNode = {
3434
(edge) => edge.name === 'callback' &&
3535
(edge.to.type === undefined || // embedded graph
3636
edge.to.type === 'closure'), // snapshot
37-
]
37+
],
3838
},
3939
];
4040
if (process.env.NODE_V8_COVERAGE) {

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy