tools: fix require-common-first lint rule from subfolder

aduh95 · aduh95 · commit a4f336fdd460 · 2025-01-02T15:28:12.000+01:00
PR-URL: #56325 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
diff --git a/test/addons/esm/test-esm.mjs b/test/addons/esm/test-esm.mjs
@@ -4,7 +4,6 @@
  * the ESM loader or the CJS loader.
  */
 
-// eslint-disable-next-line node-core/require-common-first
 import { buildType } from '../../common/index.mjs';
 import assert from 'node:assert';
 import { createRequire } from 'node:module';
diff --git a/test/parallel/test-eslint-require-common-first.js b/test/parallel/test-eslint-require-common-first.js
@@ -20,6 +20,12 @@ new RuleTester({
       code: 'require("common")\n' +
             'require("assert")'
     },
+    {
+      code: 'import "../../../../common/index.mjs";',
+      languageOptions: {
+        sourceType: 'module',
+      },
+    },
   ],
   invalid: [
     {
diff --git a/tools/eslint-rules/require-common-first.js b/tools/eslint-rules/require-common-first.js
@@ -22,7 +22,7 @@ module.exports = {
      * @returns {string} module name
      */
     function getModuleName(str) {
-      if (str === '../common/index.mjs') {
+      if (str.startsWith('../') && str.endsWith('/common/index.mjs')) {
         return 'common';
       }
 

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ module.exports = {`
`22`	`22`	`* @returns {string} module name`
`23`	`23`	`*/`
`24`	`24`	`function getModuleName(str) {`
`25`		`- if (str === '../common/index.mjs') {`
	`25`	`+ if (str.startsWith('../') && str.endsWith('/common/index.mjs')) {`
`26`	`26`	`return 'common';`
`27`	`27`	`}`
`28`	`28`