test: use mustSucceed instead of mustCall with assert.ifError

fossamagna · danielleadams · commit b0e3e6968666 · 2022-08-15T21:12:29.000-04:00
PR-URL: #44196 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/test/sequential/test-inspector-open.js b/test/sequential/test-inspector-open.js
@@ -32,25 +32,23 @@ let firstPort;
 function firstOpen(msg) {
   assert.strictEqual(msg.cmd, 'url');
   const port = url.parse(msg.url).port;
-  ping(port, (err) => {
-    assert.ifError(err);
+  ping(port, common.mustSucceed(() => {
     // Inspector is already open, and won't be reopened, so args don't matter.
     child.send({ cmd: 'open', args: [kOpenWhileOpen] });
     child.once('message', common.mustCall(tryToOpenWhenOpen));
     firstPort = port;
-  });
+  }));
 }
 
 function tryToOpenWhenOpen(msg) {
   assert.strictEqual(msg.cmd, 'url');
   const port = url.parse(msg.url).port;
   // Reopen didn't do anything, the port was already open, and has not changed.
   assert.strictEqual(port, firstPort);
-  ping(port, (err) => {
-    assert.ifError(err);
+  ping(port, common.mustSucceed(() => {
     child.send({ cmd: 'close' });
     child.once('message', common.mustCall(closeWhenOpen));
-  });
+  }));
 }
 
 function closeWhenOpen(msg) {
@@ -73,10 +71,9 @@ function tryToCloseWhenClosed(msg) {
 function reopenAfterClose(msg) {
   assert.strictEqual(msg.cmd, 'url');
   const port = url.parse(msg.url).port;
-  ping(port, (err) => {
-    assert.ifError(err);
+  ping(port, common.mustSucceed(() => {
     process.exit();
-  });
+  }));
 }
 
 function ping(port, callback) {
