net: check autoSelectFamilyAttemptTimeout is positive

deokjinkim · targos · commit b9c2fc762347 · 2022-12-13T09:42:39.000Z
In document, `autoSelectFamilyAttemptTimeout` is described as positive integer because it's time unit. But there is no checking whether it's positive integer. PR-URL: #45740 Refs: https://github.com/nodejs/node/blob/main/doc/api/net.md#socketconnectoptions-connectlistener Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/net.js b/lib/net.js
@@ -1210,7 +1210,7 @@ function lookupAndConnect(self, options) {
   }
 
   if (autoSelectFamilyAttemptTimeout !== undefined) {
-    validateInt32(autoSelectFamilyAttemptTimeout);
+    validateInt32(autoSelectFamilyAttemptTimeout, 'options.autoSelectFamilyAttemptTimeout', 1);
 
     if (autoSelectFamilyAttemptTimeout < 10) {
       autoSelectFamilyAttemptTimeout = 10;
diff --git a/test/parallel/test-net-socket-connect-invalid-autoselectfamilyattempttimeout.js b/test/parallel/test-net-socket-connect-invalid-autoselectfamilyattempttimeout.js
@@ -0,0 +1,14 @@
+'use strict';
+require('../common');
+const assert = require('assert');
+const net = require('net');
+
+for (const autoSelectFamilyAttemptTimeout of [-10, 0]) {
+  assert.throws(() => {
+    net.connect({
+      port: 8080,
+      autoSelectFamily: true,
+      autoSelectFamilyAttemptTimeout,
+    });
+  }, { code: 'ERR_OUT_OF_RANGE' });
+}

Original file line number	Diff line number	Diff line change
`@@ -1210,7 +1210,7 @@ function lookupAndConnect(self, options) {`
`1210`	`1210`	`}`
`1211`	`1211`
`1212`	`1212`	`if (autoSelectFamilyAttemptTimeout !== undefined) {`
`1213`		`- validateInt32(autoSelectFamilyAttemptTimeout);`
	`1213`	`+ validateInt32(autoSelectFamilyAttemptTimeout, 'options.autoSelectFamilyAttemptTimeout', 1);`
`1214`	`1214`
`1215`	`1215`	`if (autoSelectFamilyAttemptTimeout < 10) {`
`1216`	`1216`	`autoSelectFamilyAttemptTimeout = 10;`