src: use string_view instead of std::string&

anonrig · danielleadams · commit b9ca3025584c · 2023-04-02T21:40:47.000-04:00
PR-URL: #46471 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/inspector/main_thread_interface.cc b/src/inspector/main_thread_interface.cc
@@ -289,7 +289,7 @@ Deletable* MainThreadInterface::GetObjectIfExists(int id) {
   return iterator->second.get();
 }
 
-std::unique_ptr<StringBuffer> Utf8ToStringView(const std::string& message) {
+std::unique_ptr<StringBuffer> Utf8ToStringView(const std::string_view message) {
   size_t expected_u16_length =
       simdutf::utf16_length_from_utf8(message.data(), message.length());
   MaybeStackBuffer<char16_t> buffer(expected_u16_length);
diff --git a/src/inspector/main_thread_interface.h b/src/inspector/main_thread_interface.h
@@ -34,7 +34,7 @@ class Deletable {
 };
 
 std::unique_ptr<v8_inspector::StringBuffer> Utf8ToStringView(
-    const std::string& message);
+    const std::string_view message);
 
 using MessageQueue = std::deque<std::unique_ptr<Request>>;
 

Original file line number	Diff line number	Diff line change
`@@ -289,7 +289,7 @@ Deletable* MainThreadInterface::GetObjectIfExists(int id) {`
`289`	`289`	`return iterator->second.get();`
`290`	`290`	`}`
`291`	`291`
`292`		`-std::unique_ptr<StringBuffer> Utf8ToStringView(const std::string& message) {`
	`292`	`+std::unique_ptr<StringBuffer> Utf8ToStringView(const std::string_view message) {`
`293`	`293`	`size_t expected_u16_length =`
`294`	`294`	`simdutf::utf16_length_from_utf8(message.data(), message.length());`
`295`	`295`	`MaybeStackBuffer<char16_t> buffer(expected_u16_length);`