src: check return value of ftell()

tniessen · danielleadams · commit bc9a57762586 · 2023-04-02T21:40:48.000-04:00
If ftell() returns -1L, abort instead of passing static_cast<size_t>(-1) to the vector allocator and fread(). Refs: #46463 PR-URL: #46495 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
diff --git a/src/node_snapshotable.cc b/src/node_snapshotable.cc
@@ -867,6 +867,7 @@ bool SnapshotData::FromBlob(SnapshotData* out, FILE* in) {
   int err = fseek(in, 0, SEEK_END);
   CHECK_EQ(err, 0);
   size_t size = ftell(in);
+  CHECK_NE(size, static_cast<size_t>(-1L));
   err = fseek(in, 0, SEEK_SET);
   CHECK_EQ(err, 0);
 
