events: allow null/undefined eventInitDict

KhafraDev · targos · commit be2fe4b249c4 · 2024-10-04T10:20:15.000+02:00
PR-URL: #54643 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js
@@ -111,14 +111,14 @@ class Event {
    *   composed?: boolean,
    * }} [options]
    */
-  constructor(type, options = kEmptyObject) {
+  constructor(type, options = undefined) {
     if (arguments.length === 0)
       throw new ERR_MISSING_ARGS('type');
-    validateObject(options, 'options');
-    const { bubbles, cancelable, composed } = options;
-    this.#cancelable = !!cancelable;
-    this.#bubbles = !!bubbles;
-    this.#composed = !!composed;
+    if (options != null)
+      validateObject(options, 'options');
+    this.#bubbles = !!options?.bubbles;
+    this.#cancelable = !!options?.cancelable;
+    this.#composed = !!options?.composed;
 
     this[kType] = `${type}`;
     if (options?.[kTrustEvent]) {
diff --git a/test/parallel/test-eventtarget.js b/test/parallel/test-eventtarget.js
@@ -747,3 +747,9 @@ let asyncTest = Promise.resolve();
   event.cancelBubble = true;
   strictEqual(event.cancelBubble, true);
 }
+
+{
+  // A null eventInitDict should not throw an error.
+  new Event('', null);
+  new Event('', undefined);
+}
