test: simplify test-tls-ecdh-multiple

tniessen · danielleadams · commit ef6c86c59fbf · 2023-04-10T20:55:12.000-04:00
Avoid the process 'exit' event handler and use execFile instead of manual stream operations. Refs: #46751 PR-URL: #46963 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
diff --git a/test/parallel/test-tls-ecdh-multiple.js b/test/parallel/test-tls-ecdh-multiple.js
@@ -12,7 +12,7 @@ if (!common.opensslCli)
 
 const assert = require('assert');
 const tls = require('tls');
-const spawn = require('child_process').spawn;
+const { execFile } = require('child_process');
 const fixtures = require('../common/fixtures');
 
 function loadPEM(n) {
@@ -29,49 +29,33 @@ const options = {
 
 const reply = 'I AM THE WALRUS'; // Something recognizable
 
-const server = tls.createServer(options, function(conn) {
+const server = tls.createServer(options, (conn) => {
   conn.end(reply);
-});
-
-let gotReply = false;
-
-server.listen(0, function() {
+}).listen(0, common.mustCall(() => {
   const args = ['s_client',
                 '-cipher', `${options.ciphers}`,
-                '-connect', `127.0.0.1:${this.address().port}`];
-
-  const client = spawn(common.opensslCli, args);
-
-  client.stdout.on('data', function(data) {
-    const message = data.toString();
-    if (message.includes(reply))
-      gotReply = true;
-  });
+                '-connect', `127.0.0.1:${server.address().port}`];
 
-  client.on('exit', function(code) {
-    assert.strictEqual(code, 0);
+  execFile(common.opensslCli, args, common.mustSucceed((stdout) => {
+    assert(stdout.includes(reply));
     server.close();
-  });
-
-  client.on('error', assert.ifError);
-});
+  }));
+}));
 
-process.on('exit', function() {
-  assert.ok(gotReply);
-
-  // Some of unsupported curves
+{
+  // Some unsupported curves.
   const unsupportedCurves = [
     'wap-wsg-idm-ecid-wtls1',
     'c2pnb163v1',
     'prime192v3',
   ];
 
-  // Brainpool is not supported in FIPS mode
+  // Brainpool is not supported in FIPS mode.
   if (common.hasFipsCrypto)
     unsupportedCurves.push('brainpoolP256r1');
 
   unsupportedCurves.forEach((ecdhCurve) => {
     assert.throws(() => tls.createServer({ ecdhCurve }),
                   /Error: Failed to set ECDH curve/);
   });
-});
+}
