fs: refactor rimraf to avoid using primordials

anonrig · targos · commit f0c55e206d69 · 2024-10-02T16:04:14.000+02:00
PR-URL: #54834 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/internal/fs/rimraf.js b/lib/internal/fs/rimraf.js
@@ -140,8 +140,10 @@ function _rmchildren(path, options, callback) {
 
     let done = false;
 
-    ArrayPrototypeForEach(files, (child) => {
-      const childPath = Buffer.concat([pathBuf, separator, child]);
+    const childPathPrefix = Buffer.concat([pathBuf, separator]);
+
+    for (let i = 0; i < files.length; i++) {
+      const childPath = Buffer.concat([childPathPrefix, files[i]]);
 
       rimraf(childPath, options, (err) => {
         if (done)
@@ -156,7 +158,7 @@ function _rmchildren(path, options, callback) {
         if (numFiles === 0)
           rmdir(path, callback);
       });
-    });
+    }
   });
 }
 
