assert,util: improve deep object comparison performance

BridgeAR · RafaelGSS · commit f4572f08266d · 2025-05-02T17:06:01.000-03:00
This improves the performance for almost all objects when comparing them deeply. PR-URL: #57648 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
diff --git a/benchmark/assert/deepequal-map.js b/benchmark/assert/deepequal-map.js
@@ -31,7 +31,7 @@ function benchmark(method, n, values, values2) {
 }
 
 function main({ n, len, method, strict }) {
-  const array = Array(len).fill(1);
+  const array = Array.from({ length: len }, () => '');
 
   switch (method) {
     case 'deepEqual_primitiveOnly': {
diff --git a/benchmark/assert/deepequal-prims-and-objs-big-loop.js b/benchmark/assert/deepequal-prims-and-objs-big-loop.js
@@ -14,7 +14,6 @@ const primValues = {
   'number': 1_000,
   'boolean': true,
   'object': { property: 'abcdef' },
-  'object_other_property': { property: 'abcdef' },
   'array': [1, 2, 3],
   'set_object': new Set([[1]]),
   'set_simple': new Set([1, 2, 3]),
diff --git a/benchmark/assert/deepequal-set.js b/benchmark/assert/deepequal-set.js
@@ -6,8 +6,9 @@ const { deepEqual, deepStrictEqual, notDeepEqual, notDeepStrictEqual } =
 
 const bench = common.createBenchmark(main, {
   n: [1e3],
-  len: [5e2],
+  len: [2, 1e2],
   strict: [0, 1],
+  order: ['insert', 'random', 'reversed'],
   method: [
     'deepEqual_primitiveOnly',
     'deepEqual_objectOnly',
@@ -16,12 +17,30 @@ const bench = common.createBenchmark(main, {
     'notDeepEqual_objectOnly',
     'notDeepEqual_mixed',
   ],
+}, {
+  combinationFilter(p) {
+    return p.order !== 'random' || p.strict === 1 && p.method !== 'notDeepEqual_objectOnly';
+  },
 });
 
-function benchmark(method, n, values, values2) {
+function shuffleArray(array) {
+  for (let i = array.length - 1; i > 0; i--) {
+    const j = Math.floor(Math.random() * (i + 1));
+    const temp = array[i];
+    array[i] = array[j];
+    array[j] = temp;
+  }
+}
+
+function benchmark(method, n, values, values2, order) {
   const actual = new Set(values);
   // Prevent reference equal elements
-  const deepCopy = JSON.parse(JSON.stringify(values2 ? values2 : values));
+  let deepCopy = JSON.parse(JSON.stringify(values2));
+  if (order === 'reversed') {
+    deepCopy = deepCopy.reverse();
+  } else if (order === 'random') {
+    shuffleArray(deepCopy);
+  }
   const expected = new Set(deepCopy);
   bench.start();
   for (let i = 0; i < n; ++i) {
@@ -30,39 +49,39 @@ function benchmark(method, n, values, values2) {
   bench.end(n);
 }
 
-function main({ n, len, method, strict }) {
-  const array = Array(len).fill(1);
+function main({ n, len, method, strict, order }) {
+  const array = Array.from({ length: len }, () => '');
 
   switch (method) {
     case 'deepEqual_primitiveOnly': {
       const values = array.map((_, i) => `str_${i}`);
-      benchmark(strict ? deepStrictEqual : deepEqual, n, values);
+      benchmark(strict ? deepStrictEqual : deepEqual, n, values, values, order);
       break;
     }
     case 'deepEqual_objectOnly': {
       const values = array.map((_, i) => [`str_${i}`, null]);
-      benchmark(strict ? deepStrictEqual : deepEqual, n, values);
+      benchmark(strict ? deepStrictEqual : deepEqual, n, values, values, order);
       break;
     }
     case 'deepEqual_mixed': {
       const values = array.map((_, i) => {
         return i % 2 ? [`str_${i}`, null] : `str_${i}`;
       });
-      benchmark(strict ? deepStrictEqual : deepEqual, n, values);
+      benchmark(strict ? deepStrictEqual : deepEqual, n, values, values, order);
       break;
     }
     case 'notDeepEqual_primitiveOnly': {
       const values = array.map((_, i) => `str_${i}`);
       const values2 = values.slice(0);
       values2[Math.floor(len / 2)] = 'w00t';
-      benchmark(strict ? notDeepStrictEqual : notDeepEqual, n, values, values2);
+      benchmark(strict ? notDeepStrictEqual : notDeepEqual, n, values, values2, order);
       break;
     }
     case 'notDeepEqual_objectOnly': {
       const values = array.map((_, i) => [`str_${i}`, null]);
       const values2 = values.slice(0);
       values2[Math.floor(len / 2)] = ['w00t'];
-      benchmark(strict ? notDeepStrictEqual : notDeepEqual, n, values, values2);
+      benchmark(strict ? notDeepStrictEqual : notDeepEqual, n, values, values2, order);
       break;
     }
     case 'notDeepEqual_mixed': {
@@ -71,7 +90,7 @@ function main({ n, len, method, strict }) {
       });
       const values2 = values.slice();
       values2[0] = 'w00t';
-      benchmark(strict ? notDeepStrictEqual : notDeepEqual, n, values, values2);
+      benchmark(strict ? notDeepStrictEqual : notDeepEqual, n, values, values2, order);
       break;
     }
     default:
diff --git a/benchmark/assert/partial-deep-equal.js b/benchmark/assert/partial-deep-equal.js
@@ -62,7 +62,7 @@ function createSets(length, extraProps, depth = 0) {
       number: i,
     },
     ['array', 'with', 'values'],
-    !depth ? new Set([1, 2, { nested: i }]) : new Set(),
+    !depth ? new Set([1, { nested: i }]) : new Set(),
     !depth ? createSets(2, extraProps, depth + 1) : null,
   ]));
 }
diff --git a/lib/internal/util/comparisons.js b/lib/internal/util/comparisons.js
diff --git a/test/parallel/test-assert-deep.js b/test/parallel/test-assert-deep.js

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ function benchmark(method, n, values, values2) {`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`function main({ n, len, method, strict }) {`
`34`		`- const array = Array(len).fill(1);`
	`34`	`+ const array = Array.from({ length: len }, () => '');`
`35`	`35`
`36`	`36`	`switch (method) {`
`37`	`37`	`case 'deepEqual_primitiveOnly': {`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ function createSets(length, extraProps, depth = 0) {`
`62`	`62`	`number: i,`
`63`	`63`	`},`
`64`	`64`	`['array', 'with', 'values'],`
`65`		`- !depth ? new Set([1, 2, { nested: i }]) : new Set(),`
	`65`	`+ !depth ? new Set([1, { nested: i }]) : new Set(),`
`66`	`66`	`!depth ? createSets(2, extraProps, depth + 1) : null,`
`67`	`67`	`]));`
`68`	`68`	`}`