test: fix volatile for CauseSegfault with clang

tie · targos · commit f7af8ca02120 · 2024-10-02T07:57:58.000+02:00
PR-URL: #54325 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/node_process_methods.cc b/src/node_process_methods.cc
@@ -72,7 +72,7 @@ static void Abort(const FunctionCallbackInfo<Value>& args) {
 // For internal testing only, not exposed to userland.
 static void CauseSegfault(const FunctionCallbackInfo<Value>& args) {
   // This should crash hard all platforms.
-  volatile void** d = static_cast<volatile void**>(nullptr);
+  void* volatile* d = static_cast<void* volatile*>(nullptr);
   *d = nullptr;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ static void Abort(const FunctionCallbackInfo<Value>& args) {`
`72`	`72`	`// For internal testing only, not exposed to userland.`
`73`	`73`	`static void CauseSegfault(const FunctionCallbackInfo<Value>& args) {`
`74`	`74`	`// This should crash hard all platforms.`
`75`		`- volatile void d = static_cast<volatile void>(nullptr);`
	`75`	`+ void* volatile* d = static_cast<void* volatile*>(nullptr);`
`76`	`76`	`*d = nullptr;`
`77`	`77`	`}`
`78`	`78`