fs: remove ability to call truncate with fd

anonrig · RafaelGSS · commit fabf9384e0d8 · 2025-05-02T17:05:38.000-03:00
PR-URL: #57567 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
@@ -1832,12 +1832,15 @@ and replaced with an identical, public `path.toNamespacedPath()` method.
 
 <!-- YAML
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/57567
+    description: End-of-Life.
   - version: v9.0.0
     pr-url: https://github.com/nodejs/node/pull/15990
     description: Runtime deprecation.
 -->
 
-Type: Runtime
+Type: End-of-Life
 
 `fs.truncate()` `fs.truncateSync()` usage with a file descriptor is
 deprecated. Please use `fs.ftruncate()` or `fs.ftruncateSync()` to work with
diff --git a/lib/fs.js b/lib/fs.js
@@ -153,7 +153,6 @@ const {
 
 const permission = require('internal/process/permission');
 
-let truncateWarn = true;
 let fs;
 
 // Lazy loaded
@@ -171,16 +170,6 @@ let ReadFileContext;
 let FileReadStream;
 let FileWriteStream;
 
-function showTruncateDeprecation() {
-  if (truncateWarn) {
-    process.emitWarning(
-      'Using fs.truncate with a file descriptor is deprecated. Please use ' +
-      'fs.ftruncate with a file descriptor instead.',
-      'DeprecationWarning', 'DEP0081');
-    truncateWarn = false;
-  }
-}
-
 // Ensure that callbacks run in the global context. Only use this function
 // for callbacks that are passed to the binding layer, callbacks that are
 // invoked from JS already run in the proper scope.
@@ -1035,10 +1024,6 @@ function renameSync(oldPath, newPath) {
  * @returns {void}
  */
 function truncate(path, len, callback) {
-  if (typeof path === 'number') {
-    showTruncateDeprecation();
-    return fs.ftruncate(path, len, callback);
-  }
   if (typeof len === 'function') {
     callback = len;
     len = 0;
@@ -1068,11 +1053,6 @@ function truncate(path, len, callback) {
  * @returns {void}
  */
 function truncateSync(path, len) {
-  if (typeof path === 'number') {
-    // legacy
-    showTruncateDeprecation();
-    return fs.ftruncateSync(path, len);
-  }
   if (len === undefined) {
     len = 0;
   }
diff --git a/test/parallel/test-fs-truncate-fd.js b/test/parallel/test-fs-truncate-fd.js
diff --git a/test/parallel/test-fs-truncate-sync.js b/test/parallel/test-fs-truncate-sync.js
@@ -12,10 +12,7 @@ const filename = path.resolve(tmp, 'truncate-sync-file.txt');
 
 fs.writeFileSync(filename, 'hello world', 'utf8');
 
-const fd = fs.openSync(filename, 'r+');
+fs.truncateSync(filename, 5);
+assert(fs.readFileSync(filename).equals(Buffer.from('hello')));
 
-fs.truncateSync(fd, 5);
-assert(fs.readFileSync(fd).equals(Buffer.from('hello')));
-
-fs.closeSync(fd);
 fs.unlinkSync(filename);
diff --git a/test/parallel/test-fs-truncate.js b/test/parallel/test-fs-truncate.js
@@ -33,9 +33,6 @@ tmpdir.refresh();
 
 let stat;
 
-const msg = 'Using fs.truncate with a file descriptor is deprecated.' +
-            ' Please use fs.ftruncate with a file descriptor instead.';
-
 // Check truncateSync
 fs.writeFileSync(filename, data);
 stat = fs.statSync(filename);
@@ -64,10 +61,6 @@ fs.ftruncateSync(fd);
 stat = fs.statSync(filename);
 assert.strictEqual(stat.size, 0);
 
-// truncateSync
-common.expectWarning('DeprecationWarning', msg, 'DEP0081');
-fs.truncateSync(fd);
-
 fs.closeSync(fd);
 
 // Async tests
